geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r578444 - /geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/session/ExecutorThreadModel.java
Date Sat, 22 Sep 2007 14:21:43 GMT
Author: jdillon
Date: Sat Sep 22 07:21:43 2007
New Revision: 578444

URL: http://svn.apache.org/viewvc?rev=578444&view=rev
Log:
Disable the executor shutdown for now, it pukes up bad things

Modified:
    geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/session/ExecutorThreadModel.java

Modified: geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/session/ExecutorThreadModel.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/session/ExecutorThreadModel.java?rev=578444&r1=578443&r2=578444&view=diff
==============================================================================
--- geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/session/ExecutorThreadModel.java
(original)
+++ geronimo/sandbox/gshell/trunk/gshell-remote/gshell-remote-common/src/main/java/org/apache/geronimo/gshell/remote/session/ExecutorThreadModel.java
Sat Sep 22 07:21:43 2007
@@ -39,6 +39,7 @@
  *
  * @version $Rev$ $Date$
  */
+@SuppressWarnings({"FieldCanBeLocal"})
 public class ExecutorThreadModel
     implements ThreadModel
 {
@@ -48,8 +49,6 @@
 
     private final ThreadGroup group;
 
-    private final AtomicLong counter = new AtomicLong(0);
-
     private final ExecutorService executor;
 
     private final ExecutorFilter filter;
@@ -80,11 +79,19 @@
     }
 
     public void close() {
+        //
+        // FIXME: This causes some problems when a rsh client closes, like:
+        //
+        //        java.security.AccessControlException: access denied (java.lang.RuntimePermission
modifyThread)
+        //
+
+        /*
         List<Runnable> pending = executor.shutdownNow();
 
         if (!pending.isEmpty()) {
             log.warn("There were {} pending tasks which have not been run", pending.size());
         }
+        */
     }
     
     //



Mime
View raw message