geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r573685 - in /geronimo/sandbox/gshell/trunk: gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java
Date Fri, 07 Sep 2007 19:59:56 GMT
Author: jdillon
Date: Fri Sep  7 12:59:55 2007
New Revision: 573685

URL: http://svn.apache.org/viewvc?rev=573685&view=rev
Log:
More minor logging muck, notes about moving error handling to shell

Modified:
    geronimo/sandbox/gshell/trunk/gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java
    geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java

Modified: geronimo/sandbox/gshell/trunk/gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java?rev=573685&r1=573684&r2=573685&view=diff
==============================================================================
--- geronimo/sandbox/gshell/trunk/gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java
(original)
+++ geronimo/sandbox/gshell/trunk/gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java
Fri Sep  7 12:59:55 2007
@@ -61,6 +61,10 @@
 
         Object result = null;
 
+        //
+        // TODO: Move this error handling/logging muck up to the shell....
+        //
+        
         try {
             CommandLineProcessor clp = new CommandLineProcessor(this);
             clp.process(Arguments.toStringArray(args));

Modified: geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java?rev=573685&r1=573684&r2=573685&view=diff
==============================================================================
--- geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java
(original)
+++ geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java
Fri Sep  7 12:59:55 2007
@@ -132,7 +132,7 @@
         try {
             result = command.execute(args);
 
-            log.debug("Command completed in: {}", watch);
+            log.debug("Command completed with result: {}, after: {}", result, watch);
         }
         finally {
             // Make sure that the commands output has been flushed



Mime
View raw message