geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r573381 - in /geronimo/sandbox/gshell/trunk: gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/ gshell-core/src/main/java/org/apache/geronimo/gshell/ gshell-parser/src/main/grammar/
Date Thu, 06 Sep 2007 21:14:22 GMT
Author: jdillon
Date: Thu Sep  6 14:14:22 2007
New Revision: 573381

URL: http://svn.apache.org/viewvc?rev=573381&view=rev
Log:
A bit more logging clean up

Modified:
    geronimo/sandbox/gshell/trunk/gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java
    geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java
    geronimo/sandbox/gshell/trunk/gshell-parser/src/main/grammar/CommandLineParser.jjt

Modified: geronimo/sandbox/gshell/trunk/gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java?rev=573381&r1=573380&r2=573381&view=diff
==============================================================================
--- geronimo/sandbox/gshell/trunk/gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java
(original)
+++ geronimo/sandbox/gshell/trunk/gshell-command-api/src/main/java/org/apache/geronimo/gshell/command/CommandSupport.java
Thu Sep  6 14:14:22 2007
@@ -80,9 +80,7 @@
         }
         catch (Exception e) {
             log.error(e.getMessage());
-            if (log.isDebugEnabled()) {
-                log.debug("Exception details", e);
-            }
+            log.debug("Exception details", e);
 
             result = Command.FAILURE;
         }
@@ -92,10 +90,7 @@
         }
         catch (Error e) {
             log.error(e.getMessage());
-
-            if (log.isDebugEnabled()) {
-                log.debug("Error details", e);
-            }
+            log.debug("Error details", e);
 
             result = Command.FAILURE;
         }

Modified: geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java?rev=573381&r1=573380&r2=573381&view=diff
==============================================================================
--- geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java
(original)
+++ geronimo/sandbox/gshell/trunk/gshell-core/src/main/java/org/apache/geronimo/gshell/ShellImpl.java
Thu Sep  6 14:14:22 2007
@@ -30,8 +30,6 @@
 import org.codehaus.plexus.PlexusContainer;
 import org.codehaus.plexus.component.annotations.Component;
 import org.codehaus.plexus.component.annotations.Requirement;
-import org.codehaus.plexus.personality.plexus.lifecycle.phase.Initializable;
-import org.codehaus.plexus.personality.plexus.lifecycle.phase.InitializationException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -42,7 +40,7 @@
  */
 @Component(role=Shell.class)
 public class ShellImpl
-    implements Shell, Initializable
+    implements Shell
 {
     private Logger log = LoggerFactory.getLogger(getClass());
 
@@ -78,15 +76,6 @@
 
     public IO getIO() {
         return io;
-    }
-
-    public void initialize() throws InitializationException {
-        // Dump some debug to crapski
-        if (log.isDebugEnabled()) {
-            log.debug("Container: {}", container);
-            log.debug("Layout manager: {}", layoutManager);
-            log.debug("Builder: {}", commandLineBuilder);
-        }
     }
 
     public Object execute(final String commandLine) throws Exception {

Modified: geronimo/sandbox/gshell/trunk/gshell-parser/src/main/grammar/CommandLineParser.jjt
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/gshell-parser/src/main/grammar/CommandLineParser.jjt?rev=573381&r1=573380&r2=573381&view=diff
==============================================================================
--- geronimo/sandbox/gshell/trunk/gshell-parser/src/main/grammar/CommandLineParser.jjt (original)
+++ geronimo/sandbox/gshell/trunk/gshell-parser/src/main/grammar/CommandLineParser.jjt Thu
Sep  6 14:14:22 2007
@@ -59,9 +59,7 @@
     public ASTCommandLine parse(final Reader reader) throws ParseException {
         assert reader != null;
 
-        if (log.isDebugEnabled()) {
-            log.debug("Parsing from reader: " + reader);
-        }
+        log.debug("Parsing from reader: {}", reader);
 
         this.ReInit(reader);
 



Mime
View raw message