geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r567832 - /geronimo/sandbox/server-gshell-launcher/modules/geronimo-commands/src/main/groovy/org/apache/geronimo/commands/ProcessLauncher.groovy
Date Mon, 20 Aug 2007 21:18:19 GMT
Author: jdillon
Date: Mon Aug 20 14:18:19 2007
New Revision: 567832

URL: http://svn.apache.org/viewvc?rev=567832&view=rev
Log:
No need for a list of errors here

Modified:
    geronimo/sandbox/server-gshell-launcher/modules/geronimo-commands/src/main/groovy/org/apache/geronimo/commands/ProcessLauncher.groovy

Modified: geronimo/sandbox/server-gshell-launcher/modules/geronimo-commands/src/main/groovy/org/apache/geronimo/commands/ProcessLauncher.groovy
URL: http://svn.apache.org/viewvc/geronimo/sandbox/server-gshell-launcher/modules/geronimo-commands/src/main/groovy/org/apache/geronimo/commands/ProcessLauncher.groovy?rev=567832&r1=567831&r2=567832&view=diff
==============================================================================
--- geronimo/sandbox/server-gshell-launcher/modules/geronimo-commands/src/main/groovy/org/apache/geronimo/commands/ProcessLauncher.groovy
(original)
+++ geronimo/sandbox/server-gshell-launcher/modules/geronimo-commands/src/main/groovy/org/apache/geronimo/commands/ProcessLauncher.groovy
Mon Aug 20 14:18:19 2007
@@ -51,17 +51,14 @@
         assert process
         assert name
         
-        //
-        // FIXME: Can probably just use a Throwable local here
-        //
-        def errors = []
+        Throwable error
         
         def runner = {
             try {
                 process()
             }
             catch (Exception e) {
-                errors << e
+                error = e
             }
         }
         
@@ -95,8 +92,8 @@
                     throw new Exception("Unable to verify if $name was started in the given
time ($timeout seconds)")
                 }
                 
-                if (errors) {
-                    throw new Exception("Failed to start: $name", errors[0])
+                if (error) {
+                    throw new Exception("Failed to start: $name", error)
                 }
                 
                 if (verifier()) {



Mime
View raw message