geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r566899 - in /geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc: JavaccMojo.groovy JavaccMojoSupport.groovy JjtreeMojo.groovy
Date Fri, 17 Aug 2007 01:09:16 GMT
Author: jdillon
Date: Thu Aug 16 18:09:16 2007
New Revision: 566899

URL: http://svn.apache.org/viewvc?view=rev&rev=566899
Log:
More docs and asserts

Modified:
    geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JavaccMojo.groovy
    geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JavaccMojoSupport.groovy
    geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JjtreeMojo.groovy

Modified: geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JavaccMojo.groovy
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JavaccMojo.groovy?view=diff&rev=566899&r1=566898&r2=566899
==============================================================================
--- geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JavaccMojo.groovy
(original)
+++ geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JavaccMojo.groovy
Thu Aug 16 18:09:16 2007
@@ -34,7 +34,7 @@
     extends JavaccMojoSupport
 {
     /**
-     * ???
+     * Where to output generated sources.
      *
      * @parameter expression="${project.build.directory}/generated-sources/javacc"
      * @required
@@ -42,7 +42,7 @@
     File outputDirectory
     
     /**
-     * ???
+     * A set of grammar files to process.
      *
      * @parameter
      * @required

Modified: geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JavaccMojoSupport.groovy
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JavaccMojoSupport.groovy?view=diff&rev=566899&r1=566898&r2=566899
==============================================================================
--- geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JavaccMojoSupport.groovy
(original)
+++ geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JavaccMojoSupport.groovy
Thu Aug 16 18:09:16 2007
@@ -50,6 +50,8 @@
     Map pluginArtifactMap
     
     protected Artifact getPluginArtifact(final String name) throws MojoExecutionException
{
+        assert name
+        
         def artifact = pluginArtifactMap.get(name)
         if (artifact == null) {
             fail("Unable to locate '${name}' in the list of plugin artifacts")
@@ -62,6 +64,8 @@
      * Install generated sources which have not been overridden.
      */
     protected void installGeneratedSources(File sourceDir) {
+        assert sourceDir
+        
         // Discover which classes were generated
         def builder = new JavaDocBuilder()
         builder.addSourceTree(sourceDir)

Modified: geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JjtreeMojo.groovy
URL: http://svn.apache.org/viewvc/geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JjtreeMojo.groovy?view=diff&rev=566899&r1=566898&r2=566899
==============================================================================
--- geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JjtreeMojo.groovy
(original)
+++ geronimo/sandbox/gshell/trunk/javacc-maven-plugin/src/main/groovy/org/apache/geronimo/gshell/maven/javacc/JjtreeMojo.groovy
Thu Aug 16 18:09:16 2007
@@ -34,7 +34,7 @@
     extends JavaccMojoSupport
 {
     /**
-     * ???
+     * Where to output generated sources.
      *
      * @parameter expression="${project.build.directory}/generated-sources/jjtree"
      * @required
@@ -42,12 +42,14 @@
     File outputDirectory
     
     /**
+     * The package for AST node classes.
+     *
      * @parameter
      */
     String nodePackage
     
     /**
-     * ???
+     * A set of grammar files to process.
      *
      * @parameter
      * @required
@@ -55,6 +57,8 @@
     FileSet grammars
 
     void execute() {
+        ant.mkdir(dir: outputDirectory)
+        
         def fsm = new FileSetManager(log, log.debugEnabled)
         def includes = fsm.getIncludedFiles(grammars)
         if (includes.length == 0) {



Mime
View raw message