geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dwo...@apache.org
Subject svn commit: r559927 - /geronimo/server/branches/2.0/applications/console/geronimo-console-core/src/main/java/org/apache/geronimo/console/core/security/PropertiesLoginModuleManager.java
Date Thu, 26 Jul 2007 18:26:40 GMT
Author: dwoods
Date: Thu Jul 26 11:26:39 2007
New Revision: 559927

URL: http://svn.apache.org/viewvc?view=rev&rev=559927
Log:
GERONIMO-3355 Unnecessary warning message when trying to create a new group in console realms.
 Patch from Viet Hung Nguyen.

Modified:
    geronimo/server/branches/2.0/applications/console/geronimo-console-core/src/main/java/org/apache/geronimo/console/core/security/PropertiesLoginModuleManager.java

Modified: geronimo/server/branches/2.0/applications/console/geronimo-console-core/src/main/java/org/apache/geronimo/console/core/security/PropertiesLoginModuleManager.java
URL: http://svn.apache.org/viewvc/geronimo/server/branches/2.0/applications/console/geronimo-console-core/src/main/java/org/apache/geronimo/console/core/security/PropertiesLoginModuleManager.java?view=diff&rev=559927&r1=559926&r2=559927
==============================================================================
--- geronimo/server/branches/2.0/applications/console/geronimo-console-core/src/main/java/org/apache/geronimo/console/core/security/PropertiesLoginModuleManager.java
(original)
+++ geronimo/server/branches/2.0/applications/console/geronimo-console-core/src/main/java/org/apache/geronimo/console/core/security/PropertiesLoginModuleManager.java
Thu Jul 26 11:26:39 2007
@@ -281,6 +281,10 @@
     public Set getGroupMembers(String groupPrincipal)
             throws GeronimoSecurityException {
         Set memberSet = new HashSet();
+        // return nothing when the groupPrincipal is null or empty
+        if (groupPrincipal == null || groupPrincipal.equals("")) {
+            return memberSet;
+        }
         refreshGroups();
         if (groups.getProperty(groupPrincipal) == null) {
             log.warn("getGroupMembers() Group="+groupPrincipal+" does not exist.");



Mime
View raw message