geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dillon <ja...@planet57.com>
Subject Re: svn commit: r529386 - in /geronimo/devtools/eclipse-plugin/trunk: plugins/org.apache.geronimo.runtime.common/pom.xml pom.xml
Date Mon, 16 Apr 2007 20:36:31 GMT
You really should use the dependencyManagement feature of maven 2 to  
manage versions, please don't use properties like this.

--jason


On Apr 16, 2007, at 1:30 PM, sppatel@apache.org wrote:

> Author: sppatel
> Date: Mon Apr 16 13:30:21 2007
> New Revision: 529386
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=529386
> Log:
> allow eclipse install location to be passed
>
> Modified:
>     geronimo/devtools/eclipse-plugin/trunk/plugins/ 
> org.apache.geronimo.runtime.common/pom.xml
>     geronimo/devtools/eclipse-plugin/trunk/pom.xml
>
> Modified: geronimo/devtools/eclipse-plugin/trunk/plugins/ 
> org.apache.geronimo.runtime.common/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/devtools/eclipse-plugin/ 
> trunk/plugins/org.apache.geronimo.runtime.common/pom.xml? 
> view=diff&rev=529386&r1=529385&r2=529386
> ====================================================================== 
> ========
> --- geronimo/devtools/eclipse-plugin/trunk/plugins/ 
> org.apache.geronimo.runtime.common/pom.xml (original)
> +++ geronimo/devtools/eclipse-plugin/trunk/plugins/ 
> org.apache.geronimo.runtime.common/pom.xml Mon Apr 16 13:30:21 2007
> @@ -29,6 +29,7 @@
>      <properties>
>          <xbeanVersion>2.0.0</xbeanVersion>
>          <commonsLoggingVersion>1.0.4</commonsLoggingVersion>
> +        <geronimo_spec_version>1.0</geronimo_spec_version>
>      </properties>
>      <build>
>          <resources>
>
> Modified: geronimo/devtools/eclipse-plugin/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/devtools/eclipse-plugin/ 
> trunk/pom.xml?view=diff&rev=529386&r1=529385&r2=529386
> ====================================================================== 
> ========
> --- geronimo/devtools/eclipse-plugin/trunk/pom.xml (original)
> +++ geronimo/devtools/eclipse-plugin/trunk/pom.xml Mon Apr 16  
> 13:30:21 2007
> @@ -73,7 +73,7 @@
>          </site>
>      </distributionManagement>
>      <properties>
> -<!-- Feature Versions -->
> +        <eclipseInstall>${settings.localRepository}/eclipse</ 
> eclipseInstall>
>          <org.apache.geronimo.feature_version>2.0.0</ 
> org.apache.geronimo.feature_version>
>          <org.apache.geronimo.v10.feature_version>2.0.0</ 
> org.apache.geronimo.v10.feature_version>
>          <org.apache.geronimo.v11.feature_version>2.0.0</ 
> org.apache.geronimo.v11.feature_version>
> @@ -81,8 +81,6 @@
>          <org.apache.geronimo.v20.feature_version>2.0.0</ 
> org.apache.geronimo.v20.feature_version>
>           
> <org.apache.geronimo.installableruntime.tomcat.feature_version>2.0.0</ 
> org.apache.geronimo.installableruntime.tomcat.feature_version>
>           
> <org.apache.geronimo.installableruntime.jetty.feature_version>2.0.0</o 
> rg.apache.geronimo.installableruntime.jetty.feature_version>
> -<!-- Ext. Jar Dependency Versions -->
> -        <geronimo_spec_version>1.0</geronimo_spec_version>
>      </properties>
>      <dependencyManagement>
>          <dependencies>
> @@ -120,7 +118,7 @@
>                              </goals>
>                              <configuration>
>                                  <markersDirectory>../../target/ 
> dependency-maven-plugin-markers</markersDirectory>
> -                                <outputDirectory>$ 
> {settings.localRepository}/eclipse</outputDirectory>
> +                                <outputDirectory>${eclipseInstall} 
> </outputDirectory>
>                                  <artifactItems>
>                                      <artifactItem>
>                                          <groupId>org.eclipse.gef</ 
> groupId>
> @@ -332,4 +330,4 @@
>          <module>features</module>
>          <module>assembly</module>
>      </modules>
> -</project>
> +</project>
> \ No newline at end of file
>
>


Mime
View raw message