geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ke...@apache.org
Subject svn commit: r520507 - /geronimo/server/trunk/modules/geronimo-client/src/main/java/org/apache/geronimo/client/AppClientContainer.java
Date Tue, 20 Mar 2007 18:17:23 GMT
Author: kevan
Date: Tue Mar 20 11:17:22 2007
New Revision: 520507

URL: http://svn.apache.org/viewvc?view=rev&rev=520507
Log:
Cleanup AppClientContainer. loginContext should be private. Also, removed commented code that's
no longer used

Modified:
    geronimo/server/trunk/modules/geronimo-client/src/main/java/org/apache/geronimo/client/AppClientContainer.java

Modified: geronimo/server/trunk/modules/geronimo-client/src/main/java/org/apache/geronimo/client/AppClientContainer.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-client/src/main/java/org/apache/geronimo/client/AppClientContainer.java?view=diff&rev=520507&r1=520506&r2=520507
==============================================================================
--- geronimo/server/trunk/modules/geronimo-client/src/main/java/org/apache/geronimo/client/AppClientContainer.java
(original)
+++ geronimo/server/trunk/modules/geronimo-client/src/main/java/org/apache/geronimo/client/AppClientContainer.java
Tue Mar 20 11:17:22 2007
@@ -52,7 +52,7 @@
 public final class AppClientContainer implements GBeanLifecycle {
     private static final Class[] MAIN_ARGS = {String[].class};
 
-    public static LoginContext loginContext;
+    private LoginContext loginContext;
 
     private final String mainClassName;
     private final AppClientPlugin jndiContext;
@@ -83,15 +83,7 @@
         }
         this.realmName = realmName;
         this.callbackHandlerClass = callbackHandlerClassName;
-//        if (callbackHandlerClassName != null) {
-//            try {
-//                this.callbackHandlerClass = classLoader.loadClass(callbackHandlerClassName);
-//            } catch (ClassNotFoundException e) {
-//                throw new AppClientInitializationException("Could not load callbackHandlerClass",
e);
-//            }
-//        } else {
-//            callbackHandlerClass = null;
-//        }
+
         if (defaultPrincipal != null) {
             defaultSubject = ConfigurationUtil.generateDefaultSubject(defaultPrincipal, classLoader);
         } else {
@@ -146,6 +138,7 @@
                     callbackHandler = (CallbackHandler) callbackHandlerClass.newInstance();
                 }
                 */
+                
                 loginContext = new LoginContext(realmName, callbackHandler);
                 try {
                     loginContext.login();



Mime
View raw message