geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r514288 - /geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/config/projects/Geronimo_CTS/Controller.groovy
Date Sun, 04 Mar 2007 00:20:55 GMT
Author: jdillon
Date: Sat Mar  3 16:20:54 2007
New Revision: 514288

URL: http://svn.apache.org/viewvc?view=rev&rev=514288
Log:
Only retry tests if there was 1 failure/error for now

Modified:
    geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/config/projects/Geronimo_CTS/Controller.groovy

Modified: geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/config/projects/Geronimo_CTS/Controller.groovy
URL: http://svn.apache.org/viewvc/geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/config/projects/Geronimo_CTS/Controller.groovy?view=diff&rev=514288&r1=514287&r2=514288
==============================================================================
--- geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/config/projects/Geronimo_CTS/Controller.groovy
(original)
+++ geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/config/projects/Geronimo_CTS/Controller.groovy
Sat Mar  3 16:20:54 2007
@@ -279,11 +279,6 @@
     }
     
     def runtestsRetryNonPassing = {
-        //
-        // HACK: Skip all retries for now... something is not right :-(
-        //
-        return
-        
         def summaryFile = new File('project/tck-testsuite/target/summary.properties')
         if (!summaryFile.exists()) {
             log.warn "Missing runtests summary file: $summaryFile"
@@ -296,6 +291,19 @@
         // Only attempt retries if there were non-passing tests
         if (summaryProps.passed == 'true') {
             log.info 'No failed tests detected; skipping retry'
+            return
+        }
+        
+        def failureCount = summaryProps['failureCount'].toInteger()
+        def errorCount = summaryProps['errorCount'].toInteger()
+        def total = failureCount + errroCount
+        
+        // For now only retry if one errors/failures was detected
+        def maxFailures = 1
+        
+        // Retry failed tests if there are only a few, else something big might be broke
+        if (total > maxFailures) {
+            log.info "Too many test errors/failures to retry: $total (max to retry: $maxFailures)"
             return
         }
         



Mime
View raw message