Return-Path: Delivered-To: apmail-geronimo-scm-archive@www.apache.org Received: (qmail 89252 invoked from network); 11 Feb 2007 11:54:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Feb 2007 11:54:15 -0000 Received: (qmail 465 invoked by uid 500); 11 Feb 2007 11:54:23 -0000 Delivered-To: apmail-geronimo-scm-archive@geronimo.apache.org Received: (qmail 323 invoked by uid 500); 11 Feb 2007 11:54:22 -0000 Mailing-List: contact scm-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list scm@geronimo.apache.org Received: (qmail 308 invoked by uid 99); 11 Feb 2007 11:54:22 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Feb 2007 03:54:22 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Feb 2007 03:54:14 -0800 Received: by eris.apache.org (Postfix, from userid 65534) id D22611A981F; Sun, 11 Feb 2007 03:53:54 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r505903 - /geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/template/Template.groovy Date: Sun, 11 Feb 2007 11:53:54 -0000 To: scm@geronimo.apache.org From: jdillon@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070211115354.D22611A981F@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jdillon Date: Sun Feb 11 03:53:54 2007 New Revision: 505903 URL: http://svn.apache.org/viewvc?view=rev&rev=505903 Log: Drop hacks/debug muck when rendering templates, we should *never* try to overwrite something Modified: geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/template/Template.groovy Modified: geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/template/Template.groovy URL: http://svn.apache.org/viewvc/geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/template/Template.groovy?view=diff&rev=505903&r1=505902&r2=505903 ============================================================================== --- geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/template/Template.groovy (original) +++ geronimo/sandbox/build-support/libraries/system/1/groovy/gbuild/system/template/Template.groovy Sun Feb 11 03:53:54 2007 @@ -59,28 +59,12 @@ void render(File file) { assert file - - // - // NOTE: Not using ant here to avoid evil log message - // - - file.parentFile.mkdirs() - assert file.parentFile.exists() : "Failed to create directory: ${file.parentFile}" - - /* - FIXME: Need to see why this is happening... + assert file.parentFile.exists() // Fail if we are overriting something assert !file.exists() : "Attempting to overwrite: $file" - */ - if (file.exists()) { - log.error "Overwriting: $file; backing up orig for debugging" - def ts = System.currentTimeMillis() - new AntBuilder().copy(file: file, tofile: "${file}.$ts") - } log.debug "Rendering to: $file" - def writer = file.newWriter() try {