geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Dillon <ja...@planet57.com>
Subject Re: svn commit: r485477 - /geronimo/server/trunk/pom.xml
Date Mon, 11 Dec 2006 08:24:55 GMT
Why are we giving the assembly id's the version suffix here?  I don't  
think we want to do this.  I think the ids, which are simply to  
select which assembly to use should be tomcat or jetty.  IMO, this is  
just that much more to type... for no real gain.

These are assembly ids, not artifact ids... they are supposed to be  
short and simple.  IMO this change only complicates them slightly by  
forcing people to remember which jetty version they are using.  And I  
hope that we are not going to start supporting a bunch of different  
jetty or tomcat versions per codeline... that would be a huge,  
massive, ugly mess.

I recommend reverting this change, and changing the id's of the  
tomcat6* bits to tomcat*.

--jason


On Dec 10, 2006, at 7:22 PM, prasad@apache.org wrote:

> Author: prasad
> Date: Sun Dec 10 19:22:47 2006
> New Revision: 485477
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=485477
> Log:
> * changing assemblyId to jetty6 to make it consistent with tomcat6
>
> Modified:
>     geronimo/server/trunk/pom.xml
>
> Modified: geronimo/server/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/pom.xml? 
> view=diff&rev=485477&r1=485476&r2=485477
> ====================================================================== 
> ========
> --- geronimo/server/trunk/pom.xml (original)
> +++ geronimo/server/trunk/pom.xml Sun Dec 10 19:22:47 2006
> @@ -1256,7 +1256,7 @@
>                      <configuration>
>                          <assemblies>
>                              <assembly>
> -                                <id>jetty</id>
> +                                <id>jetty6</id>
>                                   
> <groupId>org.apache.geronimo.assemblies</groupId>
>                                  <artifactId>geronimo-jetty6-jee5</ 
> artifactId>
>                                  <version>${version}</version>
> @@ -1265,7 +1265,7 @@
>                              </assembly>
>
>                              <assembly>
> -                                <id>jetty-minimal</id>
> +                                <id>jetty6-minimal</id>
>                                   
> <groupId>org.apache.geronimo.assemblies</groupId>
>                                  <artifactId>geronimo-jetty- 
> minimal</artifactId>
>                                  <version>${version}</version>
> @@ -1292,7 +1292,7 @@
>                              </assembly>
>                          </assemblies>
>
> -                        <defaultAssemblyId>jetty</defaultAssemblyId>
> +                        <defaultAssemblyId>jetty6</defaultAssemblyId>
>
>                          <optionSets>
>                              <optionSet>
>
>


Mime
View raw message