Return-Path: Delivered-To: apmail-geronimo-scm-archive@www.apache.org Received: (qmail 72946 invoked from network); 1 Aug 2006 18:13:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Aug 2006 18:13:20 -0000 Received: (qmail 63019 invoked by uid 500); 1 Aug 2006 18:13:15 -0000 Delivered-To: apmail-geronimo-scm-archive@geronimo.apache.org Received: (qmail 62939 invoked by uid 500); 1 Aug 2006 18:13:14 -0000 Mailing-List: contact scm-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list scm@geronimo.apache.org Received: (qmail 62884 invoked by uid 99); 1 Aug 2006 18:13:14 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2006 11:13:14 -0700 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [140.211.166.113] (HELO eris.apache.org) (140.211.166.113) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2006 11:13:13 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id EA87E1A981A; Tue, 1 Aug 2006 11:12:52 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r427666 - /geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java Date: Tue, 01 Aug 2006 18:12:52 -0000 To: scm@geronimo.apache.org From: ammulder@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20060801181252.EA87E1A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: ammulder Date: Tue Aug 1 11:12:52 2006 New Revision: 427666 URL: http://svn.apache.org/viewvc?rev=427666&view=rev Log: More work on GERONIMO-1869 -- use file size when copying, size of contents when unpacking. Modified: geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java Modified: geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java URL: http://svn.apache.org/viewvc/geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java?rev=427666&r1=427665&r2=427666&view=diff ============================================================================== --- geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java (original) +++ geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/repository/AbstractRepository.java Tue Aug 1 11:12:52 2006 @@ -190,7 +190,7 @@ if (!source.exists() || !source.canRead() || source.isDirectory()) { throw new IllegalArgumentException("Cannot read source file at " + source.getAbsolutePath()); } - int size = 0; + int size = (int) source.length(); boolean forceConfiguration = false; if(FileUtils.isZipFile(source)) { ZipFile zip = new ZipFile(source); @@ -205,7 +205,7 @@ } FileInputStream is = new FileInputStream(source); try { - copyToRepository(is, size, destination, monitor, forceConfiguration); + copyToRepository(is, (int)source.length(), size, destination, monitor, forceConfiguration); } finally { try { is.close(); @@ -216,10 +216,10 @@ } public void copyToRepository(InputStream source, int size, Artifact destination, FileWriteMonitor monitor) throws IOException { - copyToRepository(source, size, destination, monitor, false); + copyToRepository(source, size, size, destination, monitor, false); } - private void copyToRepository(InputStream source, int size, Artifact destination, FileWriteMonitor monitor, boolean isConfiguration) throws IOException { + private void copyToRepository(InputStream source, int packedSize, int unpackedSize, Artifact destination, FileWriteMonitor monitor, boolean isConfiguration) throws IOException { if(!destination.isResolved()) { throw new IllegalArgumentException("Artifact "+destination+" is not fully resolved"); } @@ -243,7 +243,8 @@ typeHandler = (ArtifactTypeHandler) typeHandlers.get(destination.getType()); } if (typeHandler == null) typeHandler = DEFAULT_TYPE_HANDLER; - typeHandler.install(source, size, destination, monitor, location); + typeHandler.install(source, typeHandler instanceof UnpackArtifactTypeHandler ? unpackedSize : packedSize, + destination, monitor, location); if (isConfiguration || destination.getType().equalsIgnoreCase("car")) { System.out.println("############################################################");