geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdil...@apache.org
Subject svn commit: r437623 - in /geronimo/server/trunk: applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/ applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/ac...
Date Mon, 28 Aug 2006 09:48:29 GMT
Author: jdillon
Date: Mon Aug 28 02:48:23 2006
New Revision: 437623

URL: http://svn.apache.org/viewvc?rev=437623&view=rev
Log:
Use logging instead of System.out and printStackTrace

Modified:
    geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/DBViewerPortlet.java
    geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/InternalDBHelper.java
    geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/RunSQLHelper.java
    geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/activemqCF/ActiveMQConnectorHelper.java
    geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/renderers/ViewDLQRenderer.java
    geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/renderers/ViewMessagesRenderer.java
    geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/wizard/ListScreenHandler.java
    geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/repository/RepositoryViewPortlet.java
    geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/securitymanager/realm/SecurityRealmPortlet.java
    geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/util/PortletManager.java
    geronimo/server/trunk/modules/geronimo-connector-builder/src/test/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilderTest.java
    geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/ConfigIDExtractor.java
    geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/DisconnectedDeploymentManager.java
    geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/DeploymentFactoryImpl.java
    geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/JMXDeploymentManager.java
    geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/RemoteDeploymentManager.java
    geronimo/server/trunk/modules/geronimo-hot-deploy/src/main/java/org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java
    geronimo/server/trunk/modules/geronimo-jetty/src/main/java/org/apache/geronimo/jetty/requestlog/JettyLogManagerImpl.java
    geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/jaas/server/JaasLoginService.java
    geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java
    geronimo/server/trunk/modules/geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/TomcatLogManagerImpl.java
    geronimo/server/trunk/modules/geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/listener/DispatchListener.java
    geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/WSDLVisitor.java

Modified: geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/DBViewerPortlet.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/DBViewerPortlet.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/DBViewerPortlet.java
(original)
+++ geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/DBViewerPortlet.java
Mon Aug 28 02:48:23 2006
@@ -29,9 +29,13 @@
 import javax.portlet.WindowState;
 
 import org.apache.geronimo.console.BasePortlet;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 public class DBViewerPortlet extends BasePortlet {
 
+    private final static Log log = LogFactory.getLog(DBViewerPortlet.class);
+
     private static final int RDBMS_DERBY = 1;
 
     private static final int RDBMS_MSSQL = 2;
@@ -52,8 +56,7 @@
 
     private static final String VIEWTBLCONTENTS_ACTION = "viewTableContents";
 
-    private static final String DERBY_HOME = System
-            .getProperty("derby.system.home");
+    private static final String DERBY_HOME = System.getProperty("derby.system.home");
 
     private static DBViewerHelper helper = new DBViewerHelper();
 
@@ -68,7 +71,7 @@
     private PortletRequestDispatcher viewTableContentsView;
 
     public void processAction(ActionRequest actionRequest,
-            ActionResponse actionResponse) throws PortletException, IOException {
+                              ActionResponse actionResponse) throws PortletException, IOException
{
         // getting parameters here because it fails on doView()
         String action = actionRequest.getParameter("action");
         String db = actionRequest.getParameter("db");
@@ -94,7 +97,7 @@
     }
 
     protected void doView(RenderRequest renderRequest,
-            RenderResponse renderResponse) throws IOException, PortletException {
+                          RenderResponse renderResponse) throws IOException, PortletException
{
         if (WindowState.MINIMIZED.equals(renderRequest.getWindowState())) {
             return;
         }
@@ -112,14 +115,14 @@
                         || VIEWTBLCONTENTS_ACTION.equals(action)) {
                     if (!helper.isDBValid(DERBY_HOME, db)) {
                         // DB not valid
-                        System.out.println("ERROR: db not valid: " + db);
+                        log.error("Database is not valid: " + db);
                         action = "";
                     }
                 }
                 if (VIEWTBLCONTENTS_ACTION.equals(action)) {
                     if (!helper.isTblValid(db, tbl)) {
                         // Table not valid
-                        System.out.println("ERROR: table not valid: " + tbl);
+                        log.error("Table is not valid: " + tbl);
                         action = "";
                     }
                 }
@@ -150,7 +153,7 @@
     }
 
     protected void doHelp(RenderRequest renderRequest,
-            RenderResponse renderResponse) throws PortletException, IOException {
+                          RenderResponse renderResponse) throws PortletException, IOException
{
         helpView.include(renderRequest, renderResponse);
     }
 

Modified: geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/InternalDBHelper.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/InternalDBHelper.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/InternalDBHelper.java
(original)
+++ geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/InternalDBHelper.java
Mon Aug 28 02:48:23 2006
@@ -17,6 +17,9 @@
 
 package org.apache.geronimo.console.internaldb;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 import java.sql.Connection;
 import java.sql.DatabaseMetaData;
 import java.sql.ResultSet;
@@ -26,6 +29,7 @@
 import java.util.Map;
 
 public class InternalDBHelper {
+    private final static Log log = LogFactory.getLog(InternalDBHelper.class);
 
     private static final int RDBMS_DERBY = 1;
 
@@ -37,8 +41,6 @@
 
     /**
      * Returns the database metadata as a map.
-     *
-     * @return
      */
     public Map getDBInfo() {
         derbyDBInfo.clear();
@@ -169,10 +171,6 @@
 
     /**
      * Get a specific column data as a string separated by ','.
-     *
-     * @param rs
-     * @param colName
-     * @return
      */
     private String getColumnData(ResultSet rs, String colName) {
         StringBuffer result = new StringBuffer();
@@ -220,7 +218,7 @@
      */
     private void printSQLError(SQLException e) {
         while (e != null) {
-            System.out.println(e.toString());
+            log.error(e.toString(), e);
             e = e.getNextException();
         }
     }

Modified: geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/RunSQLHelper.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/RunSQLHelper.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/RunSQLHelper.java
(original)
+++ geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/internaldb/RunSQLHelper.java
Mon Aug 28 02:48:23 2006
@@ -17,6 +17,9 @@
 
 package org.apache.geronimo.console.internaldb;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 import java.io.File;
 import java.sql.Connection;
 import java.sql.SQLException;
@@ -24,6 +27,8 @@
 
 public class RunSQLHelper {
 
+    private final static Log log = LogFactory.getLog(RunSQLHelper.class);
+
     public static final String SQL_SUCCESS_MSG = "SQL command/s successful";
 
     public static final String SQL_EMPTY_MSG = "SQL Command/s can't be empty";
@@ -147,8 +152,7 @@
             for (int i = 0; i < sqlCmds.length; i++) {
                 if (sqlCmds[i].trim().length() > 0) {
                     // debug printout (remove later)
-                    System.out.println("SQL" + i + ": <" + sqlCmds[i].trim()
-                            + ">");
+                    log.debug("SQL" + i + ": <" + sqlCmds[i].trim() + ">");
                     s.execute(sqlCmds[i]);
                 }
             }

Modified: geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/activemqCF/ActiveMQConnectorHelper.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/activemqCF/ActiveMQConnectorHelper.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/activemqCF/ActiveMQConnectorHelper.java
(original)
+++ geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/activemqCF/ActiveMQConnectorHelper.java
Mon Aug 28 02:48:23 2006
@@ -123,8 +123,7 @@
             osw.close();
             fos.close();
         } catch (Exception e) {
-            System.out.println("ERROR: Problem creating the plan file");
-            e.printStackTrace();
+            log.error("Problem creating the plan file", e);
         }
     }
 
@@ -165,17 +164,11 @@
                 buf.append(LINE_SEP);
                 cause = cause.getCause();
             }
-            System.out
-                    .println("ERROR: Problem deploying the ActiveMQ connector: "
-                            + buf.toString());
-            e.printStackTrace();
+            log.error("Problem deploying the ActiveMQ connector: " + buf);
         } catch (URISyntaxException e) {
-            System.out
-                    .println("ERROR: Newly installed app has invalid config ID");
-            e.printStackTrace();
+            log.error("Newly installed app has invalid config ID", e);
         } catch (Exception e) {
-            System.out.println("ERROR: Problem creating the datasource");
-            e.printStackTrace();
+            log.error("Problem creating the datasource", e);
         }
     }
 

Modified: geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/renderers/ViewDLQRenderer.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/renderers/ViewDLQRenderer.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/renderers/ViewDLQRenderer.java
(original)
+++ geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/renderers/ViewDLQRenderer.java
Mon Aug 28 02:48:23 2006
@@ -38,9 +38,12 @@
 import org.apache.geronimo.console.jmsmanager.AbstractJMSManager;
 import org.apache.geronimo.j2ee.j2eeobjectnames.NameFactory;
 import org.apache.geronimo.gbean.AbstractName;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
-public class ViewDLQRenderer extends AbstractJMSManager implements
-        PortletRenderer {
+public class ViewDLQRenderer extends AbstractJMSManager implements PortletRenderer {
+
+    private static final Log log = LogFactory.getLog(ViewDLQRenderer.class);
 
     private Destination dlq = null;
 
@@ -103,7 +106,7 @@
             connection.start();
 
         } catch (Exception e) {
-            e.printStackTrace();
+            log.error(e.getMessage(), e);
         }
     }
 
@@ -123,7 +126,7 @@
             connection.close();
 
         } catch (Exception e) {
-            e.printStackTrace();
+            log.error(e.getMessage(), e);
         }
 
         return list;

Modified: geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/renderers/ViewMessagesRenderer.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/renderers/ViewMessagesRenderer.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/renderers/ViewMessagesRenderer.java
(original)
+++ geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/renderers/ViewMessagesRenderer.java
Mon Aug 28 02:48:23 2006
@@ -43,10 +43,14 @@
 import org.apache.geronimo.console.jmsmanager.AbstractJMSManager;
 import org.apache.geronimo.j2ee.j2eeobjectnames.NameFactory;
 import org.apache.geronimo.gbean.AbstractName;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 public class ViewMessagesRenderer extends AbstractJMSManager implements
         PortletRenderer {
 
+    private static final Log log = LogFactory.getLog(ViewMessagesRenderer.class);
+
     private static final TopicListener topicListener = new TopicListener();
 
     public String render(RenderRequest request, RenderResponse response)
@@ -94,7 +98,7 @@
                     }
                     qConnection.stop();
                 } catch (Exception e) {
-                    e.printStackTrace();
+                    log.error(e.getMessage(), e);
                 } finally {
                     try {
                         if (qBrowser != null) {
@@ -124,7 +128,7 @@
                 ret = (List) kernel.invoke(tBrowserObjName, "getMessages");
             }
         } catch (Exception e) {
-            e.printStackTrace();
+            log.error(e.getMessage(), e);
         }
         return ret;
     }
@@ -152,7 +156,7 @@
                 }
                 messagesMap.put(dest, messages);
             } catch (JMSException e) {
-                e.printStackTrace();
+                log.error(e.getMessage(), e);
             }
         }
 

Modified: geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/wizard/ListScreenHandler.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/wizard/ListScreenHandler.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/wizard/ListScreenHandler.java
(original)
+++ geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/jmsmanager/wizard/ListScreenHandler.java
Mon Aug 28 02:48:23 2006
@@ -40,6 +40,8 @@
 import org.apache.geronimo.management.geronimo.JCAResource;
 import org.apache.geronimo.management.geronimo.ResourceAdapter;
 import org.apache.geronimo.management.geronimo.ResourceAdapterModule;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 /**
  * A handles for the front page that lists available resources.
@@ -47,6 +49,8 @@
  * @version $Rev$ $Date$
  */
 public class ListScreenHandler extends AbstractHandler {
+    private static final Log log = LogFactory.getLog(ListScreenHandler.class);
+
     public ListScreenHandler() {
         super(LIST_MODE, "/WEB-INF/view/jmswizard/list.jsp");
     }
@@ -158,7 +162,7 @@
                 }
             }
         } catch (MalformedObjectNameException e) {
-            e.printStackTrace();
+            log.error(e.getMessage(), e);
         }
 
         Collections.sort(resources);

Modified: geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/repository/RepositoryViewPortlet.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/repository/RepositoryViewPortlet.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/repository/RepositoryViewPortlet.java
(original)
+++ geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/repository/RepositoryViewPortlet.java
Mon Aug 28 02:48:23 2006
@@ -152,15 +152,14 @@
 
                 repo.copyToRepository(file, new Artifact(group, artifact, version, fileType),
new FileWriteMonitor() {
                     public void writeStarted(String fileDescription, int fileSize) {
-                        System.out.print("Copying into repository " + fileDescription + "...");
-                        System.out.flush();
+                        log.info("Copying into repository " + fileDescription + "...");
                     }
 
                     public void writeProgress(int bytes) {
                     }
 
                     public void writeComplete(int bytes) {
-                        System.out.println(" Finished.");
+                        log.info("Finished.");
                     }
                 });
             } catch (FileUploadException e) {

Modified: geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/securitymanager/realm/SecurityRealmPortlet.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/securitymanager/realm/SecurityRealmPortlet.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/securitymanager/realm/SecurityRealmPortlet.java
(original)
+++ geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/securitymanager/realm/SecurityRealmPortlet.java
Mon Aug 28 02:48:23 2006
@@ -675,7 +675,7 @@
             try {
                 Thread.sleep(100);
             } catch (InterruptedException e) {
-                e.printStackTrace();
+                log.error(e.getMessage(), e);
             }
         }
     }

Modified: geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/util/PortletManager.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/util/PortletManager.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/util/PortletManager.java
(original)
+++ geronimo/server/trunk/applications/console/geronimo-console-standard/src/main/java/org/apache/geronimo/console/util/PortletManager.java
Mon Aug 28 02:48:23 2006
@@ -95,7 +95,7 @@
         try {
             return factory.getDeploymentManager("deployer:geronimo:inVM", null, null);
         } catch (DeploymentManagerCreationException e) {
-            e.printStackTrace();
+            log.error(e.getMessage(), e);
             return null;
         }
     }

Modified: geronimo/server/trunk/modules/geronimo-connector-builder/src/test/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilderTest.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-connector-builder/src/test/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilderTest.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-connector-builder/src/test/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilderTest.java
(original)
+++ geronimo/server/trunk/modules/geronimo-connector-builder/src/test/java/org/apache/geronimo/connector/deployment/ConnectorModuleBuilderTest.java
Mon Aug 28 02:48:23 2006
@@ -427,7 +427,7 @@
             for (Iterator iterator = gb.iterator(); iterator.hasNext();) {
                 AbstractName name = (AbstractName) iterator.next();
                 if (State.RUNNING_INDEX != kernel.getGBeanState(name)) {
-                    System.out.println("Not running: " + name);
+                    log.debug("Not running: " + name);
                 }
             }
 

Modified: geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/ConfigIDExtractor.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/ConfigIDExtractor.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/ConfigIDExtractor.java
(original)
+++ geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/ConfigIDExtractor.java
Mon Aug 28 02:48:23 2006
@@ -37,6 +37,8 @@
 import org.apache.geronimo.kernel.repository.Artifact;
 import org.apache.geronimo.kernel.repository.Version;
 import org.apache.geronimo.kernel.util.XmlUtil;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.xml.sax.Attributes;
 import org.xml.sax.InputSource;
 import org.xml.sax.SAXException;
@@ -49,6 +51,8 @@
  */
 public class ConfigIDExtractor {
 
+    private static final Log log = LogFactory.getLog(ConfigIDExtractor.class);
+
     /**
      * Attempt to calculate the Geronimo ModuleID for a J2EE application
      * module.
@@ -216,7 +220,7 @@
             ConfigIdHandler handler = new ConfigIdHandler();
             parser.parse(new InputSource(plan), handler);
             if(handler.formatIs10) {
-                System.out.println("WARNING: Geronimo deployment plan uses Geronimo 1.0 syntax.
 Please update to Geronimo 1.1 syntax when possible.");
+                log.warn("Geronimo deployment plan uses Geronimo 1.0 syntax.  Please update
to Geronimo 1.1 syntax when possible.");
             }
             return handler.configId;
         } catch (ParserConfigurationException e) {

Modified: geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/DisconnectedDeploymentManager.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/DisconnectedDeploymentManager.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/DisconnectedDeploymentManager.java
(original)
+++ geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/DisconnectedDeploymentManager.java
Mon Aug 28 02:48:23 2006
@@ -14,6 +14,7 @@
  *  See the License for the specific language governing permissions and
  *  limitations under the License.
  */
+
 package org.apache.geronimo.deployment.plugin;
 
 import javax.enterprise.deploy.spi.DeploymentManager;
@@ -25,18 +26,15 @@
 import javax.enterprise.deploy.spi.exceptions.DConfigBeanVersionUnsupportedException;
 import javax.enterprise.deploy.spi.exceptions.TargetException;
 import javax.enterprise.deploy.model.DeployableObject;
-import javax.enterprise.deploy.model.DDBeanRoot;
-import javax.enterprise.deploy.model.DDBean;
-import javax.enterprise.deploy.model.exceptions.DDBeanCreateException;
 import javax.enterprise.deploy.shared.DConfigBeanVersionType;
 import javax.enterprise.deploy.shared.ModuleType;
 import java.util.Locale;
-import java.util.Enumeration;
 import java.io.File;
 import java.io.InputStream;
-import java.io.FileNotFoundException;
 import org.apache.geronimo.connector.deployment.RARConfigurer;
 import org.apache.geronimo.web.deployment.WARConfigurer;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 /**
  * Implementation of a disconnected JSR88 DeploymentManager.
@@ -45,6 +43,8 @@
  * @version $Rev$ $Date$
  */
 public class DisconnectedDeploymentManager implements DeploymentManager {
+    private static final Log log = LogFactory.getLog(DisconnectedDeploymentManager.class);
+
     public DeploymentConfiguration createConfiguration(DeployableObject dObj) throws InvalidModuleException
{
         if(dObj.getType().equals(ModuleType.CAR)) {
             //todo: need a client configurer
@@ -55,8 +55,7 @@
                 Class cls = Class.forName("org.openejb.deployment.EJBConfigurer");
                 return (DeploymentConfiguration)cls.getMethod("createConfiguration", new
Class[]{DeployableObject.class}).invoke(cls.newInstance(), new Object[]{dObj});
             } catch (Exception e) {
-                System.err.println("Unable to invoke EJB deployer");
-                e.printStackTrace();
+                log.error("Unable to invoke EJB deployer", e);
             }
         } else if(dObj.getType().equals(ModuleType.RAR)) {
             return new RARConfigurer().createConfiguration(dObj);

Modified: geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/DeploymentFactoryImpl.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/DeploymentFactoryImpl.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/DeploymentFactoryImpl.java
(original)
+++ geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/factories/DeploymentFactoryImpl.java
Mon Aug 28 02:48:23 2006
@@ -21,6 +21,8 @@
 import org.apache.geronimo.deployment.plugin.jmx.LocalDeploymentManager;
 import org.apache.geronimo.deployment.plugin.jmx.RemoteDeploymentManager;
 import org.apache.geronimo.kernel.KernelRegistry;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 import javax.enterprise.deploy.shared.factories.DeploymentFactoryManager;
 import javax.enterprise.deploy.spi.DeploymentManager;
@@ -43,6 +45,8 @@
  * @version $Rev$ $Date$
  */
 public class DeploymentFactoryImpl implements DeploymentFactory {
+    private static final Log log = LogFactory.getLog(DeploymentFactoryImpl.class);
+
     public static final String URI_PREFIX = "deployer:geronimo:";
     private static final int DEFAULT_PORT = 1099;
 
@@ -140,11 +144,11 @@
             }
         } catch (RuntimeException e) {
             // some DeploymentManagerFactories suppress unchecked exceptions - log and rethrow
-            e.printStackTrace();
+            log.error(e.getMessage(), e);
             throw e;
         } catch (Error e) {
             // some DeploymentManagerFactories suppress unchecked exceptions - log and rethrow
-            e.printStackTrace();
+            log.error(e.getMessage(), e);
             throw e;
         }
     }

Modified: geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/JMXDeploymentManager.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/JMXDeploymentManager.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/JMXDeploymentManager.java
(original)
+++ geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/JMXDeploymentManager.java
Mon Aug 28 02:48:23 2006
@@ -50,12 +50,16 @@
 import org.apache.geronimo.kernel.config.NoSuchStoreException;
 import org.apache.geronimo.kernel.management.State;
 import org.apache.geronimo.web.deployment.WARConfigurer;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 
 /**
  * @version $Rev$ $Date$
  */
 public abstract class JMXDeploymentManager implements DeploymentManager {
+    private static final Log log = LogFactory.getLog(JMXDeploymentManager.class);
+
     protected Kernel kernel;
     private ConfigurationManager configurationManager;
     private CommandContext commandContext;
@@ -284,8 +288,7 @@
                 Class cls = Class.forName("org.openejb.deployment.EJBConfigurer");
                 return (DeploymentConfiguration)cls.getMethod("createConfiguration", new
Class[]{DeployableObject.class}).invoke(cls.newInstance(), new Object[]{dObj});
             } catch (Exception e) {
-                System.err.println("Unable to invoke EJB deployer");
-                e.printStackTrace();
+                log.error("Unable to invoke EJB deployer", e);
             }
         } else if(dObj.getType().equals(ModuleType.RAR)) {
             return new RARConfigurer().createConfiguration(dObj);
@@ -315,7 +318,7 @@
         commandContext.setLogErrors(shouldLog);
         commandContext.setVerbose(verboseStatus);
     }
-    
+
     public void setInPlace(boolean inPlace) {
         commandContext.setInPlace(inPlace);
     }

Modified: geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/RemoteDeploymentManager.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/RemoteDeploymentManager.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/RemoteDeploymentManager.java
(original)
+++ geronimo/server/trunk/modules/geronimo-deploy-jsr88/src/main/java/org/apache/geronimo/deployment/plugin/jmx/RemoteDeploymentManager.java
Mon Aug 28 02:48:23 2006
@@ -53,6 +53,8 @@
 import org.apache.geronimo.system.plugin.PluginInstaller;
 import org.apache.geronimo.system.plugin.PluginRepositoryList;
 import org.apache.geronimo.kernel.repository.Artifact;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 /**
  * Connects to a Kernel in a remote VM (may or many not be on the same machine).
@@ -60,6 +62,8 @@
  * @version $Rev$ $Date$
  */
 public class RemoteDeploymentManager extends JMXDeploymentManager implements GeronimoDeploymentManager
{
+    private static final Log log = LogFactory.getLog(RemoteDeploymentManager.class);
+
     private JMXConnector jmxConnector;
     private boolean isSameMachine;
 
@@ -94,7 +98,7 @@
                 }
             }
         } catch (Exception e) {
-            System.err.println("Unable to look up host name '"+hostname+"'; assuming it is
a different machine, but this may not get very far.  ("+e.getMessage()+")");
+            log.error("Unable to look up host name '"+hostname+"'; assuming it is a different
machine, but this may not get very far.", e);
         }
     }
 
@@ -196,7 +200,7 @@
             };
             progress.addProgressListener(new ProgressListener() {
                 public void handleProgressEvent(ProgressEvent event) {
-                    System.out.println(event.getDeploymentStatus().getMessage());
+                    log.info(event.getDeploymentStatus().getMessage());
                 }
             });
             RemoteDeployUtil.uploadFilesToServer(args, progress);

Modified: geronimo/server/trunk/modules/geronimo-hot-deploy/src/main/java/org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-hot-deploy/src/main/java/org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-hot-deploy/src/main/java/org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java
(original)
+++ geronimo/server/trunk/modules/geronimo-hot-deploy/src/main/java/org/apache/geronimo/deployment/hot/DirectoryHotDeployer.java
Mon Aug 28 02:48:23 2006
@@ -53,7 +53,8 @@
  * @version $Rev$ $Date$
  */
 public class DirectoryHotDeployer implements HotDeployer, DeploymentWatcher, GBeanLifecycle
{ //todo: write unit tests
-    private static final Log log = LogFactory.getLog("org.apache.geronimo.deployment.hot.Hot
Deployer");
+    private static final Log log = LogFactory.getLog(DirectoryHotDeployer.class);
+
     // Try to make this stand out as the user is likely to get a ton of errors if this comes
up
     private static final String BAD_LAYOUT_MESSAGE = "CANNOT DEPLOY: It looks like you unpacked
an application or module " +
             "directly into the hot deployment directory.  THIS DOES NOT WORK.  You need to
unpack into a " +
@@ -262,11 +263,11 @@
                 modules = po.getResultTargetModuleIDs();
                 for (int i = 0; i < modules.length; i++) {
                     TargetModuleID result = modules[i];
-                    System.out.print(DeployUtils.reformat("Deployed " + result.getModuleID()
+ (targets.length > 1 ? " to " + result.getTarget().getName() : "") + (result.getWebURL()
== null ? "" : " @ " + result.getWebURL()), 4, 72));
+                    log.info(DeployUtils.reformat("Deployed " + result.getModuleID() + (targets.length
> 1 ? " to " + result.getTarget().getName() : "") + (result.getWebURL() == null ? "" :
" @ " + result.getWebURL()), 4, 72));
                     if (result.getChildTargetModuleID() != null) {
                         for (int j = 0; j < result.getChildTargetModuleID().length; j++)
{
                             TargetModuleID child = result.getChildTargetModuleID()[j];
-                            System.out.print(DeployUtils.reformat("  `-> " + child.getModuleID()
+ (child.getWebURL() == null ? "" : " @ " + child.getWebURL()), 4, 72));
+                            log.info(DeployUtils.reformat("  `-> " + child.getModuleID()
+ (child.getWebURL() == null ? "" : " @ " + child.getWebURL()), 4, 72));
                         }
                     }
                 }
@@ -317,7 +318,7 @@
                 TargetModuleID[] modules = po.getResultTargetModuleIDs();
                 for (int i = 0; i < modules.length; i++) {
                     TargetModuleID result = modules[i];
-                    System.out.print(DeployUtils.reformat("Undeployed " + result.getModuleID()
+ (targets.length > 1 ? " to " + result.getTarget().getName() : ""), 4, 72));
+                    log.info(DeployUtils.reformat("Undeployed " + result.getModuleID() +
(targets.length > 1 ? " to " + result.getTarget().getName() : ""), 4, 72));
                 }
             } else {
                 log.error("Unable to undeploy " + file.getAbsolutePath() + "(" + configId
+ ")" + po.getDeploymentStatus().getMessage());
@@ -354,11 +355,11 @@
                 TargetModuleID[] modules = po.getResultTargetModuleIDs();
                 for (int i = 0; i < modules.length; i++) {
                     TargetModuleID result = modules[i];
-                    System.out.print(DeployUtils.reformat("Redeployed " + result.getModuleID()
+ (targets.length > 1 ? " to " + result.getTarget().getName() : "") + (result.getWebURL()
== null ? "" : " @ " + result.getWebURL()), 4, 72));
+                    log.info(DeployUtils.reformat("Redeployed " + result.getModuleID() +
(targets.length > 1 ? " to " + result.getTarget().getName() : "") + (result.getWebURL()
== null ? "" : " @ " + result.getWebURL()), 4, 72));
                     if (result.getChildTargetModuleID() != null) {
                         for (int j = 0; j < result.getChildTargetModuleID().length; j++)
{
                             TargetModuleID child = result.getChildTargetModuleID()[j];
-                            System.out.print(DeployUtils.reformat("  `-> " + child.getModuleID()
+ (child.getWebURL() == null ? "" : " @ " + child.getWebURL()), 4, 72));
+                            log.info(DeployUtils.reformat("  `-> " + child.getModuleID()
+ (child.getWebURL() == null ? "" : " @ " + child.getWebURL()), 4, 72));
                         }
                     }
                 }
@@ -379,7 +380,7 @@
             try {
                 Thread.sleep(100);
             } catch (InterruptedException e) {
-                e.printStackTrace();
+                log.error(e.getMessage(), e);
             }
         }
     }

Modified: geronimo/server/trunk/modules/geronimo-jetty/src/main/java/org/apache/geronimo/jetty/requestlog/JettyLogManagerImpl.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-jetty/src/main/java/org/apache/geronimo/jetty/requestlog/JettyLogManagerImpl.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-jetty/src/main/java/org/apache/geronimo/jetty/requestlog/JettyLogManagerImpl.java
(original)
+++ geronimo/server/trunk/modules/geronimo-jetty/src/main/java/org/apache/geronimo/jetty/requestlog/JettyLogManagerImpl.java
Mon Aug 28 02:48:23 2006
@@ -143,9 +143,8 @@
                 logFiles = parent.listFiles(new PatternFilenameFilter(fileNamePattern));
             }
         } catch (Exception e) {
-            log.error("Exception attempting to locate Jetty log files: "+e);
+            log.error("Exception attempting to locate Jetty log files", e);
             logFiles = new File[0];
-            e.printStackTrace();
         }
         return logFiles;
     }

Modified: geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/jaas/server/JaasLoginService.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/jaas/server/JaasLoginService.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/jaas/server/JaasLoginService.java
(original)
+++ geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/jaas/server/JaasLoginService.java
Mon Aug 28 02:48:23 2006
@@ -202,8 +202,7 @@
         try {
             module.initialize(session.getSubject(), session.getHandler(), new HashMap(),
session.getOptions(loginModuleIndex));
         } catch (Exception e) {
-            System.err.println("Failed to initialize module");
-            e.printStackTrace();
+            log.error("Failed to initialize module", e);
         }
         try {
             module.login();

Modified: geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java
(original)
+++ geronimo/server/trunk/modules/geronimo-security/src/main/java/org/apache/geronimo/security/remoting/jmx/RequestChannelInterceptorInvoker.java
Mon Aug 28 02:48:23 2006
@@ -27,12 +27,16 @@
 import org.apache.geronimo.interceptor.Interceptor;
 import org.apache.geronimo.interceptor.Invocation;
 import org.apache.geronimo.interceptor.InvocationResult;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 /**
  * @version $Rev$ $Date$
  */
 public class RequestChannelInterceptorInvoker implements RequestListener {
 
+    private static final Log log = LogFactory.getLog(RequestChannelInterceptorInvoker.class);
+
     private ClassLoader classloader;
     private Interceptor next;
 
@@ -69,7 +73,7 @@
                 marshalledInvocation = (Invocation) RequestChannelInterceptor.deserialize(request,classloader);
             } catch (Throwable e) {
                 // Could not deserialize the invocation...
-                e.printStackTrace();
+                log.error("Could not deserialize the invocation", e);
                 return RequestChannelInterceptor.serialize(new ThrowableWrapper(e));
             }
 
@@ -90,7 +94,7 @@
     }
 
     public void onRquestError(IOException error) {
-        System.out.println("Request Error:"+error);
+        log.error("Request Error", error);
     }
 
 }

Modified: geronimo/server/trunk/modules/geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/TomcatLogManagerImpl.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/TomcatLogManagerImpl.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/TomcatLogManagerImpl.java
(original)
+++ geronimo/server/trunk/modules/geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/TomcatLogManagerImpl.java
Mon Aug 28 02:48:23 2006
@@ -145,9 +145,8 @@
                 logFiles = parent.listFiles(new PatternFilenameFilter(fileNamePattern));
             }
         } catch (Exception e) {
-            log.error("Exception attempting to locate Tomcat log files: "+e);
+            log.error("Exception attempting to locate Tomcat log files", e);
             logFiles = new File[0];
-            e.printStackTrace();
         }
         return logFiles;
     }

Modified: geronimo/server/trunk/modules/geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/listener/DispatchListener.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/listener/DispatchListener.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/listener/DispatchListener.java
(original)
+++ geronimo/server/trunk/modules/geronimo-tomcat/src/main/java/org/apache/geronimo/tomcat/listener/DispatchListener.java
Mon Aug 28 02:48:23 2006
@@ -32,9 +32,13 @@
 import org.apache.tomcat.util.buf.MessageBytes;
 import org.apache.tomcat.util.http.mapper.Mapper;
 import org.apache.tomcat.util.http.mapper.MappingData;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 public class DispatchListener implements InstanceListener {
 
+    private static final Log log = LogFactory.getLog(DispatchListener.class);
+
     private static ThreadLocal currentContext = new ThreadLocal() {
         protected Object initialValue() {
             return new Stack();
@@ -62,7 +66,7 @@
     }
 
     private void beforeDispatch(GeronimoStandardContext webContext,
-            ServletRequest request, ServletResponse response) {
+                                ServletRequest request, ServletResponse response) {
 
         BeforeAfter beforeAfter = webContext.getBeforeAfter();
         if (beforeAfter != null) {
@@ -78,7 +82,7 @@
     }
 
     private void afterDispatch(GeronimoStandardContext webContext,
-            ServletRequest request, ServletResponse response) {
+                               ServletRequest request, ServletResponse response) {
         BeforeAfter beforeAfter = webContext.getBeforeAfter();
         if (beforeAfter != null) {
             Stack stack = (Stack) currentContext.get();
@@ -92,23 +96,22 @@
     }
 
     private String getWrapperName(ServletRequest request,
-            GeronimoStandardContext webContext) {
-        
+                                  GeronimoStandardContext webContext) {
+
         MappingData mappingData = new MappingData();
         Mapper mapper = webContext.getMapper();
         MessageBytes mb = MessageBytes.newInstance();
-        
+
         String dispatchPath =
             (String) request.getAttribute(Globals.DISPATCHER_REQUEST_PATH_ATTR);
         mb.setString(webContext.getName() + dispatchPath);
-        
+
         try {
             mapper.map(mb, mappingData);
             StandardWrapper wrapper = (StandardWrapper) mappingData.wrapper;
             return wrapper.getName();
         } catch (Exception e) {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
+            log.error(e.getMessage(), e);
         }
 
         return null;

Modified: geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/WSDLVisitor.java
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/WSDLVisitor.java?rev=437623&r1=437622&r2=437623&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/WSDLVisitor.java
(original)
+++ geronimo/server/trunk/modules/geronimo-webservices/src/main/java/org/apache/geronimo/webservices/WSDLVisitor.java
Mon Aug 28 02:48:23 2006
@@ -16,6 +16,9 @@
  */
 package org.apache.geronimo.webservices;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 import java.util.Collection;
 import java.util.Iterator;
 import java.util.List;
@@ -26,6 +29,8 @@
 
 public class WSDLVisitor {
 
+    private static final Log log = LogFactory.getLog(WSDLVisitor.class);
+
     protected final Definition definition;
 
     public WSDLVisitor(Definition definition) {
@@ -103,7 +108,7 @@
                 }
             }
         } catch(Exception e){
-            e.printStackTrace();
+            log.error(e.getMessage(), e);
         } finally {
             end();
         }



Mime
View raw message