geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From d...@apache.org
Subject svn commit: r399897 - /geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
Date Fri, 05 May 2006 00:32:13 GMT
Author: dain
Date: Thu May  4 17:32:11 2006
New Revision: 399897

URL: http://svn.apache.org/viewcvs?rev=399897&view=rev
Log:
These exceptions cause the tck to fail to start.

Modified:
    geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java

Modified: geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
URL: http://svn.apache.org/viewcvs/geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java?rev=399897&r1=399896&r2=399897&view=diff
==============================================================================
--- geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
(original)
+++ geronimo/branches/1.1/modules/system/src/java/org/apache/geronimo/system/configuration/LocalAttributeManager.java
Thu May  4 17:32:11 2006
@@ -408,7 +408,7 @@
     public void startConfiguration(Artifact configurationName) {
         ConfigurationOverride configuration = serverOverride.getConfiguration(configurationName,
false);
         if(configuration == null) {
-            throw new IllegalArgumentException("No such configuration "+configurationName);
+            return;
         }
         configuration.setLoad(true);
         attributeChanged();
@@ -428,11 +428,10 @@
     public synchronized void removeConfiguration(Artifact configName) {
         ConfigurationOverride configuration = serverOverride.getConfiguration(configName);
         if (configuration == null) {
-            throw new IllegalArgumentException("Trying to remove unknown configuration: "
+ configName);
-        } else {
-            serverOverride.removeConfiguration(configName);
-            attributeChanged();
+            return;
         }
+        serverOverride.removeConfiguration(configName);
+        attributeChanged();
     }
 
     public Artifact[] getListedConfigurations(Artifact query) {
@@ -442,11 +441,10 @@
     public void stopConfiguration(Artifact configName) {
         ConfigurationOverride configuration = serverOverride.getConfiguration(configName);
         if (configuration == null) {
-            throw new IllegalArgumentException("Trying to stop unknown configuration: " +
configName);
-        } else {
-            configuration.setLoad(false);
-            attributeChanged();
+            return;
         }
+        configuration.setLoad(false);
+        attributeChanged();
     }
 
     public void migrateConfiguration(Artifact oldName, Artifact newName, Configuration configuration)
{



Mime
View raw message