geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ammul...@apache.org
Subject svn commit: r357772 - /geronimo/branches/1.0/modules/jetty-builder/src/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilder.java
Date Mon, 19 Dec 2005 20:10:26 GMT
Author: ammulder
Date: Mon Dec 19 12:10:21 2005
New Revision: 357772

URL: http://svn.apache.org/viewcvs?rev=357772&view=rev
Log:
Don't check whether the web.xml has a <security> element -- it might
  be in the EAR plan instead.  If it's not in either place, this will
  be caught by the subsequent check.

Modified:
    geronimo/branches/1.0/modules/jetty-builder/src/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilder.java

Modified: geronimo/branches/1.0/modules/jetty-builder/src/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilder.java
URL: http://svn.apache.org/viewcvs/geronimo/branches/1.0/modules/jetty-builder/src/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilder.java?rev=357772&r1=357771&r2=357772&view=diff
==============================================================================
--- geronimo/branches/1.0/modules/jetty-builder/src/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilder.java
(original)
+++ geronimo/branches/1.0/modules/jetty-builder/src/java/org/apache/geronimo/jetty/deployment/JettyModuleBuilder.java
Mon Dec 19 12:10:21 2005
@@ -422,8 +422,8 @@
 
         ENCConfigBuilder.registerMessageDestinations(earContext.getRefContext(), module.getName(),
messageDestinations, gerMessageDestinations);
         if((webApp.getSecurityConstraintArray().length > 0 || webApp.getSecurityRoleArray().length
> 0) &&
-                (!gerWebApp.isSetSecurityRealmName() || !gerWebApp.isSetSecurity())) {
-            throw new DeploymentException("web.xml includes security elements but Geronimo
deployment plan is not provided or does not contain <security-realm-name> and <security>
elements necessary to configured security accordingly.");
+                !gerWebApp.isSetSecurityRealmName()) {
+            throw new DeploymentException("web.xml includes security elements but Geronimo
deployment plan is not provided or does not contain <security-realm-name> element necessary
to configure security accordingly.");
         }
         if (gerWebApp.isSetSecurity()) {
             if (!gerWebApp.isSetSecurityRealmName()) {
@@ -806,7 +806,7 @@
 
             if (jettyWebApp.isSetSecurityRealmName()) {
                 if (earContext.getSecurityConfiguration() == null) {
-                     throw new DeploymentException("You have specified a login security realm
for the webapp " + webModuleName + " but no security configuration is supplied in the application
plan");
+                     throw new DeploymentException("You have specified a <security-realm-name>
for the webapp " + webModuleName + " but no <security> configuration (role mapping)
is supplied in the Geronimo plan for the web application (or the Geronimo plan for the EAR
if the web app is in an EAR)");
                 }
                 String securityRealmName = jettyWebApp.getSecurityRealmName().trim();
                 webModuleData.setAttribute("securityRealmName", securityRealmName);



Mime
View raw message