geronimo-scm mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From djen...@apache.org
Subject cvs commit: incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean GBeanInfoFactory.java
Date Fri, 16 Jan 2004 02:17:39 GMT
djencks     2004/01/15 18:17:39

  Modified:    modules/kernel/src/java/org/apache/geronimo/gbean
                        GBeanInfoFactory.java
  Log:
  Use immutable GBeanInfo as parent source so it can be static, not mutable  GBeanInfoFactory.
Copy constructor info also
  
  Revision  Changes    Path
  1.3       +9 -7      incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/GBeanInfoFactory.java
  
  Index: GBeanInfoFactory.java
  ===================================================================
  RCS file: /home/cvs/incubator-geronimo/modules/kernel/src/java/org/apache/geronimo/gbean/GBeanInfoFactory.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- GBeanInfoFactory.java	14 Jan 2004 20:39:56 -0000	1.2
  +++ GBeanInfoFactory.java	16 Jan 2004 02:17:39 -0000	1.3
  @@ -82,20 +82,22 @@
           this.className = className;
       }
   
  -    public GBeanInfoFactory(String name, String description, String className, GBeanInfoFactory
source) {
  +    public GBeanInfoFactory(String name, String description, String className, GBeanInfo
source) {
           this(name, description, className);
           assert source != null;
  -        attributes.addAll(source.attributes);
  -        operations.addAll(source.operations);
  -        endpoints.addAll(source.endpoints);
  -        notifications.addAll(source.notifications);
  +        attributes.addAll(source.getAttributeSet());
  +        operations.addAll(source.getOperationsSet());
  +        endpoints.addAll(source.getEndpointsSet());
  +        notifications.addAll(source.getNotificationsSet());
  +        //in case subclass constructor has same parameters as superclass.
  +        constructor = source.getConstructor();
       }
   
       public GBeanInfoFactory(String className) {
           this(className, null, className);
       }
   
  -    public GBeanInfoFactory(String className, GBeanInfoFactory source) {
  +    public GBeanInfoFactory(String className, GBeanInfo source) {
           this(className, null, className, source);
       }
   
  
  
  

Mime
View raw message