From dev-return-100811-archive-asf-public=cust-asf.ponee.io@geronimo.apache.org Thu Sep 24 05:49:36 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id EC3AB18063D for ; Thu, 24 Sep 2020 07:49:35 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 26EEB438CA for ; Thu, 24 Sep 2020 05:49:35 +0000 (UTC) Received: (qmail 23015 invoked by uid 500); 24 Sep 2020 05:49:34 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 22997 invoked by uid 99); 24 Sep 2020 05:49:33 -0000 Received: from spamproc1-he-fi.apache.org (HELO spamproc1-he-fi.apache.org) (95.217.134.168) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Sep 2020 05:49:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-fi.apache.org (ASF Mail Server at spamproc1-he-fi.apache.org) with ESMTP id DC19DC0104 for ; Thu, 24 Sep 2020 05:49:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-fi.apache.org X-Spam-Flag: NO X-Spam-Score: -0.001 X-Spam-Level: X-Spam-Status: No, score=-0.001 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamproc1-he-fi.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([116.203.227.195]) by localhost (spamproc1-he-fi.apache.org [95.217.134.168]) (amavisd-new, port 10024) with ESMTP id c8ZSbZczP5_J for ; Thu, 24 Sep 2020 05:49:31 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.219.67; helo=mail-qv1-f67.google.com; envelope-from=rmannibucau@gmail.com; receiver= Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 30778BC24B for ; Thu, 24 Sep 2020 05:49:31 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id f11so1352785qvw.3 for ; Wed, 23 Sep 2020 22:49:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=gIUgpIaVBu7MWwroUCfWRz4HhScC7NYi/xRWSdq5f1I=; b=SQcQvkGWqXiwZdroaj75Km+UzlqaBlmlnHqvhpaVvX8+fBCh+wpVdxQE8oyp3/DfXY ryUXk7UTi45IGYC7mXSl6g+MmQaR0dtZtMk+gcdOdRB3kRjtJMtzrdeF8H9lKBGbX5rG 5Bkc0J2tvaKEUhacdv6q9+4QN19nDmTSrS+QnrBd4ydMR9kRliZ9vHkojI8eITNel5wG uffprEyaHThqyK7EefyUshwOjKLl1ftq2Li6G5KSe5brfHdbl89xNcmUoGIzYJcU0qkD pmOE02ymrFJQQzsBFTcrkt+feY+ti2zeetXcZZxVG8DdbI0gZQTnBY97ilpK0jzsWR5+ 56kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=gIUgpIaVBu7MWwroUCfWRz4HhScC7NYi/xRWSdq5f1I=; b=ChUig7qVxEyB8rCZ9XqT4WV3Y+UEOibc01SjqiyB4r8zry0frrdyFCvmE1gmzq3EXl eH1RnrhAir2z5b7N0JuJNjKx40lJ3/y5i2B8SwPEzjmdiTZKV6oJBthhLGbYsPQ3OqKA fEI9iVEdAjafRDrOFKzQHdfg5RgEDk5MiAqpj2qCTDVbk7VFYfqgqJe9MSURSc4Imy3P igoA8zff6Ii2s1OuPB8VVxEdXT+Q/va3UY+7UQ78Ahj16cFBTht6w+plPxZWiaBhXa6T yWMKOfyTvBqEHD2xEKIhoiQCkYhVfqfedTW2QpaPdHUZekMJK/14ru9goMGJSNstAPUA BdYQ== X-Gm-Message-State: AOAM533lIQGJs9qQPSypSt8N+QjVV2AedskG5LJDKPe1wom/r44NAvI2 t2TnBjMdukAuAdxsqE4TJiW720ZixrRW2tyU8249X33H/AIYmw== X-Google-Smtp-Source: ABdhPJwljheXD+NWDLkv7zfHcbjn3KPmyRirkpU8biXxtG4bo6BXtITNjyJvomJrfrw76TFk5DU4OFS4RMef6P7iw+E= X-Received: by 2002:a0c:9a4e:: with SMTP id q14mr3572362qvd.22.1600926570427; Wed, 23 Sep 2020 22:49:30 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Romain Manni-Bucau Date: Thu, 24 Sep 2020 07:49:19 +0200 Message-ID: Subject: Re: Geronimo JavaMail OAuth2 authentication To: dev@geronimo.apache.org Content-Type: multipart/alternative; boundary="0000000000008ab9a605b008c3a2" --0000000000008ab9a605b008c3a2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Cesar, a few notes: 0. (just a side note) a diff with 1.5 helps more to see what changed (a tip at the end) 0bis. both projects are not on git @asf - still svn so when applied, patch will sadly be converted and committed by a committer (just to avoid any surprises) 1. spec looks ok to me (and has no reference to oauth2 right?) 2. on the impl, think XOAUTH2 constant in MailConnection is not used (but not critical) and impl looks good and with tests, kudo guys! If anyone can have a quick review (my tip being to "git fetch origin pull//head:" locally then just do a local diff - like with meld - with 1.5 spec/provider, makes the review wayyyy faster) then we can integrate that I think. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn | Book Le jeu. 24 sept. 2020 =C3=A0 00:13, Cesar Hernandez = a =C3=A9crit : > Hi, > > I pushed two PR's for review, one for GERONIMO-6780 and another one for > the subtask related with the spec GERONIMO-6783: > > https://issues.apache.org/jira/browse/GERONIMO-6780 > https://issues.apache.org/jira/browse/GERONIMO-6783 > > I didn't squash the PR to facilitate the review. > > El jue., 3 sept. 2020 a las 11:04, Romain Manni-Bucau (< > rmannibucau@gmail.com>) escribi=C3=B3: > >> Hi >> >> Sounds great! >> Dont hesitate if you need help/guidance or discuss anythg (even if I kno= w >> Jon will pby have the answer already ;)). >> >> >> Le jeu. 3 sept. 2020 =C3=A0 00:36, Cesar Hernandez a >> =C3=A9crit : >> >>> Hi, list, >>> >>> Jonathan Gallimore and I have been working on the OAuth2 authentication >>> implementation [1] that was added since JavaMail 1.5.2 [2] for the gero= nimo >>> JavaMail provider module [3]. >>> We created a new JIRA [4] and we expect to send a first PR in the >>> upcoming weeks. >>> >>> [1] >>> https://developers.google.com/gmail/imap/xoauth2-protocol >>> >>> [2] >>> https://eclipse-ee4j.github.io/mail/OAuth2 >>> >>> [3] >>> https://github.com/apache/geronimo-javamail >>> >>> [4] >>> https://issues.apache.org/jira/browse/GERONIMO-6780 >>> -- >>> Atentamente: >>> C=C3=A9sar Hern=C3=A1ndez. >>> >> > > -- > Atentamente: > C=C3=A9sar Hern=C3=A1ndez. > --0000000000008ab9a605b008c3a2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Cesar,

a few notes:

0. (just a side note) a diff with 1.5 helps more to see what chang= ed (a tip at the end)
0bis. both projects are not on git=C2=A0@as= f - still svn so when applied, patch will sadly be converted and committed = by a committer (just to avoid any surprises)
1. spec looks ok to = me (and has no reference to oauth2 right?)
2. on the impl, think = XOAUTH2 constant in MailConnection is not used (but not critical) and impl = looks good and with tests, kudo guys!

If anyone ca= n have a quick review (my tip being to "git fetch origin pull/<pr i= d>/head:<pr branch name>" locally then just do a local diff -= like with meld - with 1.5 spec/provider, makes the review wayyyy faster) t= hen we can integrate that I think.

Romain= Manni-Bucau
@rmannibucau | =C2=A0Blog=C2=A0| Old Blog |=C2=A0Github=C2=A0| LinkedIn=C2=A0| Book
=


Le=C2=A0jeu. 24 sept. 2020 =C3=A0=C2=A000:13, Cesar Hernandez = <cesarguate@gmail.com> a = =C3=A9crit=C2=A0:
Hi,

I pushed two PR's for review, one f= or=C2=A0GERONIMO-6780 and another one for the subtask related with the spec= GERONIMO-6783:


I didn't sq= uash the PR to facilitate the review.=C2=A0

El jue., 3 sept. 202= 0 a las 11:04, Romain Manni-Bucau (<rmannibucau@gmail.com>) escribi=C3=B3:
Hi

Sounds great!
Dont hesitate if you need help/guidance or discuss anythg (even = if I know Jon will pby have the answer already ;)).


Le jeu. 3 sept. 2020= =C3=A0 00:36, Cesar Hernandez <cesarguate@gmail.com> a =C3=A9crit=C2=A0:
Hi, lis= t,

Jonathan Gallimore and I have been working on the OAu= th2 authentication implementation [1] that was added since JavaMail 1.5.2 [= 2] for the geronimo JavaMail provider module [3].
We created a ne= w JIRA [4] and we expect to send a first PR in the upcoming weeks.

[2]

[3]

[4]
--
Atentamente:
C=C3=A9sar Hern=C3=A1ndez.
=


--
Atentamente:
C=C3=A9sar Hern=C3=A1ndez.
--0000000000008ab9a605b008c3a2--