geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Romain Manni-Bucau <rmannibu...@gmail.com>
Subject Re: Geronimo JavaMail OAuth2 authentication
Date Thu, 24 Sep 2020 05:49:19 GMT
Hi Cesar,

a few notes:

0. (just a side note) a diff with 1.5 helps more to see what changed (a tip
at the end)
0bis. both projects are not on git @asf - still svn so when applied, patch
will sadly be converted and committed by a committer (just to avoid any
surprises)
1. spec looks ok to me (and has no reference to oauth2 right?)
2. on the impl, think XOAUTH2 constant in MailConnection is not used (but
not critical) and impl looks good and with tests, kudo guys!

If anyone can have a quick review (my tip being to "git fetch origin
pull/<pr id>/head:<pr branch name>" locally then just do a local diff -
like with meld - with 1.5 spec/provider, makes the review wayyyy faster)
then we can integrate that I think.

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le jeu. 24 sept. 2020 à 00:13, Cesar Hernandez <cesarguate@gmail.com> a
écrit :

> Hi,
>
> I pushed two PR's for review, one for GERONIMO-6780 and another one for
> the subtask related with the spec GERONIMO-6783:
>
> https://issues.apache.org/jira/browse/GERONIMO-6780
> https://issues.apache.org/jira/browse/GERONIMO-6783
>
> I didn't squash the PR to facilitate the review.
>
> El jue., 3 sept. 2020 a las 11:04, Romain Manni-Bucau (<
> rmannibucau@gmail.com>) escribió:
>
>> Hi
>>
>> Sounds great!
>> Dont hesitate if you need help/guidance or discuss anythg (even if I know
>> Jon will pby have the answer already ;)).
>>
>>
>> Le jeu. 3 sept. 2020 à 00:36, Cesar Hernandez <cesarguate@gmail.com> a
>> écrit :
>>
>>> Hi, list,
>>>
>>> Jonathan Gallimore and I have been working on the OAuth2 authentication
>>> implementation [1] that was added since JavaMail 1.5.2 [2] for the geronimo
>>> JavaMail provider module [3].
>>> We created a new JIRA [4] and we expect to send a first PR in the
>>> upcoming weeks.
>>>
>>> [1]
>>> https://developers.google.com/gmail/imap/xoauth2-protocol
>>>
>>> [2]
>>> https://eclipse-ee4j.github.io/mail/OAuth2
>>>
>>> [3]
>>> https://github.com/apache/geronimo-javamail
>>>
>>> [4]
>>> https://issues.apache.org/jira/browse/GERONIMO-6780
>>> --
>>> Atentamente:
>>> César Hernández.
>>>
>>
>
> --
> Atentamente:
> César Hernández.
>

Mime
View raw message