geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Romain Manni-Bucau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GERONIMO-6728) Geronimo OpenTracing OpenTracingServerRequestFilter is fired twice
Date Tue, 07 May 2019 18:55:00 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835023#comment-16835023
] 

Romain Manni-Bucau commented on GERONIMO-6728:
----------------------------------------------

Hi [~jgallimore], patch look good - can only apply it on thursday since Im off-computer before.
That said I would like to ensure the title is probably misleading since filter is applied
twice in tomee cause of its scanning rules not being CDI (microprofile) based.

Open question: do we want to drop @Provider from GeronimoOpenTracingFeature ? I also wonder
if tomee shouldnt sanitize its scanned provider using 1. CDI - any scanned provider - and
2. The lowest in inheritance tree wins over the highest if not a CDI bean or EJB. Wdyt? Am
I right in my assumption that this ticket hides this other real issue?

> Geronimo OpenTracing OpenTracingServerRequestFilter is fired twice
> ------------------------------------------------------------------
>
>                 Key: GERONIMO-6728
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6728
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>            Reporter: Jonathan Gallimore
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Geronimo OpenTracing OpenTracingServerRequestFilter is fired twice for a request. This
leads to the ThreadLocal in ScopeManagerImpl not being cleaned up properly, and threads picking
up the wrong traceId (i.e. from previous threads). 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message