geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [geronimo-opentracing] jgallimore opened a new pull request #1: Zipkin v2 changes
Date Fri, 03 May 2019 14:07:31 GMT
jgallimore opened a new pull request #1: Zipkin v2 changes
URL: https://github.com/apache/geronimo-opentracing/pull/1
 
 
   This PR introduces some simple changes to enable Geronimo Opentracing to POST data to Zipkin's
V2 endpoint successfully.
   
   Using the latest Zipkin server, there appear to be 3 issues:
   
   1. Using the V1 endpoint works, but data isn't visible in the UI
   2. Posting to the V2 endpoint results in a 404 if the `Accept: application/json` header
is set (the endpoint doesn't return JSON)
   3. Posts that include binaryAnnotations in the payload are dropped by the V2 endpoint as
this element is not valid in the V2 payload.
   
   This PR introduces a config option to turn on V2 formatting: `span.converter.zipkin.http.useV2`.
This is false by default.
   
   This PR also attempts to provide an end-to-end test using Zipkin's own ZipkinRule to start
an in-memory Zipkin with a mock webserver. It has been modified to drop requests with binaryAnnotations
in the payload, so it behaves in a similar way to the actual server in that regard. See: https://github.com/apache/incubator-zipkin/blob/2.12.9/zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java#L191-L202

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message