From dev-return-98963-archive-asf-public=cust-asf.ponee.io@geronimo.apache.org Sat Aug 4 00:06:48 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E9991180647 for ; Sat, 4 Aug 2018 00:06:47 +0200 (CEST) Received: (qmail 98327 invoked by uid 500); 3 Aug 2018 22:06:47 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 98317 invoked by uid 99); 3 Aug 2018 22:06:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Aug 2018 22:06:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EE018C1CF3 for ; Fri, 3 Aug 2018 22:06:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.49 X-Spam-Level: * X-Spam-Status: No, score=1.49 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SORBS_WEB=1.5, T_DKIMWL_WL_MED=-0.01] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=code-house-org.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id nCAQ9j8fFM5j for ; Fri, 3 Aug 2018 22:06:43 +0000 (UTC) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 9D95C5F27E for ; Fri, 3 Aug 2018 22:06:43 +0000 (UTC) Received: by mail-wr1-f50.google.com with SMTP id e7-v6so6664503wrs.9 for ; Fri, 03 Aug 2018 15:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=code-house-org.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2CesInuX8xHLPPQMVVDwvUsjnuMxOW2nuIQgnIICiFM=; b=L28ufXulYKnUxaoeH6CXH1RVmWtHDAV2cOEvdybnWpMo3R9vT5dbNypxkoUvINy/tA L5FRd4xCuC0E9mBd0euN+tGa0iPxoXX6lq6HMzZ0HP0Yxrup1M1sKMCPslb5vyFFs89F c3qFE4uvrL1cLQqhMF7TbokK6Em3QEoZ0mL1RIERpsn2lxA/ceKwiWP1T2KzB5S4CAIN 71PAoLfYod2TmN+B3SJbInJDz+KY3+CpJY0D7wm4k8J8NXpORvisPXg8DvLRuRvUWLaZ 6LJjaAIVH5JI6UNGQnbzThwSXQ+GnFLciOsk+rDygJbb9hbPsnU4B+PshhkoD+7dRdGM 8dug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=2CesInuX8xHLPPQMVVDwvUsjnuMxOW2nuIQgnIICiFM=; b=OnWQO3xdrpUF0TUMngbyevnrD6yx1xveCW1E0DQidlbbIw/Uez3o5A64WBXYOlmxxb 9VO60P1bg3016XXMGpSEltTv1itrKuvK9uHb8k1/1sHjrjjjbOe5AICvPxJn9jXC1z8J EXUId0ApYzQjGi+k3FYXyduH6KnAHEvYcxtkNJC2eUbitgatYVaQx8Vz6E4JFYpu+VEe c3loCq524EAekqhlqF8hDo/0mwGcTqnnSJNEIMKV0BpmZx5lGmGz7CfMm1lGJjZnEqqz XDwau+bBZVRhFmmcg07deaQUym1/Xa9YZSmtT6CZ2+P8KcXiMSjX1ycP8JgkRdn38UZg C73g== X-Gm-Message-State: AOUpUlHDlh4ptIUYAdlmKOEoaOqVT9CaitW4OuRJIuaUBj2ZLjac/2Zz +vBcdL2j4FQRpxxmnn4b8QZcUzAeGgs= X-Google-Smtp-Source: AAOMgpckTtFXHilOkT4uAi9eo+OcnbPBqvJDud82zE05HPfyHfzB4U6BN2xjQFg3BqulYCWvuysSSA== X-Received: by 2002:adf:ffc7:: with SMTP id x7-v6mr3780736wrs.137.1533334002307; Fri, 03 Aug 2018 15:06:42 -0700 (PDT) Received: from [192.168.2.106] (5-226-103-38.static.ip.netia.com.pl. [5.226.103.38]) by smtp.gmail.com with ESMTPSA id r18-v6sm356059wmh.28.2018.08.03.15.06.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Aug 2018 15:06:41 -0700 (PDT) Subject: Re: Major updates to XBean To: dev@geronimo.apache.org References: <4C62A58F-9EA9-4484-847E-E14889405268@code-house.org> From: =?UTF-8?Q?=c5=81ukasz_Dywicki?= Openpgp: preference=signencrypt Autocrypt: addr=luke@code-house.org; prefer-encrypt=mutual; keydata= xsFNBFbvMOABEADeAG5uLcccuUO7RfEdu4sEyhZgb0ZdrlLKkJv+QgwHpjgvKYg16YTLi0/0 ZO2OvBKUAEOf5/Z6NhEVtHiqUUeQ0Qvw/iv7VsxW944xC4rpiyL81u8FFkphgQfPM8HQjf6D 6zG7Ds90M27OblKCXA4VGmqIh3fhcyoyWZ/GMZHTtHcGRZtTMt9vkcmCxMgDJnKDmaL87ko/ ib7GR8HJa9UZ940qW7ecAG40Z008fGQTzOQ8DbGDUKS0+a5egndUk7l9ypcI3A/PulHf9i3z Bgqo6uRZzkwgUxgmR3n1qe1z7iRGgPL810Yvn/5leFimFYGciNlj1zIdGg5Len5lyRetSd8w U/ARcPnSFnzTnZTrYlYGwhQNvcuC+2m/iKOgXy/tPZOxoeJLfeoFKA8EoSFit6AfYK0CZ1Sf W2soN7FkPYJxxCW74l2KIioZrI/Q/zoMNLk1eapqcsgIHUERDOSqSEJFyd9SR8iWEIAenC0g 5WNoFd19grgZ6FUuXzb79/cxrwZbGA6NxzJU497wUPOxphUKqIwZQw89Xgq2qiQaO6tKHd1Q 0jpRnkGAteYfNcy9LnRIo/2/aMQEltLgHU+Z//gzkBlz6/XChdA7Vcss9AIOK0pFb+BY1QAA wDBwzFjSEhTZsyzOk4er2us8of0jdlVTzSXuh2R+uVgyXIfnfwARAQABzTTFgXVrYXN6IER5 d2lja2kgKHBncC1tYWlsLWtleSkgPGx1a2VAY29kZS1ob3VzZS5vcmc+wsF/BBMBCAApBQJW 7zDgAhsDBQkHhh+ABwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQAdrcj4PeJmUuTxAA jnxIUMqQaAJWL8f4ZksxdrHj8f54H39M/P02Tmf0875LyT28R4lc0dvTX0VlfhDay0cGSg4w AwqCNozzTu4f0JnrUH2/HTTLgWHMxtK/X65Y9xyxpmfnNPm8YZ7aLm7zDIkEDPAEwaMtRzxM Yy9IBupg+l/N9EvX7tEQjhm94MFj4NmP+sv0IYMWfNjtKYUpeOhSxre5MLOAeDqFG25TT/+d Uf58BekEGK7OeA6aXa+m77AYNq6s+bjVnGTYxUwLc9GtjKraaDMO/fgr6EvlUD0EPhAmn+7E IPj+IwNTcbdBAt/se75aHNeIcn0OLL2WTHHRIqiNCnjNwAGgIn9V3swV5I0o0dJOiEdP/f7/ v5wkmqMxhk/dQW3UCLwLOIeZEXpl5Y/CKm8Toe0sAr+voAWmBUl3fqIywtOf9NLI7M4bTxr/ SM5VfyEuBhlbJbDZjXhGoQAa96hQApKqdrKQs62JwMBlg7JwUb1xReHUsTSQtZW+Uzb0Ou0r Hh4rWGHZYOUDZrvnJPjO5ip1kWg5x/ceJHeeZzZ36UkcMlqqNpOfy3cW4I3/IL1PWSP29zcw +nDVGwkcJdRKl3OVjaP0ADTDla6zo59swjHFUogE61j06zkFdrbFdMB7LT8Q5G9YoFx482WD /L2hQVPBtuA4s1KcZlsJIY8EExAa+FHe/K7OwU0EVu8w4AEQAKbLgubA/Deby6e/GvsGETvQ UfHRpyPUbylhXWKKWVgQj76UdHCmPEEw3OQtvSwsvF0HY3VvmA4EsWd+9wGqa+WW0soJAgrs 4Iv4n4XragL2qdye9tgDxQkJZjejsYg9XRywq1r54xAu6xCKqfsIzIis2BJ85jXdpsnXIiIB HaM0oGrCoXksDgeaQpSGqGr8vwqwtKq3xN9Mfj+AkoAsg3IPkkebxTeQAWofIRERzkTRtSHZ EBu5Zey36zr3ef9V65OsxDNPkO13NG6TME//WCp0Lv6VKqPWL/2wvPapz5TGLaVahrWRo9zF Hn6XydLlWes6s87zswQ0L9sKPk4OY9l8LS5lqmSpKRynv8pU3HvUsilPnOjlxF1y5vAqfqck Uze+CJsnO2E4s7q4dX5996ipOGkbALkArWqfv+IHQMU2+xUSfXzm7DjRIHYL6wxfQYTwdGgk AuGduWq8Lw0qRQqTbIs7/OdDFMfa9ks/v/VI8gFPae+v0fW7q941XqlhPDHFcY00PYZV/h+g KQ1lsyrm6/Sjs/Wzs+r4SuA2rpz2yrnN0JoKMuT6T/BkE4YNhieC8QOOBbO+tGbrFGVWFKS1 v0xi+aaWfYljJudPcEWCQWFWM1YcPta9dABkAuf3k9ZAbn9+i5ph2ulg23Lm8C6cqVh4Rs++ /sFYwe2UbbGzABEBAAHCwWUEGAEIAA8FAlbvMOACGwwFCQeGH4AACgkQAdrcj4PeJmUY7w/8 CKOOzaolESY8kacIliL919OpVSGJq3AfoxdOP3YqhMC4RtMwqKdF2ygrzr9YjwtAJDNMciIm 7EFYhbIWgl17WR9Dg41Kee2GrA3B89qyHpyL1Ke1vvoNgCKSeuuT/NPSLF/v8+rGAyjTD3y9 sfQ2gcVbTqOIlV67pBIJ6RQa6OXGlKMoAHtiXlcoOaSb41L1vQXRvdmMvX3OUJUXZmbhv5UH fqRE9hUI8pruA9EfCoftQz+3nXVyOSxyCc1jMxLwY6Aokbo/eESz9AWOoPl2wSz6Y/nnILSw kO0XTGzE6YRJ+EECoBxH4kapiQvqN2a5Mrp6qc5BD2bGfNs3hZSsbZjojqL9fd4qVZoKHNas LbWGWu0sin/0qeL1me0BFhF++W75wRK8PelvJMdTktWy04IxFYlRczUX+AEnRyGZITZTk3Fx ya3rvlWFXvCAS168vRRxx2WkkdD6TSnfp6+v+qQO41LV8DffyUoIOKJXoc/FzLRSa7A2HVW0 wWv052YgcvxSiCdDqP/oxAhu8czJzddpQy4DEF3ogGhh+VGldtzdGGHUzXdtOp88iqLZ8a4t fGA7wTpIDuQ5I7DIlJowf/s0eOCH/qarWxYGvAjn3Jd1YeLhwHhdXJpZgGcKmreuKSMoJZSD qwvPGScZ+o90/cZnGejc4RA7NRAfrQkk+ts= Message-ID: <417c0992-f5dc-9f5f-d122-ad4ae14b849f@code-house.org> Date: Sat, 4 Aug 2018 00:06:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 8bit I've fixed RAT warnings and compilation issues. I also updated XSD generation logic, so it uses Apache WS Xmlschema instead of println statements. Generated schema is compatible with previous one. I also cleaned up type handling a bit. There are still 18 xbean-spring tests which are failing. These failures happen due to schema validation for more exotic constructions (maps, mixed content etc). I tested my branch locally against ActiveMQ 5.x and it does work. Since AMQ does not use any of fancy mappings, just standard attributes and elements - it worked just fine. Project compiles and builds under Maven 3.5.4 with empty repo too. Cheers, Lukasz On 02.08.2018 22:46, Romain Manni-Bucau wrote: > > > Le jeu. 2 août 2018 22:35, Łukasz Dywicki > a écrit : > > I don't see any new developments started with xbean, but there are > still projects under active development which rely on it. ActiveMQ > 5.x might be last one, not sure about others, and it does suffer > because no investments in xbean. JAXB is fine, but I doubt if any > custom type mapping will be ever able to provide such extensibility > as Spring with its declarative configuration. Moving ActiveMQ 5 > configuration schema to JAXB would be definitely a difficult task. > > > Asm, reflect and finder are way pore active, right. Another option would > be to reverse this code to amq but im fine keeping it here and upgrading > deps. I would just prefer to control the number of these modules. > > > Schema generated with my branch does not differ from old one. There > are some constructions from xbean which fail xml schema validation > after upgrading to Spring 4 with its XSD checks. I had no issues > updating XML namespace declarations (xsi etc) but some parts of > schema simply break. > This includes map elements (MapMapping) which are reported as > invalid content. I made an attempt to fix that and extend generator > to create proper declarations of elements. > > My changes so far update xbean maven plugin, remove duplicate code > and separate generators from namespace handlers. This allows to > remove ant dependency from namespace handler runtime imports, let > maven plugin use some simple plexus IoC for generator discovery. > These are mainly code reorganizations to made xbean and downstream > projects maintenance easier. > > > Did you try dropping it from your local .m2? It is not supposed to work > - even known to fail at least until 3.5.3. > > > Łukasz Dywicki > > On 2 Aug 2018, at 16:25, Guillaume Nodet > wrote: > >> >> Over the last years, I have hardly seen anyone using the >> xbean-spring stuff anymore.  I think most of custom namespaces >> have been implemented using JAXB instead.   >> I think one of the problem is that the xml tends to be ugly, so >> starting from the xml and using JAXB usually makes more sense. >> I guess if you plan to use it in ActiveMQ, the generated schema >> has to be compatible with the previous ones, right ? Is that the >> case with your changes ? >> >> Guillaume  >> >> Le jeu. 2 août 2018 à 16:17, > > a écrit : >> >> Ladies and gentlemen, >> I started messing around XBean as its codebase is in moderate >> form. I’ve run into multiple issues while trying to get it >> running under Karaf 4.1 together with ActiveMQ and decided to >> push it forward. I spent last couple of days cleaning up >> duplicated code and refactoring maven plugin so it does not >> depend on any specific generator. There is still lots of >> things to do as there are several Spring tests which are >> failing. Due to stronger schema validation around 15 spring >> tests currently fails. This is because generated schema works >> only for basic elements and fails with embedded collections. I >> already started to reform that part and I should be able to >> update XsdGenerator. >> >> I would like to submit PR once I solve all the issues and test >> it with ActiveMQ would you accept my work? Due to amount of >> breaking changes I started 5.0.x branch (which might be good >> to start support Spring 4 or 5). >> There is one big commit so far in my GitHub >> fork: https://github.com/splatch/geronimo-xbean/tree/xbean-5.0.x, >> which I can chunk into smaller (yet non compilable) commits in >> order to make history a bit clearer.  >> >> Kind regards, >> Łukasz >> — >> Apache Karaf Commiter & PMC member >> luke@code-house.org >> Twitter: ldywicki >> Blog: http://dywicki.pl >> Code-House - http://code-house.org >> >> >> >> -- >> ------------------------ >> Guillaume Nodet >>