geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Louis MONTEIRO <jeano...@gmail.com>
Subject Re: Import jwt auth code or do it back from scratch?
Date Mon, 23 Apr 2018 10:57:55 GMT
Hey Romain


Sorry. I've been a little busy and out of oss for a while.

Last week I've been able to get back and rework the contribution to extract
a reusable library on the tomee 8 branch. See PR and mailing list emails
there.

I started also as promised to create a sample on how to use it. Also in the
PR but not fully finished.

I was planning to give again more time this week and just saw your last
messages :(

Looks like I've been too late right?

Le dim. 22 avr. 2018 à 17:04, Romain Manni-Bucau <rmannibucau@gmail.com> a
écrit :

> code pushed
>
> it needs an OWB 2.0.5 release (cause of current tck setup) and some review
> of somebody else but otherwise we pass tcks and we are dependency free.
>
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github
> <https://github.com/rmannibucau> | LinkedIn
> <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
> 2018-04-21 15:06 GMT+02:00 Romain Manni-Bucau <rmannibucau@gmail.com>:
>
>> Ok,
>>
>> will restart it from scratch soon to avoid to wait another month
>>
>> everybody is welcomed to help
>>
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> <https://rmannibucau.metawerx.net/> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github
>> <https://github.com/rmannibucau> | LinkedIn
>> <https://www.linkedin.com/in/rmannibucau> | Book
>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>
>> 2018-04-19 12:04 GMT+02:00 Romain Manni-Bucau <rmannibucau@gmail.com>:
>>
>>> up, any blocker to import
>>> https://github.com/apache/tomee/tree/master/mp-jwt/ in our repo? I'd
>>> still like to finish the impl and get it out soon.
>>>
>>>
>>> Romain Manni-Bucau
>>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>> <http://rmannibucau.wordpress.com> | Github
>>> <https://github.com/rmannibucau> | LinkedIn
>>> <https://www.linkedin.com/in/rmannibucau> | Book
>>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>>
>>> 2018-04-15 12:02 GMT+02:00 Romain Manni-Bucau <rmannibucau@gmail.com>:
>>>
>>>> up @jl?
>>>>
>>>>
>>>> Romain Manni-Bucau
>>>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>>> <http://rmannibucau.wordpress.com> | Github
>>>> <https://github.com/rmannibucau> | LinkedIn
>>>> <https://www.linkedin.com/in/rmannibucau> | Book
>>>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>>>
>>>> 2018-04-05 10:54 GMT+02:00 Romain Manni-Bucau <rmannibucau@gmail.com>:
>>>>
>>>>> +1
>>>>>
>>>>>
>>>>> Romain Manni-Bucau
>>>>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>>>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>>>> <http://rmannibucau.wordpress.com> | Github
>>>>> <https://github.com/rmannibucau> | LinkedIn
>>>>> <https://www.linkedin.com/in/rmannibucau> | Book
>>>>> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>>>>>
>>>>> 2018-04-05 10:45 GMT+02:00 Mark Struberg <struberg@yahoo.de>:
>>>>>
>>>>>> I think it's not about the work to do the import. It's just about
>>>>>> that JL did all the work, so he should also show up as committer.
>>>>>> Merit to whom merit belongs to!
>>>>>>
>>>>>> And ofc will help with reviews and polishing then!
>>>>>>
>>>>>> LieGrue,
>>>>>> strub
>>>>>>
>>>>>> > Am 03.04.2018 um 22:35 schrieb Romain Manni-Bucau <
>>>>>> rmannibucau@gmail.com>:
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> > Le 3 avr. 2018 21:37, "Jean-Louis MONTEIRO" <jeanouii@gmail.com>
a
>>>>>> écrit :
>>>>>> > Hi Romain,
>>>>>> >
>>>>>> > Is there anything preventing to pull the code from my PR?
>>>>>> >
>>>>>> > No, let me rephrase: can *you* import it please? :)
>>>>>> >
>>>>>> > Not that I am very attached to the code I produced.
>>>>>> > It's not perfect either, but wouldn't it be sad to start from
>>>>>> scratch?
>>>>>> >
>>>>>> > Jean-Louis
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> > Le sam. 31 mars 2018 à 18:15, Romain Manni-Bucau <
>>>>>> rmannibucau@gmail.com> a écrit :
>>>>>> > Hi JL
>>>>>> >
>>>>>> > Is it ok for you to import the reusable code you did in the
repo we
>>>>>> got for the spec or do you prefer i recode it to populate the repo?
Also
>>>>>> planning to do the api jar next to the impl.
>>>>>> >
>>>>>> > Thanks
>>>>>> >
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>

Mime
View raw message