Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EB00E200B8C for ; Mon, 12 Sep 2016 12:33:29 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E9806160AC8; Mon, 12 Sep 2016 10:33:29 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E10B7160AB8 for ; Mon, 12 Sep 2016 12:33:28 +0200 (CEST) Received: (qmail 27645 invoked by uid 500); 12 Sep 2016 10:33:28 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 27618 invoked by uid 99); 12 Sep 2016 10:33:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Sep 2016 10:33:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C392418014C for ; Mon, 12 Sep 2016 10:33:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Thf38IsgfG0m for ; Mon, 12 Sep 2016 10:33:23 +0000 (UTC) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id CF2F75F30D for ; Mon, 12 Sep 2016 10:33:22 +0000 (UTC) Received: by mail-lf0-f52.google.com with SMTP id l131so83519560lfl.2 for ; Mon, 12 Sep 2016 03:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=a2xnIkyPrUgsivet2Lpes3rF8Qc8t2LjdgI8xumAVGs=; b=g9GD9JUfEJJGuDHOURCQyK9HQ05onyyqc8rjzVWzcqXki2UXGf4ktvIZ72y22fFxXt 8i6uK1uBo7BFSHV7UAGBY2n1UE0yfXMEJd2vwlcVyVJ96EQLM61sKJ+5aD5URKqCDid5 Xg6DEzAQhhuSlIOSCuQyEqjWHKtVgPx59sLuYsxQBM3TYdfMU9jRV/49YsL1PSexwklR HJqpBZD7z1nWIdDUI3fx2qvrQBiwQPqNV+LrccwXvKFXTv/PrjF55E0mxgKy9UcVFhNh 53A8YUL0LK6uqCbErSffeMHE/OQP11iHlvv8md8UAIQeGRC5ye+0W08Ei2qjLThkv5Wh dtKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=a2xnIkyPrUgsivet2Lpes3rF8Qc8t2LjdgI8xumAVGs=; b=maUghsIM3/ALeRqZP8JyhisDsndi9UgmkwQjDNSZa0gCY3NNA2IEEMzD16JGKjnOTe jERT+UmLkivdDlRkO+lpnLwqe/xXfrY8MZ09MVNw2xij075PQfX7fjrWEA5jsLa7S9Lk aaTFoIyI8LvSAGp+mQzJq/+YZoVFzmA0cdR39xRWMt35XtFiVCcBIfN5dB28kLvmGpxu qNUqa2mmpjQb7b6WkAEoML6VZMDacFwb5/dgLV7FKWUJaewpjA9MiWJfzxjUGvQ4ojJW 6zQ5uduDKT7aT/K42/aMTpsDMLiQ/aGbbMijXKHgXNA8s88nn4MfHl7qO6tTkdxniSI/ vwwA== X-Gm-Message-State: AE9vXwOCAFT34UOYdaBQYPH7QgnksC9AstkT2l6LN2dmZV/UY2DERYkh68GV672sNEYFsW6aOBaX0NsMAJ1h4g== X-Received: by 10.25.17.224 with SMTP id 93mr1868956lfr.77.1473676401511; Mon, 12 Sep 2016 03:33:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.161.134 with HTTP; Mon, 12 Sep 2016 03:33:00 -0700 (PDT) In-Reply-To: References: <312C96CC-818A-42EA-9D3D-C27E3A1B4810@yahoo.de> <626343671.454311.1471775070602@mail.yahoo.com> <1667555581.946658.1471970988619@mail.yahoo.com> From: Romain Manni-Bucau Date: Mon, 12 Sep 2016 12:33:00 +0200 Message-ID: Subject: Re: PR Merge? To: dev@geronimo.apache.org Cc: Mark Struberg Content-Type: multipart/alternative; boundary=001a113fa7d86d1358053c4d06a3 archived-at: Mon, 12 Sep 2016 10:33:30 -0000 --001a113fa7d86d1358053c4d06a3 Content-Type: text/plain; charset=UTF-8 done, will be off the end of the week and back next week but feel free to test/release etc if you need it ASAP ;) Romain Manni-Bucau @rmannibucau | Blog | Old Wordpress Blog | Github | LinkedIn | Tomitriber | JavaEE Factory 2016-09-12 12:12 GMT+02:00 Romain Manni-Bucau : > will have a look to jsonp now, not sure i'll get enough time to fix it but > on it for now ;) > > > Romain Manni-Bucau > @rmannibucau | Blog > | Old Wordpress Blog > | Github > | LinkedIn > | Tomitriber > | JavaEE Factory > > > 2016-08-23 19:21 GMT+02:00 Clebert Suconic : > >> I don't know if I can, but I'm interested on it. I will send an email >> here if I start something so we won't have double effort around it. >> >> So, I ask if anyone started doing this.. please send a heads up here >> so we won't have 2 people working on the same thing. >> >> >> >> On Tue, Aug 23, 2016 at 1:17 PM, Romain Manni-Bucau >> wrote: >> > >> > 2016-08-23 18:49 GMT+02:00 Mark Struberg : >> >> >> >> No it's not _that_ easy. Simply using a WeakHashMap wont work. You also >> >> have to wrap the value in a WeakReference. Otherwise the value in the >> Map >> >> will prevent the CL from being garbage collected. A common pitfall >> I've seen >> >> soooo often implemented the wrong way ;) >> >> >> > >> > Sounds like a good enough solution to me. JCache impl should be updated >> as >> > well probably. >> > >> > Who does want to drive this? I'm quite limited in time ATM so happy to >> let >> > it be done but can help a bit in 1 or 2 weeks if needed. >> > >> >> >> >> LieGrue, >> >> strub >> >> >> >> >> >> >> >> >> >> >> >> > On Tuesday, 23 August 2016, 17:42, Clebert Suconic >> >> > wrote: >> >> > >> Not sure I get you there, commons clearly doesn't take in charge >> any >> >> > >> of >> >> > that >> >> >> but some containers can force some cleanup (not the other way >> around) >> >> >> - at >> >> >> least for beansutils for instance. >> >> > >> >> > With a WeakHashmap, the cache will be removed once the classLoader is >> >> > released, right? Which is what I am trying to achieve here. The cache >> >> > per classLoader. And Removing the classLoader once the references are >> >> > >> >> > released. >> >> > >> >> > >> >> >> >> >> >> Starting with a "leaking" WeakHashMap> >> > Provider> and see if >> >> >> consumers are complaining. >> >> >> >> >> >> It would solve your issue and I can make it working in tomee for >> >> >> instance >> >> > >> >> > >> >> > Why it would matter? a WeakHashMap won't cause a leak in anyways. The >> >> > ClassLoader is a weak references. Whenever Tomee released the >> >> > classLoader the element would go away from the WeakHashMap. That's >> how >> >> > weakHashMaps work, and that's the intent. >> >> > >> > >> > >> >> >> >> -- >> Clebert Suconic >> > > --001a113fa7d86d1358053c4d06a3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
done, will be off the end of the week and back next week b= ut feel free to test/release etc if you need it ASAP ;)


Romain Manni-Bucau
<= a href=3D"https://twitter.com/rmannibucau" target=3D"_blank">@rmannibucau | =C2=A0Blog=C2=A0| Old Wordpress Blog |=C2=A0Github=C2=A0| LinkedIn=C2=A0| Tomitriber=C2=A0| JavaEE Factory
<= /div>

2016-09-12 12:12 GMT+02:00 Romain Manni-Buca= u <rmannibucau@gmail.com>:
will have a look to jsonp now, not sure i'll get = enough time to fix it but on it =C2=A0for now ;)


Romain Manni-Buc= au
= @rmannibucau | =C2=A0Blog=C2=A0| Old Wordpress Blog |=C2=A0Github=C2=A0| LinkedIn=C2=A0| Tomitriber=C2=A0| Ja= vaEE Factory

2016-08-23 19:21 GMT+02:00 Clebert Suconic <= span dir=3D"ltr"><clebert.suconic@gmail.com>:
I don't know if I can, but I'm interested on it. I will s= end an email
here if I start something so we won't have double effort around it.

So, I ask if anyone started doing this.. please send a heads up here
so we won't have 2 people working on the same thing.



On Tue, Aug 23, 2016 at 1:17 PM, Romain Manni-Bucau
<rmannibucau@= gmail.com> wrote:
>
> 2016-08-23 18:49 GMT+02:00 Mark Struberg <struberg@yahoo.de>:
>>
>> No it's not _that_ easy. Simply using a WeakHashMap wont work.= You also
>> have to wrap the value in a WeakReference. Otherwise the value in = the Map
>> will prevent the CL from being garbage collected. A common pitfall= I've seen
>> soooo often implemented the wrong way ;)
>>
>
> Sounds like a good enough solution to me. JCache impl should be update= d as
> well probably.
>
> Who does want to drive this? I'm quite limited in time ATM so happ= y to let
> it be done but can help a bit in 1 or 2 weeks if needed.
>
>>
>> LieGrue,
>> strub
>>
>>
>>
>>
>>
>> > On Tuesday, 23 August 2016, 17:42, Clebert Suconic
>> > <clebert.suconic@gmail.com> wrote:
>> > >>=C2=A0 Not sure I get you there, commons clearly does= n't take in charge any
>> > >> of
>> > that
>> >>=C2=A0 but some containers can force some cleanup (not the= other way around)
>> >> - at
>> >>=C2=A0 least for beansutils for instance.
>> >
>> > With a WeakHashmap, the cache will be removed once the classL= oader is
>> > released, right? Which is what I am trying to achieve here. T= he cache
>> > per classLoader. And Removing the classLoader once the refere= nces are
>> >
>> > released.
>> >
>> >
>> >>
>> >>=C2=A0 Starting with a "leaking" WeakHashMap<= ClassLoader,
>> > Provider> and see if
>> >>=C2=A0 consumers are complaining.
>> >>
>> >>=C2=A0 It would solve your issue and I can make it working= in tomee for
>> >> instance
>> >
>> >
>> > Why it would matter? a WeakHashMap won't cause a leak in = anyways. The
>> > ClassLoader is a weak references. Whenever Tomee released the=
>> > classLoader the element would go away from the WeakHashMap. T= hat's how
>> > weakHashMaps work, and that's the intent.
>> >
>
>



--
Clebert Suconic


--001a113fa7d86d1358053c4d06a3--