Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
MIME-Version: 1.0
In-Reply-To: <CACLE=7MKjgLtfJr=YtGWF24LePGshRZ9pdB36xHtRhs=e4iwmg@mail.gmail.com>
References: <CAOqetn9Nrdz3p9wMG6Kz=BM3-SWvKDrwkk7VU_tNzt+nF2oB9g@mail.gmail.com>
 <CACLE=7MKjgLtfJr=YtGWF24LePGshRZ9pdB36xHtRhs=e4iwmg@mail.gmail.com>
From: Clebert Suconic <clebert.suconic@gmail.com>
Date: Fri, 19 Aug 2016 08:40:37 -0500
Message-ID: <CAKF+bspnJe+LDWqsx8LyQxNMWDdRtjaHDvfGMEr3h7_L7GttMw@mail.gmail.com>
Subject: Re: PR Merge?
To: Romain Manni-Bucau <rmannibucau@gmail.com>
Cc: "dev@geronimo.apache.org" <dev@geronimo.apache.org>
Content-Type: multipart/alternative; boundary=001a113e5ed8044d1c053a6cd815
archived-at: Fri, 19 Aug 2016 13:40:50 -0000

--001a113e5ed8044d1c053a6cd815
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

The patch is caching it with a soft cache. Meaning the impl will go away
when memory is needed and a class loader gone.


The performance of having to load the class on every operation is really
heavy.

On Friday, August 19, 2016, Romain Manni-Bucau <rmannibucau@gmail.com>
wrote:

> Hi John
>
> I implement it this way to work in all cases and deployment without
> leaking an impl (this patch does)
>
> The fix is in artemis I suspect: Json.write/read shouldnt be used bit the=
y
> should go through the factory.
>
> Hope it helps.
>
> Le 19 ao=C3=BBt 2016 04:11, "John D. Ament" <johndament@apache.org
> <javascript:_e(%7B%7D,'cvml','johndament@apache.org');>> a =C3=A9crit :
>
>> Hi,
>>
>> I was wondering, would anyone be able to review this PR and perhaps merg=
e
>> it?  After I ported Artemis to use Johnzon, Clebert noticed some
>> performance issues where the service was being looked up always.  His PR=
 is
>> to help resolve that.
>>
>> https://github.com/apache/geronimo-specs/pull/4
>>
>> John
>>
>

--=20
Clebert Suconic

--001a113e5ed8044d1c053a6cd815
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

The patch is caching it with a soft cache. Meaning the impl will go away wh=
en memory is needed and a class loader gone. =C2=A0<div><br></div><div><br>=
</div><div>The performance of having to load the class on every operation i=
s really heavy. =C2=A0<span></span><br><br>On Friday, August 19, 2016, Roma=
in Manni-Bucau &lt;<a href=3D"mailto:rmannibucau@gmail.com">rmannibucau@gma=
il.com</a>&gt; wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:=
0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir=3D"ltr">Hi J=
ohn</p>
<p dir=3D"ltr">I implement it this way to work in all cases and deployment =
without leaking an impl (this patch does)</p>
<p dir=3D"ltr">The fix is in artemis I suspect: Json.write/read shouldnt be=
 used bit they should go through the factory.</p>
<p dir=3D"ltr">Hope it helps.<br>
</p>
<div class=3D"gmail_extra"><br><div class=3D"gmail_quote">Le=C2=A019 ao=C3=
=BBt 2016 04:11, &quot;John D. Ament&quot; &lt;<a href=3D"javascript:_e(%7B=
%7D,&#39;cvml&#39;,&#39;johndament@apache.org&#39;);" target=3D"_blank">joh=
ndament@apache.org</a>&gt; a =C3=A9crit=C2=A0:<br type=3D"attribution"><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #c=
cc solid;padding-left:1ex"><div dir=3D"ltr">Hi,<div><br></div><div>I was wo=
ndering, would anyone be able to review this PR and perhaps merge it?=C2=A0=
 After I ported Artemis to use Johnzon, Clebert noticed some performance is=
sues where the service was being looked up always.=C2=A0 His PR is to help =
resolve that.</div><div><br></div><div><a href=3D"https://github.com/apache=
/geronimo-specs/pull/4" target=3D"_blank">https://github.com/apache/gero<wb=
r>nimo-specs/pull/4</a><br></div><div><br></div><div>John</div></div>
</blockquote></div></div>
</blockquote></div><br><br>-- <br>Clebert Suconic<br><br>

--001a113e5ed8044d1c053a6cd815--