Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Date: Tue, 10 Jul 2012 19:38:35 +0000 (UTC)
From: "Jarek Gawor (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Message-ID: <1909183925.30563.1341949115330.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1943506660.7761.1341483454855.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (GERONIMO-6370) Update static files without
 bundle restart
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GERONIMO-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410742#comment-13410742 ] 

Jarek Gawor commented on GERONIMO-6370:
---------------------------------------

I was reviewing your changes and I have a few comments:

1) The changes to ApplicationInstaller.java in revision 1357538 should be unnecessary if we just add the following to AbstractRepository.java:

 typeHandlers.put("eba", new UnpackArtifactTypeHandler());

This I believe will work much nicer (and easy to undo in case there is a problem).

2) In the same revision I'm not sure why unpackBundleFile() function was added to GeronimoApplication.java

3) Please fix your editor to use 4 spaces instead of tabs and format your code. It is hard to read it otherwise.

4) Changes made in revision 1357550 to GEP assume now that the bundle file is unpacked. GEP should be smart enough to work with unpacked or packed bundle files. 


> Update static files without bundle restart
> ------------------------------------------
>
>                 Key: GERONIMO-6370
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6370
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: Aries
>    Affects Versions: 3.0
>            Reporter: viola.lu
>            Assignee: viola.lu
>             Fix For: 3.0.1
>
>
> https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-796
> have to extract bundles when install EBA and install it via reference: file

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira