geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevan Miller <kevan.mil...@gmail.com>
Subject Re: [Vote] Release Geronimo Samples & Daytrader 3.0-beta-1
Date Thu, 17 Nov 2011 19:24:31 GMT

For the daytrader release, multiple files are missing source license headers:

 !????? ./javaee6/pom.xml
 !????? ./javaee6/assemblies/pom.xml
 !????? ./javaee6/assemblies/daytrader-ear/pom.xml
 !????? ./javaee6/assemblies/daytrader-ear/src/main/java/org/apache/geronimo/daytrader/javaee6/App.java
 !????? ./javaee6/assemblies/daytrader-ear/src/main/resources/META-INF/application.xml
 !????? ./javaee6/modules/pom.xml
 !????? ./javaee6/modules/entities/pom.xml
 !????? ./javaee6/modules/utils/pom.xml
 !????? ./javaee6/modules/web/pom.xml
 !????? ./javaee6/modules/web/src/main/java/org/apache/geronimo/daytrader/javaee6/web/TradeBuildDB.java

So, here's my -1. Everything else looks pretty good…

For samples release, the following file is missing a source license header:

samples/osgi/wab-sample/pom.xml

Would be nice to delete the empty file samples/javaee6/singletonejb-javaee6/singletonejb-javaee6-war/src/main/java/org/apache/geronimo/samples/javaee6/singletonejb/sessionBeans/StatefulCalculator.java

So, here's my -1. 

Some additional files could be deleted, but not a problem, if they are not:

samples/javaee5/DataCDInfo/DataCDInfo-JTA-jetty/src/main/history/dependencies.added.xml
samples/javaee5/DataCDInfo/DataCDInfo-JTA-jetty/src/main/history/dependencies.removed.xml
samples/javaee5/DataCDInfo/DataCDInfo-JTA-jetty/src/main/history/treeListing.txt

I didn't see any other issues. I deleted maven-antrun-plugin from my local repo and my build
worked fine. But I didn't investigate… Perhaps my .m2/settings.xml configuration makes a
difference?

--kevan

On Nov 16, 2011, at 9:08 AM, viola lu wrote:

> Hi Devs,
> 
> Hi all,
> 
> A release candidate for Geronimo Sample & Daytrader  3.0-beta-1 has been created
and staged.
> 
> The tags have been created here:
> 
> https://svn.apache.org/repos/asf/geronimo/samples/tags/samples-parent-3.0-beta-1
> https://svn.apache.org/repos/asf/geronimo/daytrader/tags/daytrader-3.0-beta-1/
> 
> The staging repos is here:
> 
> https://repository.apache.org/content/repositories/orgapachegeronimo-197/
> 
> 
> The main artifacts up for vote are the source release archives:
> https://repository.apache.org/content/repositories/orgapachegeronimo-197/org/apache/geronimo/samples/samples-parent/3.0-beta-1/samples-parent-3.0-beta-1-source-release.tar.gz
> https://repository.apache.org/content/repositories/orgapachegeronimo-197/org/apache/geronimo/samples/samples-parent/3.0-beta-1/samples-parent-3.0-beta-1-source-release.zip
> 
> https://repository.apache.org/content/repositories/orgapachegeronimo-197/org/apache/geronimo/daytrader/daytrader-parent/3.0-beta-1/daytrader-parent-3.0-beta-1-source-release.tar.gz
> https://repository.apache.org/content/repositories/orgapachegeronimo-197/org/apache/geronimo/daytrader/daytrader-parent/3.0-beta-1/daytrader-parent-3.0-beta-1-source-release.zip
> 
> 
> 
> The vote will be open for the 72-hour minimum.
> 
> [  ] +1 about time to push this out the door
> [  ]  0 no opinion
> [  ] -1 not this one  (please explain why)
> 
> -- 
> viola
> 
> Apache Geronimo
> 


Mime
View raw message