Return-Path: X-Original-To: apmail-geronimo-dev-archive@www.apache.org Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1862B9AF8 for ; Fri, 23 Sep 2011 14:03:58 +0000 (UTC) Received: (qmail 74195 invoked by uid 500); 23 Sep 2011 14:03:57 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 74133 invoked by uid 500); 23 Sep 2011 14:03:57 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 74126 invoked by uid 99); 23 Sep 2011 14:03:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Sep 2011 14:03:57 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of hanhongfang@gmail.com designates 209.85.213.182 as permitted sender) Received: from [209.85.213.182] (HELO mail-yx0-f182.google.com) (209.85.213.182) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Sep 2011 14:03:49 +0000 Received: by yxk36 with SMTP id 36so3414044yxk.13 for ; Fri, 23 Sep 2011 07:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=C3UQ1VLKaxnJyS/Z3Bb5pD3rBSlGY4sBntm4UoKuUU4=; b=wrn5m0i5iTCGdBVMirhq/Rh1Gv0PQIh2Q9xmDcpvWvg893oHzQ0NgBuNvr0t6f/x66 oSzhhdZMu91J1Km5kVPCeE8tZBrYCdbqvLfCXwWso2NpGJpfko0W8cWL7SwHVNOeT704 dJgOkpVbmIDsI8GweboA5OpN04I+NsjQ2TaEk= MIME-Version: 1.0 Received: by 10.68.23.232 with SMTP id p8mr10393844pbf.0.1316786608425; Fri, 23 Sep 2011 07:03:28 -0700 (PDT) Received: by 10.68.56.3 with HTTP; Fri, 23 Sep 2011 07:03:28 -0700 (PDT) In-Reply-To: References: <4E779919.5050605@cait.org> <4E779F8A.1060208@kippdata.de> Date: Fri, 23 Sep 2011 22:03:28 +0800 Message-ID: Subject: Re: [Discussion] why does geronimo set org.apache.catalina.STRICT_SERVLET_COMPLIANCE=true? From: han hongfang To: dev@geronimo.apache.org Content-Type: multipart/alternative; boundary=bcaec52154f10a4bec04ad9c46b7 X-Virus-Checked: Checked by ClamAV on apache.org --bcaec52154f10a4bec04ad9c46b7 Content-Type: text/plain; charset=ISO-8859-1 Hi devs, Some update for this topic. I set org.apache.catalina.STRICT_SERVLET_COMPLIANCE=false (just as the default value in tomcat), and then run the servlet package of TCK, only two cases failed. http://tomcat.apache.org/tomcat-7.0-doc/config/systemprops.html#Specificationshows the value of org.apache.catalina.STRICT_SERVLET_COMPLIANCE has effect on several other properties. Looking into tomcat source code, most of the properties being effected take the value of org.apache.catalina.STRICT_SERVLET_COMPLIANCE only if these properties are NOT explicitly set. By setting the following properties as true, above-mentioned failed TCK cases pass as well. org.apache.catalina.core.ApplicationContext.GET_RESOURCE_REQUIRE_SLASH=true org.apache.catalina.core.ApplicationDispatcher.WRAP_SAME_OBJECT=true org.apache.catalina.core.StandardHostValve.ACCESS_SESSION=true org.apache.catalina.session.StandardSession.ACTIVITY_CHECK=true org.apache.catalina.session.StandardSession.LAST_ACCESS_AT_START=true I also tried in jetty v8.0.1.v20110908 and geronimo-jetty trunk, travel sample runs successfully. Both of them have no homepage access issue (i.e., 404 error). Any objection to set org.apache.catalina.STRICT_SERVLET_COMPLIANCE=false in geronimo tomcat? Best regards, Han Hong Fang (Janet) hanhongfang AT apache.org --bcaec52154f10a4bec04ad9c46b7 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi devs,

Some update for this topic.

I set org.apache.catalin= a.STRICT_SERVLET_COMPLIANCE=3Dfalse (just as the default value in tomcat), = and then run the servlet package of TCK, only two cases failed.

http://tomcat.apache.org/tomcat-7.0-doc/confi= g/systemprops.html#Specification shows the value of org.apache.catalina= .STRICT_SERVLET_COMPLIANCE has effect on several other properties. Looking = into tomcat source code, most of the properties being effected take the val= ue of org.apache.catalina.STRICT_SERVLET_COMPLIANCE only if these propertie= s are NOT explicitly set. By setting the following properties as true, abov= e-mentioned failed TCK cases pass as well.

org.apache.catalina.core.ApplicationContext.GET_RESOURCE_REQUIRE_SLASH= =3Dtrue
org.apache.catalina.core.ApplicationDispatcher.WRAP_SAME_OBJECT= =3Dtrue
org.apache.catalina.core.StandardHostValve.ACCESS_SESSION=3Dtru= e
org.apache.catalina.session.StandardSession.ACTIVITY_CHECK=3Dtrue
org.a= pache.catalina.session.StandardSession.LAST_ACCESS_AT_START=3Dtrue

I= also tried in jetty v8.0.1.v20110908 and geronimo-jetty trunk, travel samp= le runs successfully. Both of them have no homepage access issue (i.e., 404= error).

Any objection to set org.apache.catalina.STRICT_SERVLET_COMPLIANCE=3Dfa= lse in geronimo tomcat?

Best regards,

Han Hong Fang (Jan= et)
hanhongfang=A0AT apach= e.org
=A0

--bcaec52154f10a4bec04ad9c46b7--