geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shawn Jiang <genspr...@gmail.com>
Subject Re: svn commit: r1163516 - in /geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution: unix-shell/bin/geronimo windows-text/bin/geronimo.bat
Date Thu, 01 Sep 2011 07:46:48 GMT
It's a better idea :  ),   but I can see limited improvement comparing to
geronimo.sh/bat setting.

Because we'll need to fix this completely to make appclient work with
"searchWiredBundles=false" eventually.

On Thu, Sep 1, 2011 at 10:58 AM, Jarek Gawor <jgawor@gmail.com> wrote:

> I see. Thanks for explanation. In that case why not change the default
> to false and then set the property to true in client.sh/.bat?
>
> Jarek
>
> On Wed, Aug 31, 2011 at 9:29 PM, Shawn Jiang <genspring@gmail.com> wrote:
> > we are trying to add "-Dorg.apache.
> > xbean.osgi.bundle.util.BundleResourceHelper.searchWiredBundles=false"  to
> > improve the server startup and deploy performance.
> >
> > We found that appclient does not work with this added option.   If adding
> > this option into xbean code or in system.properties.     All of the
> > appclient tck will fail.    We don't have a quick fix for this and that's
> > the reason why we put the option to script to make it only apply to
> server
> > itself.
> >
> >
> > On Thu, Sep 1, 2011 at 1:23 AM, Jarek Gawor <jgawor@gmail.com> wrote:
> >>
> >> If you need to set this system property please put it in the
> >> etc/system.properties file instead of changing the scripts.
> >>
> >> Jarek
> >>
> >> On Wed, Aug 31, 2011 at 3:44 AM,  <genspring@apache.org> wrote:
> >> > Author: genspring
> >> > Date: Wed Aug 31 07:44:33 2011
> >> > New Revision: 1163516
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=1163516&view=rev
> >> > Log:
> >> > XBEAN-183/GERONIMO-6132 Disable wired bundles search by default.
> >> >
> >> > Setting this in geronimo script only to avoid appclient issue for now.
> >> >  The user can still use GERONIMO_OPTS to set it back to true when
> needed.
> >> >
> >> > Modified:
> >> >
> >> >
>  geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution/unix-shell/bin/geronimo
> >> >
> >> >
>  geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution/windows-text/bin/geronimo.bat
> >> >
> >> > Modified:
> >> >
> geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution/unix-shell/bin/geronimo
> >> > URL:
> >> >
> http://svn.apache.org/viewvc/geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution/unix-shell/bin/geronimo?rev=1163516&r1=1163515&r2=1163516&view=diff
> >> >
> >> >
> ==============================================================================
> >> > ---
> >> >
> geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution/unix-shell/bin/geronimo
> >> > (original)
> >> > +++
> >> >
> geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution/unix-shell/bin/geronimo
> >> > Wed Aug 31 07:44:33 2011
> >> > @@ -293,6 +293,8 @@ if [ "$1" = "jpda" ] ; then
> >> >   shift
> >> >  fi
> >> >
> >> >
> >> >
> +GERONIMO_OPTS="-Dorg.apache.xbean.osgi.bundle.util.BundleResourceHelper.searchWiredBundles=false
> >> > $GERONIMO_OPTS"
> >> > +
> >> >  if [ "$1" = "debug" ] ; then
> >> >   if $os400; then
> >> >     echo "Debug command not available on OS400"
> >> >
> >> > Modified:
> >> >
> geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution/windows-text/bin/geronimo.bat
> >> > URL:
> >> >
> http://svn.apache.org/viewvc/geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution/windows-text/bin/geronimo.bat?rev=1163516&r1=1163515&r2=1163516&view=diff
> >> >
> >> >
> ==============================================================================
> >> > ---
> >> >
> geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution/windows-text/bin/geronimo.bat
> >> > (original)
> >> > +++
> >> >
> geronimo/server/trunk/framework/configs/karaf-framework/src/main/distribution/windows-text/bin/geronimo.bat
> >> > Wed Aug 31 07:44:33 2011
> >> > @@ -355,11 +355,11 @@ cmd /c exit /b 0
> >> >
> >> >  @REM Execute Java with the applicable properties
> >> >  if not "%JDB%" == "" goto doJDB
> >> > -%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% %JAVA_AGENT_OPTS%
> >> > %CONSOLE_OPTS% -Dorg.apache.geronimo.home.dir="%GERONIMO_HOME%"
> >> >  -Dkaraf.home="%GERONIMO_HOME%" -Dkaraf.base="%GERONIMO_HOME%"
> >> >
> -Djava.util.logging.config.file="%GERONIMO_HOME%\etc\java.util.logging.properties"
> >> >
> -Djava.endorsed.dirs="%GERONIMO_HOME%\lib\endorsed;%JRE_HOME%\lib\endorsed"
> >> > -Djava.ext.dirs="%GERONIMO_HOME%\lib\ext;%JRE_HOME%\lib\ext"
> >> > -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath "%CLASSPATH%"
> %MAINCLASS%
> >> > %_LONG_OPT% %CMD_LINE_ARGS%
> >> > +%_EXECJAVA%
> >> >
> -Dorg.apache.xbean.osgi.bundle.util.BundleResourceHelper.searchWiredBundles=false
> >> > %JAVA_OPTS% %GERONIMO_OPTS% %JAVA_AGENT_OPTS% %CONSOLE_OPTS%
> >> > -Dorg.apache.geronimo.home.dir="%GERONIMO_HOME%"
> >> >  -Dkaraf.home="%GERONIMO_HOME%" -Dkaraf.base="%GERONIMO_HOME%"
> >> >
> -Djava.util.logging.config.file="%GERONIMO_HOME%\etc\java.util.logging.properties"
> >> >
> -Djava.endorsed.dirs="%GERONIMO_HOME%\lib\endorsed;%JRE_HOME%\lib\endorsed"
> >> > -Djava.ext.dirs="%GERONIMO_HOME%\lib\ext;%JRE_HOME%\lib\ext"
> >> > -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath "%CLASSPATH%"
> %MAINCLASS%
> >> > %_LONG_OPT% %CMD_LINE_ARGS%
> >> >  goto end
> >> >
> >> >  :doJDB
> >> > -%_EXECJAVA% %JAVA_OPTS% %GERONIMO_OPTS% %JAVA_AGENT_OPTS% -sourcepath
> >> > "%JDB_SRCPATH%" %CONSOLE_OPTS%
> >> > -Dorg.apache.geronimo.home.dir="%GERONIMO_HOME%"
> >> >  -Dkaraf.home="%GERONIMO_HOME%" -Dkaraf.base="%GERONIMO_HOME%"
> >> >
> -Djava.util.logging.config.file="%GERONIMO_HOME%\etc\java.util.logging.properties"
> >> >
> -Djava.endorsed.dirs="%GERONIMO_HOME%\lib\endorsed;%JRE_HOME%\lib\endorsed"
> >> > -Djava.ext.dirs="%GERONIMO_HOME%\lib\ext;%JRE_HOME%\lib\ext"
> >> > -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath "%CLASSPATH%"
> %MAINCLASS%
> >> > %CMD_LINE_ARGS%
> >> > +%_EXECJAVA%
> >> >
> -Dorg.apache.xbean.osgi.bundle.util.BundleResourceHelper.searchWiredBundles=false
> >> > %JAVA_OPTS% %GERONIMO_OPTS% %JAVA_AGENT_OPTS% -sourcepath
> "%JDB_SRCPATH%"
> >> > %CONSOLE_OPTS% -Dorg.apache.geronimo.home.dir="%GERONIMO_HOME%"
> >> >  -Dkaraf.home="%GERONIMO_HOME%" -Dkaraf.base="%GERONIMO_HOME%"
> >> >
> -Djava.util.logging.config.file="%GERONIMO_HOME%\etc\java.util.logging.properties"
> >> >
> -Djava.endorsed.dirs="%GERONIMO_HOME%\lib\endorsed;%JRE_HOME%\lib\endorsed"
> >> > -Djava.ext.dirs="%GERONIMO_HOME%\lib\ext;%JRE_HOME%\lib\ext"
> >> > -Djava.io.tmpdir="%GERONIMO_TMPDIR%" -classpath "%CLASSPATH%"
> %MAINCLASS%
> >> > %CMD_LINE_ARGS%
> >> >  goto end
> >> >
> >> >  :end
> >> >
> >> >
> >> >
> >
> >
> >
> > --
> > Shawn
> >
>



-- 
Shawn

Mime
View raw message