2011/8/12 David Jencks <david_jencks@yahoo.com&g= t;

I see that karaf is starting an obr s= ubproject, "cave", just added to the karaf sandbox. =A0Can you te= ll how similar this is to your goals?

http://svn.apache.org/repos/asf/karaf/sandbox/jbonofre/cave/trunk/<= /div>

I haven't had time to look into your proposal yet. = =A0I have one question, how do you figure out maven coordinates in the gero= nimo repository for a bundle that only has a symbolic name?

The current install-library command use the following logic to cal= culate artifact:
The default groupId is "default"
(1) the f= ile name has the following form:<artifact>-<version>.<type&g= t;;, for e.g. mylib-1.0.jar;<br/>
(2) or the file is an OSGi bundle, then the artifactId is its Bundle-Symbol= icName and the version is its Bundle-Version;

After user install an= osgi bundle to geronimo repo, the obr gbean's refresh() can re-generat= e obr.xml for all the artifacts in geronimo repo.

Then use Xiao Yi's obr:geronimo-uninstall symbolicName,version <= /b>cli can install and "persist" the bundle and all its dependenc= ies.

Could this answer your question?

-Rex

thanks
david jencks

On Aug 11, 2011, at 3:15 AM, Yi Xiao wrote:

Hi Jark, I'v seen your comments in 5939 and reference= here for convenience
----------------------------------------------= ----------------------------

1) Don't forget about the license headers.
2) The geronimo-addUrl shell command and related code is unnecessary. There= is already obr:addurl operation.
3) When doing geronimo-install would be good to also specify whether the optional resources should also be downloaded and installed.
4) Can't ThreadPool be injected into ObrBundleInstallerGBean just like = the repository is (instead of doing Kernel lookup)?
5) GeronimoGBean could also be injected instead of doing OSGi service looku= p.
6) You shouldn't need to add LOCAL_OBR into repository. That's what= GeronimoOBRGBean does already.
7) The filter created in ObrUtils.searchRepository() essentially=20 specifies to find a bundle with the given symbolic name and the minimal version. That is, for example, the user specified foo,1.0 but the=20 install might result in installing foo,2.0. I think we want to match the exact version. Or maybe we want to support version ranges.
8) The way the code currently decides whether the resource is "local&q= uot; or not is not very reliable. So we might need to find another way or=20 improve Felix OBR.
---------------------------------------= -----------------------------------

1) I will add the= license headers
2) I think the geronimo-addurl command should re= cord the urls into a file, and geronimo-obr will read the urls and add them= so I write the command, however, I don't decide which file to write an= d read, do you think we need to record the urls?

3) Do you mean the "optional resources" is the dependencies = of the target bundle or something else?
4), 5), 6) I will resolve= it
7) I've test the scenario you described and there is no s= uch confusion. However, I think support the version ranges is a good idea!<= /div>
8) Now the "local" resources are the ones whose url start wi= th "mvn:". The implementation is: When install a bundle, if the b= undle is local, will verify its existence, if not existed, will throw an ex= ception; If the bundle is remote, just download it and install it into gero= nimo repository.

On Thu, Aug 11, 2011 at 1:23 PM, Jarek = Gawor <jgawor@gmail.com> wrote:
There is already obr:addurl command so obr:geronimo-addurl is
unnecessary. I added all my comments to GERONIMO-5939.

Jarek

On Wed, Aug 10, 2011 at 10:24 PM, Yi Xiao <xiaoyijhondevelop@gmail.com> wro= te:
> Hi devs,
>
> Now, I want to add the support of OSGi bundle repository in Geronimo3.= 0, the
> patch is available at: https://issues.apache.org/jira/browse/GE= RONIMO-5939
> I used Felix's OBR APIs to develop and add=A0 THREE karaf shells t= o control
> the OBR in geronimo:
>
> 1 obr:geronimo-addurl url
> Add a remote repository to the geronimo's repositoryAdmin.
>
> 2 obr:geronimo-install [--start | --startLevel num | -v]
> symbolicName,version
> Install a bundle into geronimo in OBR way.
> first, resolve the bundle, if resolve failed, return directly and prin= t the
> unsatisfactory conditions to user;
> second, download the bundle and its dependencies from the remote sites= to
> local;
> third, deploy all the bundles into geronimo repository and install the= m into
> OSGi framework;
> finally, update the geronimo's obr.xml file.
>
> 3 obr:geronimo-uninstall symbolicName,version
> Uninstall a bundle from geronimo in OBR way.
> Compared with the osgi:uninstall, the OBR's uninstall will clean u= p the
> geronimo's repository and startup.properties file, also update the= obr.xml
> file.
>
> Any suggestions ?
>
> --
> Best regards!
>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0John Xiao
>

--
Best regard= s!

=A0=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0John Xiao
=