Return-Path: X-Original-To: apmail-geronimo-dev-archive@www.apache.org Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 513287630 for ; Sat, 20 Aug 2011 00:27:42 +0000 (UTC) Received: (qmail 27086 invoked by uid 500); 20 Aug 2011 00:27:41 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 26780 invoked by uid 500); 20 Aug 2011 00:27:40 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 26766 invoked by uid 99); 20 Aug 2011 00:27:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 Aug 2011 00:27:39 +0000 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [98.136.44.63] (HELO smtp108.prem.mail.sp1.yahoo.com) (98.136.44.63) by apache.org (qpsmtpd/0.29) with SMTP; Sat, 20 Aug 2011 00:27:31 +0000 Received: (qmail 27122 invoked from network); 20 Aug 2011 00:27:09 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=DKIM-Signature:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; b=aHng63iky52P41JMrE7e/F7ELxQ3Q4iiBBVwfeiw5VXASz5W/9nezSmBIq621e9+LbAbUk/FFN5dYipp75ZhbbshvEBwv9m++bV+PjJd0EkuUyWvN9xtKPXGFEc1gRfGcOnt6AYS8Hsm/N3pYBGw1GA8BxSnjD6FH9VKn10zcpo= ; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1313800029; bh=SMfZxUWzpZRGYuLVWUr9jhUPWdb8qc/JA+82hYmJTOk=; h=X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; b=iUi8k+JOmZcE96WISf42+h2nm9CtbKabJD5/HI7uNiFRzD1N9q1sa739CiBxfuzLEcqLs+4VvKb3NQzdxbBG5oa911fSJy/nyuKbMWQZnyqj86GdYE+1/DVk6Kaa/uTDr4RL05SbitipzvqNcWWbO118sKmxTcd4ToMSdzbQ74g= X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 0N.QNoQVM1l0zKzKpCpTiQNrc21LQsYXPhxJy1cXHpyDWqJ AleCd8d7HxB51ZKQXBfY2z1q86tmEk2GXnroRQuhKBFc_gUIlc7IKPiyikw4 nSi8k7zyjzoqzwYP5Nr5Q1afuhzoPAnDvxRIYnquHL.Qnlm9rY6s81T22L2c l4fkerEELefDVq70GfxB0bhOgdWrruEiC5K6kLKE33pxj7HbR_JSHN2LTc3. fzfzaYoQZ.W3zTcgdofMer2xNmILjFTr0OA4syPWrUcOfpvFe6JaadFv8_Wy TRHE63_3f8FAZ1QFB0sQ8KhoeNEl1pjmwW77Xhd3TjCvz4A0ukJTdYUal7Yw uMiKdhnApHZJGvEDavshQJMGVmPXb8bJ7CR06FZzLfSibcMlUwqossb1Jl9Q a7wpRwFbJLP6YdxUiURQ25ZDgmaWpz1PNuTpESyDswAN2hOOOHfqUGspfEHh 7WYTMHLumnFTTqJWATJV1PAw7JMCN X-Yahoo-SMTP: .9oIUzyswBANsYgUm_5uPui0skTnzGJXJQ-- Received: from [10.0.1.4] (david_jencks@76.76.148.215 with plain) by smtp108.prem.mail.sp1.yahoo.com with SMTP; 19 Aug 2011 17:27:09 -0700 PDT Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1084) Subject: Re: svn commit: r1096951 [6/6] - in /geronimo/server/trunk: ./ framework/ framework/assemblies/ framework/assemblies/geronimo-framework/ framework/buildsupport/car-maven-plugin/src/main/filtered-resources/resources/etc/ framework/buildsupport/car-maven-plu... From: David Jencks In-Reply-To: Date: Fri, 19 Aug 2011 17:27:08 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <72B25D1B-635D-4B46-B441-2FF2CF6FA3B3@yahoo.com> References: <20110426231902.894842388B34@eris.apache.org> To: dev@geronimo.apache.org X-Mailer: Apple Mail (2.1084) X-Virus-Checked: Checked by ClamAV on apache.org I'm not sure how this got removed, but this is in what turned into the = 3.0-osgi branch, not current trunk. I guess I should investigate since = I've been working with that code some more.... david jencks On Aug 19, 2011, at 4:50 PM, David Blevins wrote: > David, >=20 > Any info on why this was removed? Guessing it was just a side effect = of a merge. >=20 > (related jira https://issues.apache.org/jira/browse/GERONIMO-5888) >=20 >=20 > -David >=20 > On Apr 26, 2011, at 4:19 PM, djencks@apache.org wrote: >=20 >> Modified: = geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/= apache/geronimo/kernel/util/FileUtils.java >> URL: = http://svn.apache.org/viewvc/geronimo/server/trunk/framework/modules/geron= imo-kernel/src/main/java/org/apache/geronimo/kernel/util/FileUtils.java?re= v=3D1096951&r1=3D1096950&r2=3D1096951&view=3Ddiff >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- = geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/= apache/geronimo/kernel/util/FileUtils.java (original) >> +++ = geronimo/server/trunk/framework/modules/geronimo-kernel/src/main/java/org/= apache/geronimo/kernel/util/FileUtils.java Tue Apr 26 23:18:49 2011 >> @@ -30,7 +30,6 @@ import java.io.OutputStream; >> import java.io.OutputStreamWriter; >> import java.net.MalformedURLException; >> import java.net.URL; >> -import java.util.ArrayList; >> import java.util.Collection; >> import java.util.Collections; >> import java.util.Enumeration; >> @@ -38,7 +37,6 @@ import java.util.HashMap; >> import java.util.LinkedHashMap; >> import java.util.LinkedHashSet; >> import java.util.LinkedList; >> -import java.util.List; >> import java.util.Map; >> import java.util.Set; >> import java.util.jar.JarFile; >> @@ -83,7 +81,6 @@ public class FileUtils { >> File tempDir =3D File.createTempFile("geronimo-fileutils", = ".tmpdir"); >> tempDir.delete(); >> tempDir.mkdirs(); >> - deleteOnExit(tempDir); >> return tempDir; >> } >>=20 >> @@ -412,37 +409,4 @@ public class FileUtils { >>=20 >> private FileUtils() { >> } >> - >> - // Shutdown hook for recurssive delete on tmp directories >> - static final List delete =3D new ArrayList(); >> - >> - static { >> - Runtime.getRuntime().addShutdownHook(new Thread(){ >> - @Override >> - public void run() { >> - delete(); >> - } >> - }); >> - } >> - >> - private static void deleteOnExit(File file) { >> - delete.add(file.getAbsolutePath()); >> - } >> - >> - private static void delete() { >> - for (String path : delete) { >> - delete(new File(path)); >> - } >> - } >> - >> - private static void delete(File file) { >> - if (file.isDirectory()) { >> - for (File f : file.listFiles()) { >> - delete(f); >> - } >> - } >> - >> - file.delete(); >> - } >> - >> } >>=20 >=20