Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Date: Wed, 31 Aug 2011 04:17:09 +0000 (UTC)
From: "David Jencks (JIRA)" <jira@apache.org>
To: dev@geronimo.apache.org
Message-ID: 
 <2020677359.1297.1314764229888.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <591780371.6615.1314692797706.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (GERONIMO-6133) The name of
 NamedXAResourceFactory is not configured while working with DataSource
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/GERONIMO-6133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094295#comment-13094295 ] 

David Jencks commented on GERONIMO-6133:
----------------------------------------

This fix looks good to me.  I think I would save the resource name as a string rather than as an AbstractName since the recovery code thinks in terms of string names.  However this is a very very minor point.

> The name of NamedXAResourceFactory is not configured while working with DataSource
> ----------------------------------------------------------------------------------
>
>                 Key: GERONIMO-6133
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6133
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: connector
>    Affects Versions: 3.0
>            Reporter: Ivan
>            Assignee: Ivan
>             Fix For: 3.0
>
>
> The exception could be reproduced with the testsuite\javaee6-testsuite\jta1.1-test sample.
> 2011-08-30 14:28:52,421 INFO  [Holder] Could not look up comp/env/org.apache.geronimo.sample.servlet.SHAcc/dataSourcenTx
> javax.naming.NamingException: SHAccTx [Root exception is java.lang.NullPointerException]
> 	at org.apache.xbean.naming.context.ContextUtil.resolve(ContextUtil.java:78)
> 	at org.apache.xbean.naming.context.ContextUtil$ReadOnlyBinding.getObject(ContextUtil.java:199)
> 	at org.apache.xbean.naming.context.ContextFederation.getFederatedBindings(ContextFederation.java:119)
> 	at org.apache.xbean.naming.context.AbstractFederatedContext.getBindings(AbstractFederatedContext.java:99)
> 	at org.apache.xbean.naming.context.AbstractFederatedContext.getBinding(AbstractFederatedContext.java:86)
> 	at org.apache.xbean.naming.context.AbstractContext.lookup(AbstractContext.java:133)
> 	at org.apache.xbean.naming.context.AbstractContext.lookup(AbstractContext.java:605)
> 	at org.apache.geronimo.naming.java.RootContext.lookup(RootContext.java:63)
> 	at org.apache.aries.jndi.DelegateContext.lookup(DelegateContext.java:161)
> 	at javax.naming.InitialContext.lookup(InitialContext.java:392)
> 	at org.apache.geronimo.naming.reference.JndiReference.getContent(JndiReference.java:53)
> 	at org.apache.xbean.naming.context.ContextUtil.resolve(ContextUtil.java:61)
> 	at org.apache.xbean.naming.context.AbstractContext.lookup(AbstractContext.java:116)
> 	at org.apache.xbean.naming.context.AbstractContext.lookup(AbstractContext.java:619)
> 	at org.apache.xbean.naming.context.AbstractContext.lookup(AbstractContext.java:156)
> 	at org.apache.xbean.naming.context.AbstractContext.lookup(AbstractContext.java:619)
> 	at org.apache.xbean.naming.context.AbstractContext.lookup(AbstractContext.java:156)
> 	at org.apache.xbean.naming.context.AbstractContext.lookup(AbstractContext.java:605)
> 	at org.apache.geronimo.j2ee.annotation.Holder.addInjections(Holder.java:207)
> 	at org.apache.geronimo.j2ee.annotation.Holder.newInstance(Holder.java:170)
> 	at org.apache.geronimo.tomcat.TomcatInstanceManager.newInstance(TomcatInstanceManager.java:74)
> 	at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1087)
> 	at org.apache.catalina.core.StandardWrapper.allocate(StandardWrapper.java:824)
> 	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:135)
> 	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:175)
> 	at org.apache.geronimo.tomcat.GeronimoStandardContext$SystemMethodValve.invoke(GeronimoStandardContext.java:818)
> 	at org.apache.geronimo.tomcat.valve.GeronimoBeforeAfterValve.invoke(GeronimoBeforeAfterValve.java:48)
> 	at org.apache.geronimo.tomcat.valve.ProtectedTargetValve.invoke(ProtectedTargetValve.java:53)
> 	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:164)
> 	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
> 	at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:851)
> 	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
> 	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:405)
> 	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:278)
> 	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:515)
> 	at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:300)
> 	at org.apache.geronimo.pool.ThreadPool$1.run(ThreadPool.java:243)
> 	at org.apache.geronimo.pool.ThreadPool$ContextClassLoaderRunnable.run(ThreadPool.java:373)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:662)
> Caused by: java.lang.NullPointerException
> 	at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:882)
> 	at org.apache.geronimo.transaction.manager.TransactionManagerImpl.registerNamedXAResourceFactory(TransactionManagerImpl.java:352)
> 	at org.apache.geronimo.connector.outbound.AbstractConnectionManager.doRecovery(AbstractConnectionManager.java:69)
> 	at org.apache.geronimo.datasource.DataSourceService.<init>(DataSourceService.java:124)
> 	at org.apache.geronimo.datasource.DataSourceGBeanObjectFactory.getObjectInstance(DataSourceGBeanObjectFactory.java:82)
> 	at org.apache.aries.jndi.ObjectFactoryHelper.getObjectInstanceUsingClassName(ObjectFactoryHelper.java:208)
> 	at org.apache.aries.jndi.ObjectFactoryHelper.doGetObjectInstance(ObjectFactoryHelper.java:80)
> 	at org.apache.aries.jndi.ObjectFactoryHelper.access$000(ObjectFactoryHelper.java:40)
> 	at org.apache.aries.jndi.ObjectFactoryHelper$1.run(ObjectFactoryHelper.java:56)
> 	at java.security.AccessController.doPrivileged(Native Method)
> 	at org.apache.aries.jndi.Utils.doPrivileged(Utils.java:146)
> 	at org.apache.aries.jndi.ObjectFactoryHelper.getObjectInstance(ObjectFactoryHelper.java:54)
> 	at org.apache.aries.jndi.OSGiObjectFactoryBuilder.getObjectInstance(OSGiObjectFactoryBuilder.java:57)
> 	at javax.naming.spi.NamingManager.getObjectInstance(NamingManager.java:283)
> 	at org.apache.xbean.naming.context.ContextUtil.resolve(ContextUtil.java:74)
> 	... 40 more

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira