geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Gawor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GERONIMO-5939) Support OBR resolution during bundle install
Date Thu, 11 Aug 2011 05:21:27 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082923#comment-13082923
] 

Jarek Gawor commented on GERONIMO-5939:
---------------------------------------

A few comments:

1) Don't forget about the license headers.
2) The geronimo-addUrl shell command and related code is unnecessary. There is already obr:addurl
operation. 
3) When doing geronimo-install would be good to also specify whether the optional resources
should also be downloaded and installed.
4) Can't ThreadPool be injected into ObrBundleInstallerGBean just like the repository is (instead
of doing Kernel lookup)?
5) GeronimoGBean could also be injected instead of doing OSGi service lookup.
6) You shouldn't need to add LOCAL_OBR into repository. That's what GeronimoOBRGBean does
already.
7) The filter created in ObrUtils.searchRepository() essentially specifies to find a bundle
with the given symbolic name and the _minimal_ version. That is, for example, the user specified
foo,1.0 but the install might result in installing foo,2.0. I think we want to match the _exact_
version. Or maybe we want to support version ranges.
8) The way the code currently decides whether the resource is "local" or not is not very reliable.
So we might need to find another way or improve Felix OBR.




> Support OBR resolution during bundle install
> --------------------------------------------
>
>                 Key: GERONIMO-5939
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5939
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: deployment, osgi
>    Affects Versions: 3.0-M1
>            Reporter: Jarek Gawor
>            Assignee: Rex Wang
>         Attachments: GERONIMO-5939-core.patch, GERONIMO_5939_core_modify.patch, GeronimoOBR_5939.patch
>
>
> When installing an individual bundle (via the admin console, command line or shell) provide
an option to perform OBR resolution to install the dependent bundles.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message