Return-Path: X-Original-To: apmail-geronimo-dev-archive@www.apache.org Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E99A164DB for ; Fri, 15 Jul 2011 19:57:47 +0000 (UTC) Received: (qmail 94283 invoked by uid 500); 15 Jul 2011 19:57:47 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 94038 invoked by uid 500); 15 Jul 2011 19:57:46 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 94028 invoked by uid 99); 15 Jul 2011 19:57:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2011 19:57:46 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of david.blevins@gmail.com designates 209.85.210.44 as permitted sender) Received: from [209.85.210.44] (HELO mail-pz0-f44.google.com) (209.85.210.44) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jul 2011 19:57:37 +0000 Received: by pzk5 with SMTP id 5so2157416pzk.31 for ; Fri, 15 Jul 2011 12:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=content-type:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to:x-mailer; bh=tlxWGWmiWg0ItkjnMgVHV6pULAHDQQPGRUpKKB84fss=; b=Bw0sMEU9McuitCxsv6iySQL9kRpgkLW20bo80KBvOEtckc0Wjex2ZJZS2TREB/6leN 9BNzRh4HoqWPdli0OVK6mgNUR7xZfMARZQNdwZTOHDnfwxz49N0eajGdnmn0fw4u0IjS cMPPoC2WdymG630rXXgECi12rnMQnlKALgvcM= Received: by 10.68.52.133 with SMTP id t5mr4561801pbo.303.1310759836162; Fri, 15 Jul 2011 12:57:16 -0700 (PDT) Received: from [192.168.0.2] (cpe-76-175-195-209.socal.res.rr.com [76.175.195.209]) by mx.google.com with ESMTPS id u6sm801745pbh.32.2011.07.15.12.57.14 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 15 Jul 2011 12:57:14 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1084) Subject: Re: less-osgi-friendly code drop From: David Blevins In-Reply-To: Date: Fri, 15 Jul 2011 12:57:13 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <7ACC70A7-1BC3-4F66-BF7F-C737AFBF37AB@gmail.com> References: <22C962B6-B4EE-42C3-946F-C7AE5EFC4FC2@yahoo.com> <01983B55-4A2B-44C2-B333-179FC235C6A7@gmail.com> To: dev@geronimo.apache.org X-Mailer: Apple Mail (2.1084) X-Virus-Checked: Checked by ClamAV on apache.org On Jul 13, 2011, at 10:10 PM, David Jencks wrote: >=20 > On Jul 13, 2011, at 9:46 PM, David Blevins wrote: >=20 >>=20 >> On Jul 11, 2011, at 12:54 AM, David Jencks wrote: >>=20 >>> = testSpecializedBeanNotInstantiated(org.jboss.jsr299.tck.tests.inheritance.= specialization.enterprise.EnterpriseBeanSpecializationIntegrationTest) >>> = testSpecializingBeanHasBindingsOfSpecializedAndSpecializingBean(org.jboss.= jsr299.tck.tests.inheritance.specialization.enterprise.EnterpriseBeanSpeci= alizationTest) >>> = testSpecializingBeanHasNameOfSpecializedBean(org.jboss.jsr299.tck.tests.in= heritance.specialization.enterprise.EnterpriseBeanSpecializationTest) >>> = testSpecializingClassDirectlyExtendsNothing(org.jboss.jsr299.tck.tests.inh= eritance.specialization.enterprise.broken.directlyExtendsNothing.DirectlyE= xtendsNothingTest) >>> = testSpecializingClassDirectlyExtendsSimpleBean(org.jboss.jsr299.tck.tests.= inheritance.specialization.enterprise.broken.directlyExtendsSimpleBean.Dir= ectlyExtendsSimpleBeanTest) >>> = testSpecializingClassImplementsInterfaceAndExtendsNothing(org.jboss.jsr299= .tck.tests.inheritance.specialization.enterprise.broken.implementInterface= AndExtendsNothing.ImplementsInterfaceAndExtendsNothingTest) >>> = testSpecializingAndSpecializedBeanHasName(org.jboss.jsr299.tck.tests.inher= itance.specialization.enterprise.broken.sameName.SameNameTest) >>=20 >> Have all but 3 of these passing in the embedded container in my local = copy. The 3 that fail are "broken" ones. Simply need to add validation = for those. My impl code is a bit hacked -- currently only works for = @Stateful and not exactly implemented in the right spot -- but otherwise = looks like a good approach. Will clean it up and check it in tomorrow. >>=20 >>=20 >=20 > Excellent! On the geronimo side I've changed things around so that we = have one openejb appInfo tree for the entire application and use it to = set up the owb context. This _ought_ to fix the problem in g. that I = was seeing that the owb context didn't include any of the specialized = classes (since it was looking at only one of the modules in the ear). = However I'm still cleaning up loose ends so apps will deploy ok :-) Checked in my specialization code to OWB and OpenEJB. It fixes things = in the embedded container (sans the three 'broken' tests). Still seeing = them fail in G though. Hacking up the validation logic for the 'broken' tests now. -David