Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (athena.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=DKIM-Signature:Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer;
  b=TesnXXnqdWT4hXtPM3TpD6IMk46o6Ojb6IuuU9sTdLTvDqPjwYXoYP/2d0iiYmrWd+DuHWSL74B5sMZglVVZuUAVeVcmAO8hSLUSecziwCSjTqEwnyijYGuADrKh507HwpWgQH7DIkkbNHbvbkH1k5BQL5Bp3g9/aeL5IlXt39w=
  ;
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1084)
Subject: Re: Replace StringBuffer with StringBuilder in trunk ?
From: David Jencks <david_jencks@yahoo.com>
In-Reply-To: 
 <CALS1ypCB0A4-PTeczr4D8acCMBVLiSJ4zA_3MXCgaL6QAMEHMQ@mail.gmail.com>
Date: Thu, 7 Jul 2011 23:39:27 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <5A80BFE9-87FF-4E10-AF2C-30DEE636F98C@yahoo.com>
References: 
 <CALS1ypCB0A4-PTeczr4D8acCMBVLiSJ4zA_3MXCgaL6QAMEHMQ@mail.gmail.com>
To: dev@geronimo.apache.org

I have no objection, but I think I read that the compiler does some =
analysis and replaces use of StringBuffer that it can prove is only =
accessed by a single thread, by StringBuilder.  So I think this will =
only increase our code clarity, not the speed.

And you should make sure all the string buffers are really used only by =
one thread :-) -- the part that will take some time....

thanks
david jencks

On Jul 7, 2011, at 11:27 PM, Ivan wrote:

> Hi, I am thinking to replace all the StringBuffer with StringBuilder =
in the trunk codes, since it requires JRE 1.6. I knew that it might not =
bring us too much performance improvement, while half loaf is better =
than no bread. WDYT ?
>=20
> --=20
> Ivan