geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Gawor (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GERONIMODEVTOOLS-764) Control the OSGI bundle's start level in GEP
Date Fri, 15 Jul 2011 15:50:03 GMT

    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066029#comment-13066029
] 

Jarek Gawor commented on GERONIMODEVTOOLS-764:
----------------------------------------------

A few comments:

1) Make sure you configure your editor to use spaces instead of tabs (per our coding standards).

2) I'm confused about setting the default start level. It looks like the user can set the
default start level in the server configuration in Eclipse but the code also looks up the
default start level from the server. And changing the level in Eclipse won't be saved in the
server configuration. So I think we have a few options: 1) Eclipse shouldn't be allowed the
change the default start level at all or 2) If the default start level is changed in Eclipse
it should save the server configuration as well, or 3) make the default start level in Eclipse
completely separate from the server's (and be persistent between Eclipse restarts).
Right now I think my preference would be for option #3.

3) Don't modify the AriesHelper.BundleInfo. BundleInfo was supposed to be somewhat private
to AriesHelper class. Instead maybe rename AriesHelper.BundleInfo to AriesHelper.ProjectInfo
(or something like that) and create your own BundleInfo for the OSGiModuleHadler purposes.

4) Don't forget about the Apache headers for the new files.


> Control the OSGI bundle's start level in GEP
> --------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-764
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-764
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 3.0
>         Environment: WinXP sp3 32bit& Win7 64bit, Oracle JDK 1.6, Eclipse3.6SR1&SR2

>            Reporter: Yi Xiao
>            Assignee: Yi Xiao
>              Labels: OSGI, startLevel
>             Fix For: 3.0
>
>         Attachments: controlBundleStartLevel_764.patch, defaultStartLevel.jpg, singleStartLevel.jpg
>
>
> 1 Provide a UI interface to control all the bundles' start level
> 2 Control the specific bundle's start level easily

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message