Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (athena.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=DKIM-Signature:Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer;
  b=MrAV5FvwmBJ/WIVmyL8oW/DoEgWmSpJ5Py7emvl1gUSaxaiLbR+mrD354ZV2dj/hHA8XkBCsYmX41f/5xtR0HjyEcnF//DiHL2YEJfPmw6dOgootQgxGeJZOHp+wsneqEj4w9u1AB/RYxss8MiQqLotFZah68Lot+gkDXX2XtaU=
  ;
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1084)
Subject: Re: ActiveMQ config-substitution change G2.2 vs G3.0
From: David Jencks <david_jencks@yahoo.com>
In-Reply-To: <4DE91B0D.9060806@cait.org>
Date: Fri, 3 Jun 2011 11:11:27 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <7E63E3D8-0C84-486E-AB05-0DBD9C2F005F@yahoo.com>
References: <4DE91B0D.9060806@cait.org>
To: dev@geronimo.apache.org

Hi Russell,

thanks for looking into this in such detail :-)

When I worked on the blueprint and xbean-blueprint conversion I couldn't =
figure out how to do this.  Since then I've started thinking that it =
would make more sense to configure activemq with Declarative Services =
rather than blueprint and configure the variable bits such as transports =
with the feature that produces a service for every Config Admin =
configuration (I get lost in the terminology, I think this is a managed =
service factory).  However I haven't had any time to look into this.

not much help but that's where my thinking is at the moment.

david jencks

On Jun 3, 2011, at 10:34 AM, Russell E Glaue wrote:

> ActiveMQ is not utilizing the config-substitutions in G3.0
> A patch was put in G2.2 do handle this, but the related code is =
removed in G3.0.
> ActiveMQ is changed in the process of integrating blueprint. See =
GERONIMO-4475
> for the G2.2 patches from Ivan.
>=20
> Since the GeronimoPropertyPlaceholderConfigurer in G2.2 was to make =
ActiveMQ use
> the config-substitution, and now is removed in G3.0, I do not see in =
the code
> where the config-substitution is accounted for.
>=20
>=20
> In G2.2.2-SNAPSHOT
> The GBean Class:
> =
~/branches/2.2/plugins/activemq/geronimo-activemq/src/main/java/org/apache=
/geronimo/activemq/GeronimoPropertyPlaceholderConfigurer.java
> The GBean Configuration:
> =
~/branches/2.2/plugins/activemq/activemq-broker/src/main/resources/activem=
q.xml
> -
>    <!-- Allows us to use system properties as variables in this =
configuration
> file-->
>    <bean
> =
class=3D"org.apache.geronimo.activemq.GeronimoPropertyPlaceholderConfigure=
r">
>         <property name=3D"locations">
>=20
> =
<!--<value>file://${activemq.home}/conf/credentials.properties</value>-->
>=20
> =
<value>${activemq.geronimo.home.url}/var/config/config-substitutions.prope=
rties</value>
>         </property>
>         <property name=3D"systemPropertiesMode">
>            <value>2</value>
>         </property>
>    </bean>
> -
>=20
> In G3.0-SNAPSHOT
> =
~/trunk/plugins/activemq/activemq-broker-blueprint/src/main/resources/OSGI=
-INF/blueprint/activemq.xml
> -
>    <cm:property-placeholder id=3D"property-placeholder"
> persistent-id=3D"blueprint-activemq-placeholder" =
placeholder-prefix=3D"${"
> placeholder-suffix=3D"}" ignore-missing-locations=3D"true">
>        <cm:default-properties>
>            <cm:property name=3D"activemq.brokerName" =
value=3D"DefaultActiveMQBroker"/>
>            <cm:property name=3D"activemq.data" value=3D"var/activemq"/>
>            <cm:property name=3D"serverHostname" value=3D"localhost"/>
>            <cm:property name=3D"activemq.port" value=3D"61616"/>
>            <cm:property name=3D"portOffset" value=3D"0"/>
>        </cm:default-properties>
>=20
> =
<cm:location>file:$(karaf.base)/etc/blueprint-activemq-placeholder.cfg</cm=
:location>
>    </cm:property-placeholder>
> -
> As I mentioned in a previous thread on the user list, the
> file:$(karaf.base)/etc/blueprint-activemq-placeholder.cfg is ignored. =
I tried to
> change the ActiveMQ values there in
> GERONIMO_HOME/etc/blueprint-activemq-placeholder.cfg, but ActiveMQ did =
not use
> the new configuration I set.
> (I am testing with G3.0-20110603-snapshot)
>=20
> So the question is, what has to be done in G3.0-SNAPSHOT to make =
ActiveMQ apply
> settings from the config-substitutions file?
>=20
> -RG