Return-Path: X-Original-To: apmail-geronimo-dev-archive@www.apache.org Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF1C766B2 for ; Tue, 28 Jun 2011 04:50:47 +0000 (UTC) Received: (qmail 96347 invoked by uid 500); 28 Jun 2011 04:50:47 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 95962 invoked by uid 500); 28 Jun 2011 04:50:39 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 95941 invoked by uid 99); 28 Jun 2011 04:50:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jun 2011 04:50:38 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Jun 2011 04:50:37 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 3F02C4352E8 for ; Tue, 28 Jun 2011 04:50:17 +0000 (UTC) Date: Tue, 28 Jun 2011 04:50:17 +0000 (UTC) From: "Rex Wang (JIRA)" To: dev@geronimo.apache.org Message-ID: <1923537474.670.1309236617254.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <481991265.44924.1309210247350.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (GERONIMO-6025) Validate that servlet and filter mapping url-patterns don't have internal line breaks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GERONIMO-6025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rex Wang updated GERONIMO-6025: ------------------------------- Attachment: GERONIMO-6025-central-validation.patch Hi, David, Just loaded a patch(GERONIMO-6025-central-validation.patch) to make the validation happen in a single place. I found we have WebDeploymentValidationUtils before, so use it. Is that ok? btw, JspPropertyGroup also have a url-pattern prop need TrimStringAdapter... Really appreciate you could help this issue. thanks. > Validate that servlet and filter mapping url-patterns don't have internal line breaks > ------------------------------------------------------------------------------------- > > Key: GERONIMO-6025 > URL: https://issues.apache.org/jira/browse/GERONIMO-6025 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: web > Affects Versions: 3.0 > Reporter: David Jencks > Assignee: David Jencks > Fix For: 3.0 > > Attachments: GERONIMO-6025-central-validation.patch > > > they aren't supposed to allow internal line breaks, we need to check. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira