Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 13845 invoked from network); 3 Dec 2010 21:04:36 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 3 Dec 2010 21:04:36 -0000 Received: (qmail 99935 invoked by uid 500); 3 Dec 2010 21:04:35 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 99895 invoked by uid 500); 3 Dec 2010 21:04:35 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 99888 invoked by uid 99); 3 Dec 2010 21:04:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Dec 2010 21:04:35 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Dec 2010 21:04:32 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oB3L4AkJ002153 for ; Fri, 3 Dec 2010 21:04:11 GMT Message-ID: <29596173.100631291410250660.JavaMail.jira@thor> Date: Fri, 3 Dec 2010 16:04:10 -0500 (EST) From: "Jarek Gawor (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Resolved: (GERONIMO-5673) ModuleMojoSupport ignores stopOnFailure In-Reply-To: <8768080.223491288808428703.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/GERONIMO-5673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Gawor resolved GERONIMO-5673. ----------------------------------- Resolution: Fixed Fix Version/s: 3.0-M2 2.1.8 > ModuleMojoSupport ignores stopOnFailure > --------------------------------------- > > Key: GERONIMO-5673 > URL: https://issues.apache.org/jira/browse/GERONIMO-5673 > Project: Geronimo > Issue Type: Bug > Security Level: public(Regular issues) > Components: geronimo-maven-plugin > Affects Versions: 2.2.1, 2.2.2 > Environment: OS X 10.6.4, Java 1.6.0_20, Maven 2.2.1 > Reporter: Trygve Sanne Hardersen > Assignee: Jarek Gawor > Fix For: 2.1.8, 2.2.2, 3.0-M2 > > Attachments: geronimo-2.2-1030330-stopOnFailure.patch > > > The stopOnFailure parameter from ReportingMojoSupport is overridden in ModuleMojoSupport, which sets the default value to false as opposed to true in ReportingMojoSupport. The problem with this is that it can not be overridden from the command line or pom.xml. > The following build command will always succeed: > mvn geronimo:deploy-module -Ptools -DmoduleArchive=/no/such/archive/1.0/no-such-archive-1.0.war -DstopOnFailure=true > I have also created a sample project that demonstrates this: > svn checkout https://hypobytes.com/svn/ymir/geronimo/test/trunk geronimo-test > cd geronimo-test && mvn clean install -Pit > This build should fail because stopOnFailure is set to true in the project's POM. > I'm no Maven expert, but I've created a patch that simply removes the stopOnFailure parameter from ModuleMojoSupport and sets the default value to false in ReportingMojoSupport. I've not found a way to have it default to true in ReportingMojoSupport and false in ModuleMojoSupport. With this patch the Geronimo build still succeeds with normal tests, but I've not verified that integration tests also succeed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.