Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 39775 invoked from network); 24 Nov 2010 15:39:09 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 24 Nov 2010 15:39:09 -0000 Received: (qmail 54543 invoked by uid 500); 24 Nov 2010 15:39:40 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 54020 invoked by uid 500); 24 Nov 2010 15:39:40 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 54011 invoked by uid 99); 24 Nov 2010 15:39:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Nov 2010 15:39:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Nov 2010 15:39:37 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oAOFdFb0000297 for ; Wed, 24 Nov 2010 15:39:15 GMT Message-ID: <3310394.288021290613155848.JavaMail.jira@thor> Date: Wed, 24 Nov 2010 10:39:15 -0500 (EST) From: "Forrest Xia (JIRA)" To: dev@geronimo.apache.org Subject: [jira] Updated: (DAYTRADER-51) NPE when logging in with an unknown username MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DAYTRADER-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Forrest Xia updated DAYTRADER-51: --------------------------------- Component/s: (was: EJB Tier) Web Tier > NPE when logging in with an unknown username > -------------------------------------------- > > Key: DAYTRADER-51 > URL: https://issues.apache.org/jira/browse/DAYTRADER-51 > Project: DayTrader > Issue Type: Bug > Components: Web Tier > Affects Versions: 2.0 > Reporter: Jarek Gawor > Assignee: Forrest Xia > Fix For: 2.1.7, 2.2.1, 3.0-M2, 3.0 > > > I was testing DayTrayder (in web services mode) and tried to log in with a bad username. That resulted in a bad NPE exception because org.apache.geronimo.samples.daytrader.direct.TradeDirect.login() returned null instead of throwing an exception. I assume an exception should be raised. If null can be returned the web services code needs to be changed to handle that. > Here's what I see in the logs: > 14:29:43,775 ERROR [Log] Error: TradeDirect:login -- failure to find account forhhh > 14:29:43,776 ERROR [Log] Error: TradeDirect:login -- error logging in user > javax.ejb.FinderException: Cannot find account forhhh > javax.ejb.FinderException: Cannot find account forhhh > at org.apache.geronimo.samples.daytrader.direct.TradeDirect.login(TradeDirect.java:1487) > at org.apache.geronimo.samples.daytrader.TradeAction.login(TradeAction.java:455) > at org.apache.geronimo.samples.daytrader.soap.TradeWSAction.login(TradeWSAction.java:177) > ..... > Caused by: java.lang.NullPointerException > at org.apache.geronimo.samples.daytrader.soap.Convert.convertAccountDataBean(Convert.java:97) > at org.apache.geronimo.samples.daytrader.soap.TradeWSAction.login(TradeWSAction.java:177) > ... 41 more -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.