geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Trygve Sanne Hardersen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (GERONIMO-5668) Use fewer acceptor threads for Jetty
Date Mon, 01 Nov 2010 14:59:26 GMT

     [ https://issues.apache.org/jira/browse/GERONIMO-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Trygve Sanne Hardersen updated GERONIMO-5668:
---------------------------------------------

    Attachment: geronimo-2.2-1028765-jetty-trunk.patch

The slow shutdown was fixed in Jetty trunk in revision 2460. I have tested this with Geronimo
2.2 and with this shutdowns are fast even with many acceptor threads. However I still believe
the original patch should be kept because 50 acceptor threads generates a warning.

Attached is a patch that upgrades Geronimo 2.2 to use Jetty trunk (7.2.1-SNAPSHOT). The patch
changes the Jetty version number, adds the Jetty snapshot repository to the pom, and changes
the AbstractWebModuleTest to use the auth method string.

Feel free to remove my comments from the code - they are only there to explain the changes.
Thanks! 

> Use fewer acceptor threads for Jetty
> ------------------------------------
>
>                 Key: GERONIMO-5668
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5668
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Jetty
>    Affects Versions: 2.2.1
>         Environment: Only tested on OS X 1.6 with Java 1.6
>            Reporter: Trygve Sanne Hardersen
>         Attachments: geronimo-2.2-1027647-jetty-acceptors.patch, geronimo-2.2-1028765-jetty-trunk.patch
>
>
> Geronimo applies the maxThreads parameter as the number of acceptor threads in Jetty,
with a default value of 50. With newer versions (7.2.0) of Jetty this gives the following
warning during startup:
> # Acceptors should be <=2*availableProcessors
> Server shutdowns are also very slow, it takes about 1 second to stop each acceptor thread.
> The attached patch sets the number of acceptor threads to 2 per connector (HTTP, HTTPS
and AJP), and exposes this and the acceptor queue size (50) as a parameter in config-substitutions.properties.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message