Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (athena.apache.org: domain of c1vamsi1c@gmail.com
 designates 209.85.214.182 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=gDiAjRfFkMN7b/4xcO2lMHO9ZaMsFKUWTR9HxX59UQecDkx6T/w8rCSuv/mCxfmVbq
         AfcNuVzEFNNADzomh8FNX2Oxo6PunxPWCggcZZ1xrj5wrL3YAP7gteov6ihS6eOyXpGA
         mTgV7nS/o6sC2Fe5IMT3Fi9DUm0ehH1mT53XI=
MIME-Version: 1.0
In-Reply-To: <4CB5F7D7.2080007@gmail.com>
References: <4CB5F7D7.2080007@gmail.com>
Date: Thu, 14 Oct 2010 08:03:47 +0530
Message-ID: <AANLkTinH_bV1NUpj8EuMLODLaMa2b9UT0PsK5eejT9X0@mail.gmail.com>
Subject: Re: Bean Validation problems in trunk.
From: Vamsavardhana Reddy <c1vamsi1c@gmail.com>
To: dev@geronimo.apache.org, rickmcg@gmail.com
Content-Type: multipart/alternative; boundary=0016364ece56295eef04928a8a63

--0016364ece56295eef04928a8a63
Content-Type: text/plain; charset=ISO-8859-1

On Wed, Oct 13, 2010 at 11:47 PM, Rick McGuire <rickmcg@gmail.com> wrote:

>  The recent changes to the bean validation support appear to be causing
> failures in both the TCK and the bean validation testsuite.  I've tried to
> do a little problem determination, but I think Vamsi is probably going to
> need to take a look at this.  In the testsuite failures, it looks to me that
> the validation factory configuration is not getting set up correctly so that
> not all of the constraints are getting applied in the tests.  Many of the
> failures are just using the default constraint classes.
>
I see that only those constraint classes that are within the  same test
project are being used in the validation, but the default ones are not.  I
will take a look at what is happening.


> In the TCK, I'm seeing a lot of the same failures where the test was
> expecting constraint failures and not getting any, so this is probably the
> same thing.
>
> There's at least one other problem with the TCK.  A number of tests are
> getting deploy failures because of errors with the validation.xml.  Since
> these tests actually ARE tests for the invalid XML. this suggests that any
> parsing errors discovered at deploy time should not be terminal.
>
hmm...  I will change the deployment exceptions to log warning messages
instead.


>
> Rick
>


-- 
Vamsi

--0016364ece56295eef04928a8a63
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">On Wed, Oct 13, 2010 at 11:47 PM, Rick M=
cGuire <span dir=3D"ltr">&lt;<a href=3D"mailto:rickmcg@gmail.com">rickmcg@g=
mail.com</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=
=3D"margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); p=
adding-left: 1ex;">
=A0The recent changes to the bean validation support appear to be causing f=
ailures in both the TCK and the bean validation testsuite. =A0I&#39;ve trie=
d to do a little problem determination, but I think Vamsi is probably going=
 to need to take a look at this. =A0In the testsuite failures, it looks to =
me that the validation factory configuration is not getting set up correctl=
y so that not all of the constraints are getting applied in the tests. =A0M=
any of the failures are just using the default constraint classes.<br>
</blockquote><div>I see that only those constraint classes that are within =
the=A0 same test project are being used in the validation, but the default =
ones are not.=A0 I will take a look at what is happening.<br><br></div><blo=
ckquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 0pt 0.8ex; border-le=
ft: 1px solid rgb(204, 204, 204); padding-left: 1ex;">

<br>
In the TCK, I&#39;m seeing a lot of the same failures where the test was ex=
pecting constraint failures and not getting any, so this is probably the sa=
me thing.<br>
<br>
There&#39;s at least one other problem with the TCK. =A0A number of tests a=
re getting deploy failures because of errors with the validation.xml. =A0Si=
nce these tests actually ARE tests for the invalid XML. this suggests that =
any parsing errors discovered at deploy time should not be terminal.<br>
</blockquote><div>hmm...=A0 I will change the deployment exceptions to log =
warning messages instead.<br><br>=A0<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 20=
4, 204); padding-left: 1ex;">
<font color=3D"#888888">
<br>
Rick<br>
</font></blockquote></div><br><br clear=3D"all"><br>-- <br>Vamsi<br>

--0016364ece56295eef04928a8a63--