Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 16962 invoked from network); 19 Oct 2010 06:51:19 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 19 Oct 2010 06:51:19 -0000 Received: (qmail 77970 invoked by uid 500); 19 Oct 2010 06:51:18 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 77823 invoked by uid 500); 19 Oct 2010 06:51:18 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 77816 invoked by uid 99); 19 Oct 2010 06:51:18 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Oct 2010 06:51:18 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of genspring@gmail.com designates 209.85.212.54 as permitted sender) Received: from [209.85.212.54] (HELO mail-vw0-f54.google.com) (209.85.212.54) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Oct 2010 06:51:10 +0000 Received: by vws1 with SMTP id 1so1057297vws.13 for ; Mon, 18 Oct 2010 23:50:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=3znKfgBEM3IVJcrt0pBrbVRjSiDT/XPN674q4Mm2c00=; b=iy3L67bbSdrpa9NtWxc6STcPz7ZkHLefqfvZpCzY7WQ652fqj1BsL7AsN8O4lXN5PX BquqioW875MQVOHyMsVvvl243tNCTrZxS3gOL7RhQTMdfblDwICqbg2BIuARKV1xm7Do iX5pjInnL+41PGXc4nQ54/fKST/4yzO2Z5UHI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=lMMhbLpLZCTWJA62YCbHuVhfA+v0M/ISnwP08UyzF78LTyB32imzK4Ho5F0+3oQJ3y WVUaWi+9/UOk9/ny2rup32ZU7khz7H0k8eXGilbDFjWRRYY3RzkVkinQP0kDN0eJvVcr tSGPGmtL2lfR9nHlGHFIKShaSeH2SPGFf9QXU= MIME-Version: 1.0 Received: by 10.220.180.201 with SMTP id bv9mr125250vcb.112.1287471049121; Mon, 18 Oct 2010 23:50:49 -0700 (PDT) Received: by 10.220.185.134 with HTTP; Mon, 18 Oct 2010 23:50:49 -0700 (PDT) In-Reply-To: <4415944.16521287381145584.JavaMail.jira@thor> References: <20390966.11211287345202376.JavaMail.jira@thor> <4415944.16521287381145584.JavaMail.jira@thor> Date: Tue, 19 Oct 2010 14:50:49 +0800 Message-ID: Subject: Re: [jira] Updated: (GERONIMO-5649) txmanager could try to replace dead XAResources in commit and rollback tasks From: Shawn Jiang To: dev@geronimo.apache.org Content-Type: multipart/alternative; boundary=90e6ba53abb48aa11a0492f2b684 X-Virus-Checked: Checked by ClamAV on apache.org --90e6ba53abb48aa11a0492f2b684 Content-Type: text/plain; charset=ISO-8859-1 Shall we include this fix into the coming 2.2.1 release ? On Mon, Oct 18, 2010 at 1:52 PM, David Jencks (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/GERONIMO-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] > > David Jencks updated GERONIMO-5649: > ----------------------------------- > > Attachment: GERONIMO-5649-2.patch > > Fixes tx state and a connection leak when we have to get a new connection > to retry commit/rollback. > > > txmanager could try to replace dead XAResources in commit and rollback > tasks > > > ---------------------------------------------------------------------------- > > > > Key: GERONIMO-5649 > > URL: https://issues.apache.org/jira/browse/GERONIMO-5649 > > Project: Geronimo > > Issue Type: Bug > > Security Level: public(Regular issues) > > Components: transaction manager > > Affects Versions: 2.2, 3.0 > > Reporter: David Jencks > > Assignee: David Jencks > > Fix For: 2.2.1, 3.0 > > > > Attachments: GERONIMO-5649-1.patch, GERONIMO-5649-2.patch > > > > > > Generally if a RM crashes, outbound connections to it need to be > reestablished. So if we have a in-doubt tx using an outbound connection, we > should try to get a new XAResource to finish up the branch in the CommitTask > and proposed RollbackTask. > > AFAIK inbound connections will automatically reestablish connections and > use the RETRY error code so we don't need to do this for inbound. I still > need to find out which error codes indicate that we should get a new > connection and try again. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > -- Shawn --90e6ba53abb48aa11a0492f2b684 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Shall we include this fix into the coming 2.2.1 release=A0 ?=A0

On Mon, Oct 18, 2010 at 1:52 PM, David Jencks (JIRA= ) <jira@apache.org<= /a>> wrote:
=A0 =A0Attachment: GERONIMO-5649-2.patch

Fixes tx state and a connection leak when we have to get a new connection t= o retry commit/rollback.

> txmanager could try to replace dead XAResources in commit and rollback= tasks
> ----------------------------------------------------------------------= ------
>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Key: GERONIMO-5649
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 URL: https://issues.apache.org/= jira/browse/GERONIMO-5649
> =A0 =A0 =A0 =A0 =A0 =A0 Project: Geronimo
> =A0 =A0 =A0 =A0 =A0Issue Type: Bug
> =A0 =A0 =A0Security Level: public(Regular issues)
> =A0 =A0 =A0 =A0 =A0Components: transaction manager
> =A0 =A0Affects Versions: 2.2, 3.0
> =A0 =A0 =A0 =A0 =A0 =A0Reporter: David Jencks
> =A0 =A0 =A0 =A0 =A0 =A0Assignee: David Jencks
> =A0 =A0 =A0 =A0 =A0 =A0 Fix For: 2.2.1, 3.0
>
> =A0 =A0 =A0 =A0 Attachments: GERONIMO-5649-1.patch, GERONIMO-564= 9-2.patch
>
>
> Generally if a RM crashes, outbound connections to it need to be reest= ablished. =A0So if we have a in-doubt tx using an outbound connection, we s= hould try to get a new XAResource to finish up the branch in the CommitTask= and proposed RollbackTask.
> AFAIK inbound connections will automatically reestablish connections a= nd use the RETRY error code so we don't need to do this for inbound. = =A0I still need to find out which error codes indicate that we should get a= new connection and try again.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.




--
Shawn
--90e6ba53abb48aa11a0492f2b684--