geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-5634) Improve ServletContainerInitializer support
Date Thu, 07 Oct 2010 01:38:31 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918758#action_12918758
] 

David Jencks commented on GERONIMO-5634:
----------------------------------------

The code I've found that looks at ServletContainerInitializer is in MergeHelper and it looks
like it is using BundleAssignableClassFinder, which looks to me like it will find classes
that implement or extend a set of supplied classes.  I don't see any annotation scanning in
that class.

The javadoc for HandlesTypes indicates that if you include an annotation class, you'll get
all the classes annotated at the class level with this annotation.  I don't see any code to
implement this.  Am I missing something?

> Improve ServletContainerInitializer support
> -------------------------------------------
>
>                 Key: GERONIMO-5634
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5634
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: javaee6, Jetty, Tomcat, web
>    Affects Versions: 3.0
>            Reporter: David Jencks
>
> Our ServletContainerInitializer is incomplete and not osgi friendly.  We currently don't
support searching for classes with an annotation when the annotation is specified in the "interested
in" annotation. Also we look for ServletContainerInitializers at deploy time not run time.
 Although I used to think this was OK, I no longer think it is sufficiently osgi friendly.
 I think we need to look for both ServletContainerInitializers when starting the web app using
ServiceLocator (as well as in the bundle itself) and look for the classes in the bundle and
any fragment bundle that may have been added since deployment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message