geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-5644) Share global annotation finder among different components
Date Thu, 14 Oct 2010 15:58:33 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920995#action_12920995
] 

David Jencks commented on GERONIMO-5644:
----------------------------------------

I think this is a good idea.  I would look at what openejb does for one possible implementation
strategy.

I have considered two options when I've thought about this.  I don't know which implementation
I'd prefer.

1. we know all the specs we are supporting, so we can just create a finder that looks for
anything of any possible interest.  If the module that provides deploy time or runtime support
for a some of the classes we find isn't running, we just ignore those classes we found.

2. we could have each MBE and if necessary naming builder add the annotations it's interested
in to a list.  I think this would need a new method in the MBE interface.

(2) is more like how we've structured other parts of deployment.

There might be other better ways than either of these ideas.

> Share global annotation finder among different components
> ---------------------------------------------------------
>
>                 Key: GERONIMO-5644
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5644
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 3.0
>            Reporter: Ivan
>            Assignee: viola.lu
>             Fix For: 3.0
>
>
> Remember that I mentioned it in the past, while working at JSF integration, I found that
the global annoation scanning is required, too.
>  I am thinking that we could create a BundleAnnotationFinder for each application, for
web application, servlet, jsf, jaxws, webbeans and jax-rs should be able to share the same
finder, for ejb application, ejb and webbeans should be able to share the same finder. But
there might be problems for the scan scope, as different components might require different
scanning scope.
> Anothing solution is that we might provide some callback methods for interesting annotation,
like equal scenario ( Most scanning requiremetns are in this scenrio), and extend scenario
( guess that webbeans ??? )
> Any comment ? 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message