Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (nike.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=DKIM-Signature:Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:Content-Type:Content-Transfer-Encoding:Subject:Date:Message-Id:To:Mime-Version:X-Mailer;
  b=aeaf3cY+2IrccxpPPn/5npAIcnEdaUgwwboX33lojpRXkQc7hxB6SLh4sUsvcwOjV2efnmBeOYaUPFSqEpZmrzivPeubkcb87BxvgUyMhtEXiFE9LO4YvZKP8J5cmvqHWn/LO7N62YOtuzYPQ8GHGUDal7CIU0hQLRAU69Cf66M=
  ;
From: David Jencks <david_jencks@yahoo.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Subject: Possible questionable change in CertificatePropertiesFileLoginModule
Date: Tue, 21 Sep 2010 15:37:33 -0700
Message-Id: <98BB4339-EB55-46BA-BFC5-917E239D4734@yahoo.com>
To: "Geronimo Dev List \(JIRA\)" <dev@geronimo.apache.org>
Mime-Version: 1.0 (Apple Message framework v1081)

See  GERONIMO-5619, rev 999674 (trunk)

Briefly, I've modified CertificatePropertiesFileLoginModule so it works =
with either a CertificateCallback (used by tomcat) or a NameCallback =
(used by jetty).  In either case we just check that we know about the =
x500 principal name, there is no password checking.  (we rely on ssl to =
validate the client cert).

Does anyone think this is an undesirable security problem?  It might be =
possible to misconfigure security so that e.g. basic or form auth ended =
up using this login module and just checked the user name and not the =
password.  I don't think this is sufficiently likely to worry about, =
since these principal names are ldap goo (ou=3D.....,) and I would =
expect any such misconfiguration to be immediately evident in testing.

thanks
david jencks