geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Jencks (JIRA)" <j...@apache.org>
Subject [jira] Commented: (GERONIMO-5624) use info tree for tomcat web app deployment
Date Thu, 23 Sep 2010 05:57:32 GMT

    [ https://issues.apache.org/jira/browse/GERONIMO-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913914#action_12913914
] 

David Jencks commented on GERONIMO-5624:
----------------------------------------

I slightly modified the patch and committed it in rev 1000329.  Nice work!

My changes involve:
- not moving the info builder/factories
- not copying the WebAppInfo from the xml, and just adding the security constraints from annotations
and dynamic registrations.

I don't see anything wrong with modifying the WebAppInfo, since I think we want to end up
with a complete info tree for what we actually run and don't need the xml-only tree.

I'm going to look into whether we can get jetty and hopefully tomcat to push the servlet security
info from ServletRegistration.Dynamic to somewhere we can get it without wrapping the registration.
 I think it will be pretty easy in jetty.

> use info tree for tomcat web app deployment
> -------------------------------------------
>
>                 Key: GERONIMO-5624
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-5624
>             Project: Geronimo
>          Issue Type: Improvement
>      Security Level: public(Regular issues) 
>          Components: Tomcat
>    Affects Versions: 3.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 3.0
>
>         Attachments: GERONIMO-5624.patch
>
>
> We can avoid firing up a digester instance for tomcat by using the same info tree as
for jetty.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message