Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geronimo.apache.org
Received-SPF: pass (nike.apache.org: local policy)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com;
  h=DKIM-Signature:Received:X-Yahoo-SMTP:X-YMail-OSG:X-Yahoo-Newman-Property:From:Mime-Version:Content-Type:Subject:Date:In-Reply-To:To:References:Message-Id:X-Mailer;
  b=UWDvGBKrfQd3aKylGSl5r7oQIn05TdT8EpbjFMB0hw+xxtNhFz9b+8aNymmJaWHn5Bm9YCjEl9Mt3SqhP+DX6izqVnJ4T35h7D5ZUVzm8wqzrP2ch2VSw+ENPOPyMHBvxQl1Jhr5hwtDs6U4+1vuYSrsiVGnnGgKp3X5MDQwsw8=
  ;
From: David Jencks <david_jencks@yahoo.com>
Mime-Version: 1.0 (Apple Message framework v1081)
Content-Type: multipart/alternative; boundary=Apple-Mail-13-170203396
Subject: Re: ${project.version} is a problem..
Date: Wed, 14 Jul 2010 09:31:53 -0700
In-Reply-To: <AANLkTilF7bu_Vkdn6R_khsDwjFFvr4LZnU2k-JzswOdm@mail.gmail.com>
To: dev@geronimo.apache.org
References: <AANLkTilF7bu_Vkdn6R_khsDwjFFvr4LZnU2k-JzswOdm@mail.gmail.com>
Message-Id: <C9CCC7B0-C985-4AC8-8B8A-34E61A1BFE90@yahoo.com>


--Apple-Mail-13-170203396
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii


On Jul 13, 2010, at 7:56 PM, Rex Wang wrote:

> Hi,
>=20
> I suggest we stop using ${project.version} in 3.0's pom.
> This maven variable will magicly change when I create a new =
sub-project which has it own version.
> For example,
> When I create a new server assembly "abc" under the assemblies =
project, and the abc's pom has it own version 3.0.0.0:
>     <parent>
>         <groupId>org.apache.geronimo.assemblies</groupId>
>         <artifactId>assemblies</artifactId>
>         <version>3.0-M1</version>
>     </parent>
>    =20
>     <groupId>c.i.w.assemblies</groupId>
>     <artifactId>abc</artifactId>
>     <version>3.0.0.0</version>
>     <packaging>server-assembly</packaging>
>=20
> Then, in its effective pom, maven will replace all the =
${project.version} defined in parent pom with 3.0.0.0
>=20
> I think we use ${geronimoVersion} instead and specify geronimoVersion =
explicitly in root pom.
>=20
> Thoughts?

I think this is a really bad idea.  In your example above, you should =
not have the explicit version <version>3.0.0.0</version>

Generally, if you want a different version for a particular project, put =
the project in a different tree without a file system parent pom.  There =
are a few special cases like the bundles.... even those probably =
shouldn't have a file system parent pom (not actually sure if they do =
right now).

thanks
david jencks

>=20
> --=20
> Lei Wang (Rex)
> rwonly AT apache.org


--Apple-Mail-13-170203396
Content-Transfer-Encoding: 7bit
Content-Type: text/html;
	charset=us-ascii

<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 13, 2010, at 7:56 PM, Rex Wang wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hi,<br><br>I suggest we stop using ${project.version} in 3.0's pom.<br>This maven variable will magicly change when I create a new sub-project which has it own version.<br>For example,<br>When I create a new server assembly "abc" under the assemblies project, and the abc's pom has it own version <a href="http://3.0.0.0/">3.0.0.0</a>:<br>
&nbsp;&nbsp;&nbsp; &lt;parent&gt;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &lt;groupId&gt;org.apache.geronimo.assemblies&lt;/groupId&gt;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &lt;artifactId&gt;assemblies&lt;/artifactId&gt;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; &lt;version&gt;3.0-M1&lt;/version&gt;<br>&nbsp;&nbsp;&nbsp; &lt;/parent&gt;<br>
&nbsp;&nbsp;&nbsp; <br>&nbsp;&nbsp;&nbsp; &lt;groupId&gt;c.i.w.assemblies&lt;/groupId&gt;<br>&nbsp;&nbsp;&nbsp; &lt;artifactId&gt;abc&lt;/artifactId&gt;<br>&nbsp;&nbsp;&nbsp; &lt;version&gt;3.0.0.0&lt;/version&gt;<br>&nbsp;&nbsp;&nbsp; &lt;packaging&gt;server-assembly&lt;/packaging&gt;<br clear="all">
<br>Then, in its effective pom, maven will replace all the ${project.version} defined in parent pom with 3.0.0.0<br><br>I think we use ${geronimoVersion} instead and specify geronimoVersion explicitly in root pom.<br><br>
Thoughts?<br></blockquote><div><br></div>I think this is a really bad idea. &nbsp;In your example above, you should not have the explicit version &lt;version&gt;3.0.0.0&lt;/version&gt;</div><div><br></div><div>Generally, if you want a different version for a particular project, put the project in a different tree without a file system parent pom. &nbsp;There are a few special cases like the bundles.... even those probably shouldn't have a file system parent pom (not actually sure if they do right now).</div><div><br></div><div>thanks</div><div>david jencks</div><div><br><blockquote type="cite"><br>-- <br>Lei Wang (Rex)<br>rwonly AT <a href="http://apache.org/">apache.org</a><br>
</blockquote></div><br></body></html>
--Apple-Mail-13-170203396--