Return-Path: 
 <dev-return-84207-apmail-geronimo-dev-archive=geronimo.apache.org@geronimo.apache.org>
Delivered-To: apmail-geronimo-dev-archive@www.apache.org
Received: (qmail 62745 invoked from network); 15 Jul 2010 03:33:05 -0000
Received: from unknown (HELO mail.apache.org) (140.211.11.3)
  by 140.211.11.9 with SMTP; 15 Jul 2010 03:33:05 -0000
Received: (qmail 98542 invoked by uid 500); 15 Jul 2010 03:33:04 -0000
Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org
Received: (qmail 98179 invoked by uid 500); 15 Jul 2010 03:33:02 -0000
Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@geronimo.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@geronimo.apache.org>
List-Post: <mailto:dev@geronimo.apache.org>
Reply-To: dev@geronimo.apache.org
List-Id: <dev.geronimo.apache.org>
Delivered-To: mailing list dev@geronimo.apache.org
Received: (qmail 98172 invoked by uid 99); 15 Jul 2010 03:33:01 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jul 2010 03:33:01 +0000
X-ASF-Spam-Status: No, hits=2.2 required=10.0
	tests=FREEMAIL_FROM,HTML_MESSAGE,NORMAL_HTTP_TO_IP,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of rwonly@gmail.com designates
 209.85.160.54 as permitted sender)
Received: from [209.85.160.54] (HELO mail-pw0-f54.google.com) (209.85.160.54)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jul 2010 03:32:53 +0000
Received: by pwj9 with SMTP id 9so123425pwj.13
        for <dev@geronimo.apache.org>; Wed, 14 Jul 2010 20:32:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:received:in-reply-to
         :references:date:message-id:subject:from:to:content-type;
        bh=jmMswwfyYjWJsf+xhBhHOS4IFBAmnQrnj8X3bjwTojE=;
        b=ctW/AK9Z47UXdl1GYrds+Mif30806I7esT0SG1IeUeYh2xPIaAoJvp1GvpRr2sPxwe
         /54usTpfI3wrZzSDABKcQzg3+xqF9uwlRfISpt7tc5HYlvAFWMcAevpuflO33R8L4bSQ
         9LGQaCG/hu5EQmUZ7kSi+o5BLeBLUQt9Vp7yw=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=Oa8/Mu/lbgoI/KhRJR05c6hDu0LlaiRD3I0OX+yA0Qe1cNl956cuYLDOTvd4YGNnkW
         L0YgVjsbgT0yFQFPq3Z5P719LpuZNpS8bGvaccVnZ0wKwZqiaugsskecg+IZupPSvF4j
         RyLJne1zMjUPvwdz92YUqtcfXu861B+N4eCAI=
MIME-Version: 1.0
Received: by 10.142.223.14 with SMTP id v14mr4696696wfg.44.1279164751750;
 Wed,
	14 Jul 2010 20:32:31 -0700 (PDT)
Received: by 10.142.200.16 with HTTP; Wed, 14 Jul 2010 20:32:31 -0700 (PDT)
In-Reply-To: <C9CCC7B0-C985-4AC8-8B8A-34E61A1BFE90@yahoo.com>
References: <AANLkTilF7bu_Vkdn6R_khsDwjFFvr4LZnU2k-JzswOdm@mail.gmail.com>
	<C9CCC7B0-C985-4AC8-8B8A-34E61A1BFE90@yahoo.com>
Date: Thu, 15 Jul 2010 11:32:31 +0800
Message-ID: <AANLkTinIQKtUM62iMIOkxpu37hL7lb9OA0mM4whcm30J@mail.gmail.com>
Subject: Re: ${project.version} is a problem..
From: Rex Wang <rwonly@gmail.com>
To: dev@geronimo.apache.org
Content-Type: multipart/alternative; boundary=000e0cd2579aa324ff048b64c0e4
X-Virus-Checked: Checked by ClamAV on apache.org

--000e0cd2579aa324ff048b64c0e4
Content-Type: text/plain; charset=ISO-8859-1

2010/7/15 David Jencks <david_jencks@yahoo.com>

>
> On Jul 13, 2010, at 7:56 PM, Rex Wang wrote:
>
> Hi,
>
> I suggest we stop using ${project.version} in 3.0's pom.
> This maven variable will magicly change when I create a new sub-project
> which has it own version.
> For example,
> When I create a new server assembly "abc" under the assemblies project, and
> the abc's pom has it own version 3.0.0.0:
>     <parent>
>         <groupId>org.apache.geronimo.assemblies</groupId>
>         <artifactId>assemblies</artifactId>
>         <version>3.0-M1</version>
>     </parent>
>
>     <groupId>c.i.w.assemblies</groupId>
>     <artifactId>abc</artifactId>
>     <version>3.0.0.0</version>
>     <packaging>server-assembly</packaging>
>
> Then, in its effective pom, maven will replace all the ${project.version}
> defined in parent pom with 3.0.0.0
>
> I think we use ${geronimoVersion} instead and specify geronimoVersion
> explicitly in root pom.
>
> Thoughts?
>
>
> I think this is a really bad idea.  In your example above, you should not
> have the explicit version <version>3.0.0.0</version>
>
>

> Generally, if you want a different version for a particular project, put
> the project in a different tree without a file system parent pom.
>
It will save a lot of time to create a custom assembly with geronimo's
parent pom..and if all the sub-poms can not have its version and must use
{project.version}, which is actually the geronimo root pom's version. What's
the difference/risk between using a geronimoVersion property and that?
Actually, geronimoVersion has already been used in 3.0-m1 & trunk...

-Rex


> There are a few special cases like the bundles.... even those probably
> shouldn't have a file system parent pom (not actually sure if they do right
> now).
>
> thanks
> david jencks
>
>
> --
> Lei Wang (Rex)
> rwonly AT apache.org
>
>
>


-- 
Lei Wang (Rex)
rwonly AT apache.org

--000e0cd2579aa324ff048b64c0e4
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<br><br><div class=3D"gmail_quote">2010/7/15 David Jencks <span dir=3D"ltr"=
>&lt;<a href=3D"mailto:david_jencks@yahoo.com">david_jencks@yahoo.com</a>&g=
t;</span><br><blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 0pt=
 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div style=3D"word-wrap: break-word;"><br><div><div><div class=3D"h5"><div>=
On Jul 13, 2010, at 7:56 PM, Rex Wang wrote:</div><br><blockquote type=3D"c=
ite">Hi,<br><br>I suggest we stop using ${project.version} in 3.0&#39;s pom=
.<br>
This maven variable will magicly change when I create a new sub-project whi=
ch has it own version.<br>For example,<br>When I create a new server assemb=
ly &quot;abc&quot; under the assemblies project, and the abc&#39;s pom has =
it own version <a href=3D"http://3.0.0.0/" target=3D"_blank">3.0.0.0</a>:<b=
r>

=A0=A0=A0 &lt;parent&gt;<br>=A0=A0=A0=A0=A0=A0=A0 &lt;groupId&gt;org.apache=
.geronimo.assemblies&lt;/groupId&gt;<br>=A0=A0=A0=A0=A0=A0=A0 &lt;artifactI=
d&gt;assemblies&lt;/artifactId&gt;<br>=A0=A0=A0=A0=A0=A0=A0 &lt;version&gt;=
3.0-M1&lt;/version&gt;<br>=A0=A0=A0 &lt;/parent&gt;<br>

=A0=A0=A0 <br>=A0=A0=A0 &lt;groupId&gt;c.i.w.assemblies&lt;/groupId&gt;<br>=
=A0=A0=A0 &lt;artifactId&gt;abc&lt;/artifactId&gt;<br>=A0=A0=A0 &lt;version=
&gt;3.0.0.0&lt;/version&gt;<br>=A0=A0=A0 &lt;packaging&gt;server-assembly&l=
t;/packaging&gt;<br clear=3D"all">

<br>Then, in its effective pom, maven will replace all the ${project.versio=
n} defined in parent pom with 3.0.0.0<br><br>I think we use ${geronimoVersi=
on} instead and specify geronimoVersion explicitly in root pom.<br><br>

Thoughts?<br></blockquote><div><br></div></div></div>I think this is a real=
ly bad idea. =A0In your example above, you should not have the explicit ver=
sion &lt;version&gt;3.0.0.0&lt;/version&gt;<br>=A0</div></div></blockquote>
<blockquote class=3D"gmail_quote" style=3D"margin: 0pt 0pt 0pt 0.8ex; borde=
r-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div style=3D"wor=
d-wrap: break-word;"><div><br></div><div>Generally, if you want a different=
 version for a particular project, put the project in a different tree with=
out a file system parent pom. =A0</div>
</div></blockquote><div>It will save a lot of time to create a custom assem=
bly with geronimo&#39;s parent pom..and if all the sub-poms can not have it=
s version and must use {project.version}, which is actually the geronimo ro=
ot pom&#39;s version. What&#39;s the difference/risk between using a geroni=
moVersion property and that? Actually, geronimoVersion has already been use=
d in 3.0-m1 &amp; trunk...<br>
<br>-Rex<br>=A0</div><blockquote class=3D"gmail_quote" style=3D"margin: 0pt=
 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1e=
x;"><div style=3D"word-wrap: break-word;"><div>There are a few special case=
s like the bundles.... even those probably shouldn&#39;t have a file system=
 parent pom (not actually sure if they do right now).</div>
<div><br></div><div>thanks</div><div>david jencks</div><div class=3D"im"><d=
iv><br><blockquote type=3D"cite"><br>-- <br>Lei Wang (Rex)<br>rwonly AT <a =
href=3D"http://apache.org/" target=3D"_blank">apache.org</a><br>
</blockquote></div><br></div></div></blockquote></div><br><br clear=3D"all"=
><br>-- <br>Lei Wang (Rex)<br>rwonly AT <a href=3D"http://apache.org">apach=
e.org</a><br>

--000e0cd2579aa324ff048b64c0e4--