Return-Path: Delivered-To: apmail-geronimo-dev-archive@www.apache.org Received: (qmail 81755 invoked from network); 22 Jul 2010 01:41:49 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 22 Jul 2010 01:41:49 -0000 Received: (qmail 3563 invoked by uid 500); 22 Jul 2010 01:41:49 -0000 Delivered-To: apmail-geronimo-dev-archive@geronimo.apache.org Received: (qmail 3472 invoked by uid 500); 22 Jul 2010 01:41:48 -0000 Mailing-List: contact dev-help@geronimo.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@geronimo.apache.org List-Id: Delivered-To: mailing list dev@geronimo.apache.org Received: (qmail 3465 invoked by uid 99); 22 Jul 2010 01:41:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jul 2010 01:41:48 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=FREEMAIL_FROM,HTML_MESSAGE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of daition@gmail.com designates 209.85.161.182 as permitted sender) Received: from [209.85.161.182] (HELO mail-gx0-f182.google.com) (209.85.161.182) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Jul 2010 01:41:40 +0000 Received: by gxk24 with SMTP id 24so5180552gxk.13 for ; Wed, 21 Jul 2010 18:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=r9gYX7h9t9v0yX71cLdtSjg0FsLekqqyTKHpVnwiYuo=; b=ci0YCLEWaK+YKpc+cmoM0fu7Flp6jL5QoY6c9mR6+WZI61Pk02E9HdfChd1hQxPGhu FGFwHaL63YQ5i4kDgZfZtDaHRaOahC93+k0BafSc0MgiDuiG1RjGLOPHqzDMZ+qX+k3g nQ0C2470OEyKx99VIzwW05fmC8NJLoSoBF2xo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=K17LnVv5kMtbIXUIjYRCSm8pLitl/x/+f68Rri0i8OjGvRvOIbTh355EEswxBIc+H8 rhBzz07lD6TjqeZLc42vhocXX4qrMgqfOibMwr655nax1TTcm/7vA+fFKrfyXttyu/MT xYE56ywvLUXfrHteqL/BhCNAY+cQxUS4MjHsc= MIME-Version: 1.0 Received: by 10.224.45.208 with SMTP id g16mr776826qaf.326.1279762879362; Wed, 21 Jul 2010 18:41:19 -0700 (PDT) Received: by 10.229.45.70 with HTTP; Wed, 21 Jul 2010 18:41:19 -0700 (PDT) In-Reply-To: References: <4C46CB47.8070306@gmail.com> Date: Thu, 22 Jul 2010 09:41:19 +0800 Message-ID: Subject: Re: [VOTE] External tomcat-parent-6.0.28 From: Delos To: dev@geronimo.apache.org Content-Type: multipart/alternative; boundary=0015175cdf36d23697048bf00328 X-Virus-Checked: Checked by ClamAV on apache.org --0015175cdf36d23697048bf00328 Content-Type: text/plain; charset=ISO-8859-1 Thanks for your comments, I will update it and launch another voting. BTW, do we need to run TCK just for the external tomcat 6.0.28.0. 2010/7/21 Ivan > I think that you need to build it with JDK 1.5. Here is my -1. > > 2010/7/21 Rick McGuire > > I see a couple minor problems, but I'm not sure these are critical enough >> to restart the vote: >> >> 1) The NOTICE file still shows a 2009 copyright date >> 2) It would be nice if there were a README.txt file like the one in the >> tomcat-parent-7.0.0.0 version that details how to recreate this and what >> patches are applied to this version. >> >> Rick >> >> >> On 7/21/2010 4:58 AM, Delos wrote: >> >>> This voting is for mavenized tomcat 6.0.28. Following what we did to >>> tomcat 6.0.20, we are using a forked copy of tomcat derived from the tomcat >>> 6.0.28 release, built with maven, with maven dependencies, etc etc. Besides, >>> we also applied some patches which haven't been included in tomcat 6.0.28. >>> >>> >>> Based on tomcat 6.0.28 tag, I also applied another couple of patches: >>> >>> GERONIMO-3451 'Restricted listeners property file not found' error logged >>> during Tomcat server startup >>> GERONIMO-4685 Include patches for revision #790742 >>> >>> >>> Staging repo: >>> https://repository.apache.org/content/repositories/orgapachegeronimo-026/ >>> >>> >>> svn tag at: >>> >>> http://svn.apache.org/repos/asf/geronimo/external/tags/tomcat-parent-6.0.28.0/ >>> >>> >>> [ ] +1 go for it >>> [ ] 0 >>> [ ] -1 whoa, hold on a minute >>> >>> Vote open 72 hours >>> >>> thanks a lot! >>> >>> >>> -- >>> Best Regards, >>> >>> Delos >>> >> >> > > > -- > Ivan > -- Best Regards, Delos --0015175cdf36d23697048bf00328 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Thanks for your comments, I will update it and launch another voting.<= /div>

BTW, do we need to run TCK just for the external t= omcat 6.0.28.0.

2010/7/21 Ivan <xhhsld@gmail.com>
I think that you need to build it with JDK = 1.5. Here is my -1.

2010/7/21 Rick McGuir= e <rickmcg@gmail.com>

I see a couple minor problems, but I'm not sure these are critical enou= gh to restart the vote:

1) =A0The NOTICE file still shows a 2009 copyright date
2) =A0It would be nice if there were a README.txt file like the one in the = tomcat-parent-7.0.0.0 version that details how to recreate this and what pa= tches are applied to this version.

Rick


On 7/21/2010 4:58 AM, Delos wrote:
This voting is for mavenized tomcat 6.0.28. Following what we did to tomcat= 6.0.20, we are using a forked copy of tomcat derived from the tomcat 6.0.2= 8 release, built with maven, with maven dependencies, etc etc. Besides, we = also applied some patches which haven't been included in tomcat 6.0.28.=


Based on tomcat 6.0.28 tag, I also applied another couple of patches:

GERONIMO-3451 'Restricted listeners property file not found' error = logged during Tomcat server startup
GERONIMO-4685 Include patches for revision #790742


Staging repo:
https://repository.apache.org/content/reposito= ries/orgapachegeronimo-026/


svn tag at:
http://svn.apache.org/repos/asf/geronimo/= external/tags/tomcat-parent-6.0.28.0/


[ ] +1 go for it
[ ] 0
[ ] -1 whoa, hold on a minute

Vote open 72 hours

thanks a lot!


--
Best Regards,

Delos




-- Ivan



--
Best Regards,
Delos
--0015175cdf36d23697048bf00328--