geronimo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Donald Woods <dwo...@apache.org>
Subject Re: ${project.version} is a problem..
Date Wed, 14 Jul 2010 18:31:10 GMT
I see this as a common use case, where users want to build their own
assemblies, but want ONE place to change the Geronimo version they are
using (as using <scope>import</scope> doesn't resolve this for every
case anymore.)  Heck, we even use this method for our TCK builds.....

-Donald


On 7/14/10 12:31 PM, David Jencks wrote:
> 
> On Jul 13, 2010, at 7:56 PM, Rex Wang wrote:
> 
>> Hi,
>>
>> I suggest we stop using ${project.version} in 3.0's pom.
>> This maven variable will magicly change when I create a new
>> sub-project which has it own version.
>> For example,
>> When I create a new server assembly "abc" under the assemblies
>> project, and the abc's pom has it own version 3.0.0.0 <http://3.0.0.0/>:
>>     <parent>
>>         <groupId>org.apache.geronimo.assemblies</groupId>
>>         <artifactId>assemblies</artifactId>
>>         <version>3.0-M1</version>
>>     </parent>
>>    
>>     <groupId>c.i.w.assemblies</groupId>
>>     <artifactId>abc</artifactId>
>>     <version>3.0.0.0</version>
>>     <packaging>server-assembly</packaging>
>>
>> Then, in its effective pom, maven will replace all the
>> ${project.version} defined in parent pom with 3.0.0.0
>>
>> I think we use ${geronimoVersion} instead and specify geronimoVersion
>> explicitly in root pom.
>>
>> Thoughts?
> 
> I think this is a really bad idea.  In your example above, you should
> not have the explicit version <version>3.0.0.0</version>
> 
> Generally, if you want a different version for a particular project, put
> the project in a different tree without a file system parent pom.  There
> are a few special cases like the bundles.... even those probably
> shouldn't have a file system parent pom (not actually sure if they do
> right now).
> 
> thanks
> david jencks
> 
>>
>> -- 
>> Lei Wang (Rex)
>> rwonly AT apache.org <http://apache.org/>
> 

Mime
View raw message